New issue
Advanced search Search tips

Issue 678788 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jan 2017
Cc:
tkent@chromium.org
rbyers@chromium.org
jeffcarp@chromium.org
jsb...@chromium.org
dpranke@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[WPT Import/Export] Rename the LayoutTests/imported directory.

Project Member Reported by qyears...@chromium.org, Jan 5 2017 
Now that we're planning to support directly editing web platform tests in place in the Chromium repo, the name "imported" may be confusing because it suggests that the directory includes only imported changes and shouldn't be modified directly.

Possible options:
  Move contents of imported/ directly into LayoutTests. (e.g. there could be LayoutTests/wpt or LayoutTests/web-platform-tests).
  Rename "imported" to "w3c" (slightly more straightforward).

Does anyone have any opinions about this?

Comment 1 by foolip@chromium.org, Jan 5 2017 

Since WPT contains tests for specs other than W3C tests (at least WHATWG and Khronos) I would prefer just dropping the /imported/ path component.

Comment 2 by qyears...@chromium.org, Jan 5 2017

Components: Blink>Infra>Predictability
In that case, this would involve:

 1. Updating the paths in TestExpectation files and everywhere in webkitpy, and uploading a CL.
 2. Moving all test and baseline files.
 3. After review and testing, directly committing the CL (which would be too large to upload completely to Rietveld).

Comment 3 by foolip@chromium.org, Jan 6 2017 

Which bit is made more straightforward with a imported->something rename?

Comment 4 by qyears...@chromium.org, Jan 6 2017 

Re #3: I think some parts of the changes in Tools/Scripts/webkitpy may be simpler, and the current OWNERS & README in imported/ would be kept as-is.

Comment 5 by foolip@chromium.org, Jan 6 2017 

We could change "imported" to something that means "two-way sync" or "canonical copy elsewhere" perhaps. If it wasn't already on the path, third_party might work, but it's long.

Comment 6 by rbyers@chromium.org, Jan 6 2017 

"external"?  Or "synchronized"?

Comment 7 by jeffcarp@chromium.org, Jan 6 2017 

Is doing both also an option? We could rename first, then move the directory later if necessary. I like 'synchronized'.

Comment 8 by msrchandra@chromium.org, Jan 10 2017

Labels: TE-NeedsTriageHelp

Comment 9 by foolip@chromium.org, Jan 10 2017 

external has the benefit of being shorter, in fact the same length as imported, so no new file path length issues.

Comment 10 by qyears...@chromium.org, Jan 12 2017

Owner: qyears...@chromium.org
Status: Assigned (was: Unconfirmed)
Yeah, "external" is a bit shorter; I'll try that out. Just uploaded a CL with partial changes (http://crrev.com/2627213003).
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6506b8b80db745936336bb88855cd078c083691e

commit 6506b8b80db745936336bb88855cd078c083691e
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Jan 17 23:52:28 2017

Rename LayoutTests/imported/ -> LayoutTests/external/.

Reason: The name "imported" may lead people to believe that it's intended to be a "read-only" copy of the tests.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload.

This CL would have to be tested locally and landed directly. :-/

BUG= 678788 
R=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2627213003 .
Cr-Commit-Position: refs/heads/master@{#444194}

[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/components/test_runner/test_interfaces.cc
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/PRESUBMIT.py
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/WPTServeExpectations
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/OWNERS
[add] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/README
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/CONTRIBUTING.md
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/LICENSE.md
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/README.md
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/config.default.json
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-before-after-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-before-after-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-before-after-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-before-after-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-block-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-block-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-block-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-block-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-computed-style-expected.txt
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-computed-style.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-001-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-001-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-001-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-001-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-002-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-002-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-002-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-002-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-003-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-003-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-003-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-flex-003-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-list-001-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-list-001-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-list-001-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-list-001-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-multicol-001-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-multicol-001-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-multicol-001-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-multicol-001-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-001-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-001-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-001-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-001-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-002-inline-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-002-inline.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-002-none-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-dynamic-table-002-none.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-first-letter-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-first-letter-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-first-line-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-first-line-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-003-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-flex-003.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-float-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-float-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-inline-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-inline-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-inline-flex-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-inline-flex-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-list-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-list-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-multicol-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-multicol-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-oof-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-oof-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-oof-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-oof-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-replaced-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-replaced-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-table-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-table-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-table-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-table-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-td-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-td-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-text-only-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-text-only-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-tr-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-contents-tr-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/support/acid.css
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/support/swatch-orange.png
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/support/util.js
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/Flexible-order-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/Flexible-order.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-001.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-002.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-003-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-003.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-004-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-004.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-005-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-005.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-006-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-content-006.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-001-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-001.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-002-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-002.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-003-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-003.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-004-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-004.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-005-expected.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-items-005.htm
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-001-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-001.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-002-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-002.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-003-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-003.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-004-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-004.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-005-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-005.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-007-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-007.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-008-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-008.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-009-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-009.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-011-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-011.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-012-expected.xht
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/align-self-012.html
[rename] https://crrev.com/6506b8b80db745936336bb88855cd078c083691e/third_party/WebKit/LayoutTests/external/csswg-test/css
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d94c7b072f3b496815122c3c310456320d592c3c

commit d94c7b072f3b496815122c3c310456320d592c3c
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 18 01:23:05 2017

Move virtual/mojo-localstorage/imported -> external.

In http://crrev.com/2627213003, I moved the imported/ directory to external/ and made most related changes, but missed this related directory.

BUG= 678788 
NOTRY=true

Review-Url: https://codereview.chromium.org/2641683002
Cr-Commit-Position: refs/heads/master@{#444224}

[rename] https://crrev.com/d94c7b072f3b496815122c3c310456320d592c3c/third_party/WebKit/LayoutTests/virtual/mojo-localstorage/external/wpt/webstorage/README.txt

Comment 13 by qyears...@chromium.org, Jan 18 2017

Labels: -TE-NeedsTriageHelp
Status: Fixed (was: Assigned)
LayoutTests/imported has now been renamed to "LayoutTests/external".
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028ee351f7f79f2a27c8aef5f463d7dec9a0f3e8

commit 028ee351f7f79f2a27c8aef5f463d7dec9a0f3e8
Author: tkent <tkent@chromium.org>
Date: Mon Jan 23 00:39:24 2017

Fix LayoutTests/imported leftovers.

This CL doesn't affect any user-visible behavior.

BUG= 678788 
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2648983002
Cr-Commit-Position: refs/heads/master@{#445307}

[modify] https://crrev.com/028ee351f7f79f2a27c8aef5f463d7dec9a0f3e8/WATCHLISTS
[modify] https://crrev.com/028ee351f7f79f2a27c8aef5f463d7dec9a0f3e8/third_party/WebKit/LayoutTests/W3CImportExpectations
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339204d0315c14f785a3c135c3189bfdbd73447b

commit 339204d0315c14f785a3c135c3189bfdbd73447b
Author: foolip <foolip@chromium.org>
Date: Fri Jan 27 21:10:17 2017

Update a few references to imported/wpt (now external/wpt)

In pointerevent_touch-action-verification.html the included script isn't
needed to pass the test, so just drop it.

BUG= 678788 
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2658093004
Cr-Commit-Position: refs/heads/master@{#446767}

[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/docs/testing/writing_layout_tests.md
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/editing/assert_selection.js
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-verification.html
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/fast/forms/checkValidity.html
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/fast/forms/setrangetext.html
[modify] https://crrev.com/339204d0315c14f785a3c135c3189bfdbd73447b/third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0828d6983df4be0c9205e65f70574d7f2f9b3e8

commit c0828d6983df4be0c9205e65f70574d7f2f9b3e8
Author: foolip <foolip@chromium.org>
Date: Fri Feb 24 17:26:02 2017

Replace remaining references to imported/wpt with external/wpt

The changes in testharnessreport.js are needed when testing locally
using the file protocol. When running wptserve, the code behind
`location.hostname == 'web-platform.test'` checks are what makes it
work.

BUG= 678788 
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2714863003
Cr-Commit-Position: refs/heads/master@{#452856}

[modify] https://crrev.com/c0828d6983df4be0c9205e65f70574d7f2f9b3e8/third_party/WebKit/LayoutTests/resources/testharnessreport.js
[modify] https://crrev.com/c0828d6983df4be0c9205e65f70574d7f2f9b3e8/third_party/WebKit/Source/core/dom/ContainerNode.cpp

Comment 17 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 18 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment