The PhysicalWeb frequently stores the ApplicationContext as a field, when we can grab this with ContextUtils. It'd be nice to clean this up in the various places where this exists.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cad9e8497986d345637e875bcc05952bc34840de commit cad9e8497986d345637e875bcc05952bc34840de Author: cco3 <cco3@chromium.org> Date: Fri Jan 06 01:14:33 2017 Remove mContext field from UrlManager This has been the the application context for some time now, so there is no point in storing it when we can use ContextUtils as needed. BUG=678787 Review-Url: https://codereview.chromium.org/2604953002 Cr-Commit-Position: refs/heads/master@{#441778} [modify] https://crrev.com/cad9e8497986d345637e875bcc05952bc34840de/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/cad9e8497986d345637e875bcc05952bc34840de/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9909a9f963c17a4ae2342303fe5971e54e38ef46 commit 9909a9f963c17a4ae2342303fe5971e54e38ef46 Author: cco3 <cco3@chromium.org> Date: Fri Jan 06 19:27:59 2017 Remove context param from PhysicalWebUma methods This parameter has done nothing for a while. It became obsolete when we started using ContextUtils.getAppSharedPreferences(). BUG=678787 Review-Url: https://codereview.chromium.org/2600283002 Cr-Commit-Position: refs/heads/master@{#442006} [modify] https://crrev.com/9909a9f963c17a4ae2342303fe5971e54e38ef46/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java [modify] https://crrev.com/9909a9f963c17a4ae2342303fe5971e54e38ef46/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java [modify] https://crrev.com/9909a9f963c17a4ae2342303fe5971e54e38ef46/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java [modify] https://crrev.com/9909a9f963c17a4ae2342303fe5971e54e38ef46/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/9909a9f963c17a4ae2342303fe5971e54e38ef46/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
Marking issues assigned to cco3@ as untriaged as they are no longer working on Chromium.
Comment 1 by bugdroid1@chromium.org
, Jan 6 2017