New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678786 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings > Internet - Support global policy settings

Project Member Reported by steve...@chromium.org, Jan 5 2017

Issue description

We need to provide the following global policy properties in chrome.onc (aka chrome.networkingPrivate) for settings UIs:

AllowOnlyPolicyNetworksToAutoconnect
AllowOnlyPolicyNetworksToConnect

We also need to implement these in MD Settings.

 
Cc: f...@chromium.org emaxx@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a48016a1de004b6fd1d4d98c11e8e03e975056d

commit 8a48016a1de004b6fd1d4d98c11e8e03e975056d
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Jan 09 23:26:03 2017

Add getGlobalPolicy to networkingPrivate API.

This also updates the chrome://network test page (network_ui) to
show the global policy properties.

BUG= 678786 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620463003
Cr-Commit-Position: refs/heads/master@{#442398}

[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/browser/resources/chromeos/network_ui/network_ui.html
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/chrome/test/data/extensions/api_test/networking_private/test.js
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_api.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_chromeos.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_delegate.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_linux.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_service_client.cc
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/api/networking_private/networking_private_service_client.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/extensions/common/api/networking_private.idl
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/third_party/closure_compiler/externs/networking_private.js
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/third_party/closure_compiler/interfaces/networking_private_interface.js
[modify] https://crrev.com/8a48016a1de004b6fd1d4d98c11e8e03e975056d/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/521361a1764918dd909969b446881f99c4a8a942

commit 521361a1764918dd909969b446881f99c4a8a942
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Jan 17 23:31:30 2017

MD Settings: Internet: UI For global policy

This includes UI for the following policies:
AllowOnlyPolicyNetworksToConnect
AllowOnlyPolicyNetworksToAutoconnect

BUG= 678786 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624573002
Cr-Commit-Position: refs/heads/master@{#444184}

[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/app/settings_strings.grdp
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/internet_shared_css.html
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/521361a1764918dd909969b446881f99c4a8a942/ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.js

Status: Fixed (was: Started)
Labels: -M-58 M-57
Status: Verified (was: Fixed)

Sign in to add a comment