New issue
Advanced search Search tips

Issue 678785 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

events_unittests does not build for ARM + CrOS

Reported by amaury.l...@arm.com, Jan 5 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:
1. ninja -C /var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/ events_unittests

What is the expected behavior?
/var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/events_unittests should be present

What went wrong?
$ ninja -C /var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/ events_unittests 
ninja: Entering directory `/var/cache/chromeos-chrome/chrome-src/src/out_veyron_jerry/Release/'
[1/2] CXX obj/ui/events/events_unittests/xkb_keyboard_layout_engine_unittest.o
FAILED: armv7a-cros-linux-gnueabi-g++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51-gold -MMD -MF obj/ui/events/events_unittests/xkb_keyboard_layout_engine_unittest.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DUSE_EGL -DSK_IGNORE_DW_GRAY_FIX -DSK_LEGACY_FONTMGR_FACTORY -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUNIT_TEST -DUSE_EVDEV -DUSE_EVDEV_GESTURES -I../../../../../../../home/${USER}/chrome_root/src -Igen -I../../../../../../../home/${USER}/chrome_root/src/testing/gtest/include -I../../../../../../../home/${USER}/chrome_root/src/third_party/khronos -I../../../../../../../home/${USER}/chrome_root/src/gpu -I../../../../../../../home/${USER}/chrome_root/src/skia/config -I../../../../../../../home/${USER}/chrome_root/src/skia/ext -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/${USER}/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/${USER}/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/${USER}/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/${USER}/chrome_root/src/third_party/ced/src -I../../../../../../../home/${USER}/chrome_root/src/testing/gmock_custom -I../../../../../../../home/${USER}/chrome_root/src/testing/gmock/include -I../../../../../../../home/${USER}/chrome_root/src/third_party/WebKit -Igen/third_party/WebKit -I../../../../../../../home/${USER}/chrome_root/src/v8/include -Igen/v8/include -fno-strict-aliasing -funwind-tables -fPIC -pipe -march=armv7-a -mfloat-abi=hard -mtune=generic-armv7-a -pthread -mfpu=neon -mthumb -Wall -Werror -Wno-psabi -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -gsplit-dwarf --sysroot=../../../../../../../build/veyron_jerry -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -femit-struct-debug-reduced -c ../../../../../../../home/${USER}/chrome_root/src/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc -o obj/ui/events/events_unittests/xkb_keyboard_layout_engine_unittest.o
../../../../../../../home/${USER}/chrome_root/src/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc: In member function ‘virtual void ui::XkbLayoutEngineVkTest_KeyboardCodeForNonPrintable_Test::TestBody()’:
../../../../../../../home/${USER}/chrome_root/src/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc:826:49: error: ‘VKEY_BACKSPACE’ was not declared in this scope
     {{DomCode::US_W, EF_ALTGR_DOWN, XKB_KEY_BackSpace, 8}, VKEY_BACKSPACE},
                                                 ^
../../../../../../../home/${USER}/chrome_root/src/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc:827:50: error: ‘VKEY_ENTER’ was not declared in this scope
     {{DomCode::US_V, EF_ALTGR_DOWN, XKB_KEY_Return, 13}, VKEY_ENTER},
                                                  ^
ninja: build stopped: subcommand failed.

Did this work before? Yes before cl here: https://codereview.chromium.org/2481413006

Chrome version: 54.0.2840.59  Channel: dev
OS Version: 
Flash Version: Shockwave Flash 23.0 r0

Issue introduced by a tentative patch to fix  bug 633238 .
VKEY_ENTER and VKEY_BACKSPACE are not defined anywhere in the CrOS + ARM combination
 
Status: Started (was: Unconfirmed)

Sign in to add a comment