Issue 678783 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	braveyao@chromium.org
Closed:	Feb 2017
Cc:	guidou@chromium.org niklase@chromium.org
Components:	Blink>GetUserMedia>Tab
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	3
Type:	Bug

Add test to prevent bug 659183 from regressing

Project Member Reported by braveyao@chromium.org, Jan 5 2017

Issue description

As to cursor rendering for tab capture, we have a unittest for Aura implementation, https://cs.chromium.org/chromium/src/content/browser/media/capture/cursor_renderer_aura_unittest.cc?sq=package:chromium, but no one for OSX.

On OSX, [NSCursor push] and -pop should be able to simulate cursor movement as same as MoveMouseCursorWithinWindow() for Aura. So it's possible to add a similar unittest for OSX.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b08639b651c7514b61d6b905f61719b40d4b3c6

commit 1b08639b651c7514b61d6b905f61719b40d4b3c6
Author: braveyao <braveyao@chromium.org>
Date: Fri Feb 10 00:09:24 2017

Add unittests for CursorRendererMac to prevent crbug/659183 from regressing
on OSX.

BUG= 678783 

Review-Url: https://codereview.chromium.org/2682743006
Cr-Commit-Position: refs/heads/master@{#449481}

[modify] https://crrev.com/1b08639b651c7514b61d6b905f61719b40d4b3c6/content/browser/media/capture/cursor_renderer.h
[modify] https://crrev.com/1b08639b651c7514b61d6b905f61719b40d4b3c6/content/browser/media/capture/cursor_renderer_mac.h
[add] https://crrev.com/1b08639b651c7514b61d6b905f61719b40d4b3c6/content/browser/media/capture/cursor_renderer_mac_unittest.mm
[modify] https://crrev.com/1b08639b651c7514b61d6b905f61719b40d4b3c6/content/test/BUILD.gn

Comment 2 by braveyao@chromium.org, Feb 10 2017

Status: Fixed (was: Assigned)

►

Issue 678783 link

Issue metadata

Add test to prevent bug 659183 from regressing

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

Comment 1 Deleted

Comment 2 by braveyao@chromium.org, Feb 10 2017

Comment 2 Deleted

Sign in to add a comment