Issue metadata
Sign in to add a comment
|
crosh: battery_firmware no longer valid
Reported by
denny.lo...@gmail.com,
Jan 5 2017
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9000.29.3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.28 Safari/537.36
Platform: Firmware Google_Lulu.6301.136.57
Steps to reproduce the problem:
1. open a crosh session: (ctrl+alt+t)
2. enter: battery_firmware info|check|update
What is the expected behavior?
display battery firmware info|check|update information & details.
What went wrong?
When I attempt to run battery_firmware with any option it fails, see below -
crosh> battery_firmware info
Target program '/usr/sbin/ectool' is not accessible.
crosh>
crosh> battery_firmware check
Target program '/usr/sbin/ec_sb_firmware_update' is not accessible.
crosh>
crosh> battery_firmware update
================================================================================
Battery firmware update is in progress.
================================================================================
Please DO NOT remove the power adapter cable, otherwise the update will fail.
To recover from a failed battery firmware update,
please plug in the power adapter cable, reboot and run this command again.
================================================================================
Target program '/usr/sbin/ec_sb_firmware_update' is not accessible.
Did this work before? Yes Sorry, I'm not usre but I think this link will help: https://chromium-review.googlesource.com/#/c/390880/
Chrome version: 56.0.2924.28 Channel: beta
OS Version: 9000.29.3 (Official Build) beta-channel lulu
Flash Version: Shockwave Flash 24.0 r0
With the removal of the 'ectool' package perhaps it's time to remove/retire 'battery_firmware' from the crosh script to avoid any confusion when errors are displayed.
I confess I don't know how these things are handled internally so maybe it's already part of the plan and it will drift away in time..
,
Jan 6 2017
This is used on some systems I am afraid, and disabling it would require some negotiation with partners whom asked for it in the first place. The systems that do it still have ectool so I think this would still work on those, failing on systems that do not leverage the battery firmware update mechanism is WAI now. I guess the bug would then become to change the messaging given by these battery commands to say they are not supported on systems that don't have EC tool (Lulu being one).
,
Jan 6 2017
so we stopped trying to get the boot up scripts to automate the update and just have the partners run it manually via the crosh script ? if that's what we settled on, that's fine. i figured deleting code was easier than anything else :). we can update debugd to check the existence of both tools and issue a different message like "Support unavailable".
,
Jan 6 2017
i've posted a CL so now it looks like: crosh> battery_firmware info Sorry, but this command is unavailable on this device. crosh>
,
Jan 6 2017
I thought that we have both the automated update and manual, IIRC they wanted crosh for their support staff and/or RMA. The CL looks good.
,
Jan 8 2017
Just noticed that crbug.com/678717 , also created on 2017-1-5, seems to be the same issue. I did search prior to posting but didn't find anything, sorry.
,
Jan 9 2017
Issue 678717 has been merged into this issue.
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e4d60cdb27d0604cb191d920b7e83df0a00f7c25 commit e4d60cdb27d0604cb191d920b7e83df0a00f7c25 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jan 06 18:17:19 2017 debugd: battery_tool: issue a clear error message BUG= chromium:678779 TEST=ran crosh on a device w/out ectool and saw the new error message Change-Id: Ib19821b295fd590250eeb6e984132454c8563209 Reviewed-on: https://chromium-review.googlesource.com/425898 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/e4d60cdb27d0604cb191d920b7e83df0a00f7c25/debugd/src/battery_tool.cc
,
Jan 13 2017
,
Jan 13 2017
That was quick, thanx very much. We had sometimes recommended to users in Chromebook Central that they use 'battery_firmware' if we suspected problems with their batteries. We've tried to steer clear of this since the removal of the ectools package but occasionally some will find the commands on their own. The new message "Sorry, but this command is unavailable on this device." will let them know in no uncertain terms that it's not functional. Thanx again, Denny
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Jun 21 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, Jan 6 2017Components: OS>Systems
Owner: bhthompson@chromium.org