New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678756 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 675339



Sign in to add a comment

Reroute Android mouse events to touch event path in M56...

Project Member Reported by mustaq@chromium.org, Jan 5 2017

Issue description

This is a backup plan for our text selection fix ( crbug.com/666060 ): if the fix there seems non-trivial or too complicated to merge to M56, we will reroute mouse events to the touch event path (as was the case in M55).

This bug would need a one-line change.
 
Blocking: 675339
[Bulk edit]

Greetings from the release team!  This issue is marked as a stable release blocker for M56 on Android.  We're planning to ship our final beta release on Jan 25, so you have less than *two weeks* to fix this issue on trunk and merge the change back to the M56 branch.  Please prioritize working on this ASAP!

Sure this bug shouldn't block the release?  Remove the ReleaseBlock-Stable tag.

Don't think this bug should block the release, but not 100% sure?  CC me to the bug and let me know!

Cheers,
Alex

Comment 3 by mustaq@chromium.org, Jan 17 2017

We will go with the partial revert here to be on the safe side for release builds.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bdf02e2b5552def943a60cf8e078918369df6fe

commit 8bdf02e2b5552def943a60cf8e078918369df6fe
Author: mustaq <mustaq@chromium.org>
Date: Tue Jan 17 19:52:36 2017

Reroute Android mouse events to touch event path.

This is a partial revert of crrev.com/2054193002 that aimed to
make Android mouse events more logical & consistent. However,
that change made few UI activities impossible through mouse,
like text selection, zoom & scrolling. Until we fix those
for mouse, we are re-diverting mouse events to the touch-event
path through this CL.

BUG= 678756 

Review-Url: https://codereview.chromium.org/2637143002
Cr-Commit-Position: refs/heads/master@{#444116}

[modify] https://crrev.com/8bdf02e2b5552def943a60cf8e078918369df6fe/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Comment 5 by mustaq@chromium.org, Jan 17 2017

Labels: Merge-Request-56
Status: Fixed (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 17 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL to branch 2924 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ddb6126ff2f49a01fec01f80db0d70f5d9213e

commit 77ddb6126ff2f49a01fec01f80db0d70f5d9213e
Author: Mustaq Ahmed <mustaq@google.com>
Date: Tue Jan 17 21:16:39 2017

Reroute Android mouse events to touch event path.

This is a partial revert of crrev.com/2054193002 that aimed to
make Android mouse events more logical & consistent. However,
that change made few UI activities impossible through mouse,
like text selection, zoom & scrolling. Until we fix those
for mouse, we are re-diverting mouse events to the touch-event
path through this CL.

BUG= 678756 

Review-Url: https://codereview.chromium.org/2637143002
Cr-Commit-Position: refs/heads/master@{#444116}
(cherry picked from commit 8bdf02e2b5552def943a60cf8e078918369df6fe)

Review-Url: https://codereview.chromium.org/2637183003 .
Cr-Commit-Position: refs/branch-heads/2924@{#784}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/77ddb6126ff2f49a01fec01f80db0d70f5d9213e/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Sign in to add a comment