New issue
Advanced search Search tips

Issue 678745 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

The disable-background-timer-throttling switch is broken

Reported by magyan...@gmail.com, Jan 5 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. Start Chrome normally, open a new tab, then run the following code in the console:
function step() { var t = new Date().getTime(); console.log(t-window.last); window.last=t; setTimeout(step,100); }
2. Start the loop with: step()
3. Observe that console logs rougly 100ms delays, and when switching to another tab and checking the output later, the corresponding delays were roughy 1s because of background throttling.
4. Start Chrome with the --disable-background-timer-throttling flag, and repeat the above.

What is the expected behavior?
The console should log 100ms delays regardless of the tab being active or inactive.

What went wrong?
The tab is still throttled to 1s, ignoring the switch.

Did this work before? Yes not sure, but somewhere around 50-54 it definitely worked

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 24.0 r0
 

Comment 1 by ajha@chromium.org, Jan 6 2017

Labels: Needs-Bisect Needs-Triage-M55
Labels: -Needs-Bisect -Needs-Triage-M55 hasbisect-per-revision M-57 OS-Linux OS-Mac
Owner: skyos...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Win 10,Mac 10.12.2 and Ubuntu 14.04 using 55.0.2883.87/95 and canary 57.0.2972.0.

Bisect info:
=============
Good: 54.0.2825.0—410914
Bad : 54.0.2826.0—411209

You are probably looking for a change made after 411073 (known good), but no later than 411074 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/6182935761115cffcfe261707544bf10acdfe3f5..529caa299dee30c413f64ebdd699e5361821f49d

skyostil@: Could you please take a look into this if its related to your change.
Components: -Blink Blink>Scheduling
Status: Started (was: Assigned)
Sorry about that. Fix here: https://codereview.chromium.org/2624153002/
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa98128b366b40cf31bd6d4395821e19a7fe642

commit 3fa98128b366b40cf31bd6d4395821e19a7fe642
Author: skyostil <skyostil@chromium.org>
Date: Wed Jan 11 18:46:22 2017

Propagate the --disable-background-timer-throttling flag to the renderer

This flag needs to be passed to the renderer to actually disable
background throttling.

BUG= 678745 

Review-Url: https://codereview.chromium.org/2624153002
Cr-Commit-Position: refs/heads/master@{#442964}

[modify] https://crrev.com/3fa98128b366b40cf31bd6d4395821e19a7fe642/content/browser/renderer_host/render_process_host_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment