UMA reporting not working for Crashpad on macOS |
|||
Issue descriptionhttps://crashpad.chromium.org/bug/100 added some UMA support to Crashpad, but it’s only working on Windows. We noticed that it wasn’t working on macOS but we weren’t sure why not. While looking at https://crashpad.chromium.org/bug/143, I noticed that we’re not starting crashpad_handler with --metrics-dir on macOS. In Chrome, this is where we get the metrics path to give to Crashpad when we start it: https://chromium.googlesource.com/chromium/src/+/7b9234c4b2a7f4f4fa84c80ecb22d41c54899f6a/components/crash/content/app/crashpad_mac.mm#50 The base implementation of crash_reporter::CrashReporterClient::GetCrashMetricsLocation() is a no-op: https://chromium.googlesource.com/chromium/src/+/785ed6054d704b40cf4be1da82a88c979efe03bb/components/crash/content/app/crash_reporter_client.cc#113. On Windows, Chrome overrides this with a real implementation: https://chromium.googlesource.com/chromium/src/+/24c2c8cda1e14b7523b6fb841bec1e810633a26e/chrome/app/chrome_crash_reporter_client_win.cc#384. There is no such override on macOS (https://chromium.googlesource.com/chromium/src/+/39d6ba4eece90cc70bff87f2ecc39e5a790e1233/chrome/app/chrome_crash_reporter_client_mac.mm), so there, we never wind up giving crashpad_handler a metrics path, and it faithfully doesn’t write metrics data anywhere.
,
Jan 9 2017
It does, and I’m not totally sure that it’s working correctly. If you have a moment to help out, can you take a look at the discussion on https://codereview.chromium.org/2610883006/?
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487 commit c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487 Author: mark <mark@chromium.org> Date: Wed Jan 11 13:21:46 2017 Enable UMA reporting for crashpad_handler on macOS This should have been working already, but a functioning crash_reporter::CrashReporterClient::GetCrashMetricsLocation() for macOS was unintentionally absent. BUG=crashpad:100, chromium:678720 Review-Url: https://codereview.chromium.org/2610883006 Cr-Commit-Position: refs/heads/master@{#442888} [modify] https://crrev.com/c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487/chrome/app/chrome_crash_reporter_client.h [modify] https://crrev.com/c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487/chrome/app/chrome_crash_reporter_client_mac.mm [modify] https://crrev.com/c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487/chrome/app/chrome_crash_reporter_client_win.h [modify] https://crrev.com/c8e4f85cf19acdf6e1e61aa3ed0cde6a06a84487/chrome/browser/metrics/chrome_metrics_service_client.cc
,
Jan 19 2017
It looks like this is working properly for both Mac and Windows in current canaries. |
|||
►
Sign in to add a comment |
|||
Comment 1 by manzagop@chromium.org
, Jan 9 2017