See https://docs.google.com/spreadsheets/d/1uMNmd8Azwy_thsJO4xYJDx7hvOUMX0QLPghxQueKBS8/edit#gid=0&vpid=A1 for overview of method counts.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f91eac1eb56feff498ccee8e88ab96a0a66b024

commit 1f91eac1eb56feff498ccee8e88ab96a0a66b024
Author: jamescook <jamescook@chromium.org>
Date: Tue May 30 17:27:32 2017

chromeos: Tighten DEPS on //ash in //chrome/browser to support mash

Under mash the code in //ash runs out of process. Code in //chrome/browser
must use the mojo interfaces in //ash/public/interfaces to talk to ash.

We're still in the process of refactoring existing code, but new code
should use the mojo approach. Tighten DEPS on //ash to limit the number
of new references.

Also file bugs to refactor the existing areas.

BUG=678705
TEST=buildtools/checkdeps/checkdeps.py

Review-Url: https://codereview.chromium.org/2891923003
Cr-Commit-Position: refs/heads/master@{#475577}

[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/chromeos/DEPS
[add] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/cryptauth/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/extensions/DEPS
[add] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/lifetime/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/media/webrtc/DEPS
[add] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/memory/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/notifications/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/policy/DEPS
[add] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/renderer_context_menu/DEPS
[add] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/signin/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/sync/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/ui/DEPS
[modify] https://crrev.com/1f91eac1eb56feff498ccee8e88ab96a0a66b024/chrome/browser/usb/DEPS

To me just to make it easier to find.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5163dd7b1c9832e636f4730ea533316eee666dac

commit 5163dd7b1c9832e636f4730ea533316eee666dac
Author: James Cook <jamescook@chromium.org>
Date: Tue Sep 12 21:16:17 2017

cros: Elimate usage of ash/wm/window_util.h in chrome/browser/ui/ash

For go/mustash chrome browser code cannot call directly into ash.
ash/wm/window_util.h is one of the most common ash headers used in chrome,
so eliminate some usage.

Replace ash::wm::Foo() calls with their core wm::Foo() equivalents where
the windows are clearly browser windows or browser-owned windows (like
platform apps).

Convert GetActiveWindow() usage to IsActiveWindow() where the activation
client is not known.

Fix DEPS to ban this header.

Bug: 678705,  756085 
Test: browser_tests, unit_tests, manually switch multiprofile users with multiple browser windows open

Change-Id: Ifde5f1119b4818a7bde58dcdd3eafaef187ace71
Reviewed-on: https://chromium-review.googlesource.com/661793
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501398}
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/ash/wm/window_util.h
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1

commit 5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1
Author: James Cook <jamescook@chromium.org>
Date: Wed Sep 13 23:14:01 2017

cros: Remove some ash::wm::WindowState access in chrome/browser

For go/mustash code in the browser can't use code in ash.

Also convert some ui/core/wm IsActiveWindow usage to call BaseWindow
instead. While the two are identical for browser windows, they are not
quite identical for platform app or ARC windows, so I think we should
get into the habit of manipulating things at a higher level than the
aura::Window/NativeWindow.

Bug: 678705
Test: unit_tests, browser_tests
Change-Id: Ifc0167292fb42e16749170b5e2a5b2bb93867aae
Reviewed-on: https://chromium-review.googlesource.com/664920
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501790}
[modify] https://crrev.com/5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1/chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc
[modify] https://crrev.com/5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/5564827d8bcbfe3ab37ab55158c549c9c0d1e8b1/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c0cac303aac754db429a1d9e9dc9b63cf2a419

commit e1c0cac303aac754db429a1d9e9dc9b63cf2a419
Author: James Cook <jamescook@chromium.org>
Date: Fri Sep 15 20:45:31 2017

cros: Eliminate ash window_util.h usage in chrome browser TabScrubber

For go/mustash code in chrome/browser can't call into ash.

Cleanup the test and remove the unused --open-ash switch.

Bug: 678705
Test: interactive_ui_tests, manually do 3-finger swipes on device to switch tabs
Change-Id: Ieab85811a69cee4e5d0cc5c17fef0780f7a595b9
Reviewed-on: https://chromium-review.googlesource.com/668801
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502357}
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/browser/ui/views/ash/tab_scrubber.cc
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/browser/ui/views/ash/tab_scrubber.h
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/common/chrome_switches.cc
[modify] https://crrev.com/e1c0cac303aac754db429a1d9e9dc9b63cf2a419/chrome/common/chrome_switches.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934abaf581d475fdec8bde43616b5c5c8f046b87

commit 934abaf581d475fdec8bde43616b5c5c8f046b87
Author: James Cook <jamescook@chromium.org>
Date: Tue Sep 19 22:21:58 2017

cros: Tighten //ash DEPS restrictions in //chrome/browser/ui

For go/mustash code in chrome/brower cannot call directly into ash.

Push the +ash DEPS allowance down into subdirectories that haven't
been converted yet.

Tag a few includes used only in classic ash as "mash-ok".

Remove some unused includes. Convert some USE_ASH to OS_CHROMES to
allow some nogncheck tags to be removed.

Bug:  651557 , 678705
Test: tools/checkdeps.py, gn check, compiles
Change-Id: I1d324c3df319a8099029b926f35b7571ea4d7077
Reviewed-on: https://chromium-review.googlesource.com/673163
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502970}
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/ash/README.md
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/ash/shell.h
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/app_list/arc/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/apps/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/ash/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/aura/accessibility/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser_commands_chromeos.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/extensions/extension_install_ui_default.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/startup/startup_browser_creator.cc
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/test/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/views/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/webui/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/window_sizer/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59e3a98e1820b986a608b24a62c381edc317b911

commit 59e3a98e1820b986a608b24a62c381edc317b911
Author: James Cook <jamescook@chromium.org>
Date: Tue Oct 31 19:21:04 2017

cros: Restrict DEPS on ash in //chrome/browser/extensions

For go/mustash we're putting code in //ash into a separate process, so
code in //chrome/browser cannot call directly into it. Restrict DEPS in
//c/b/extensions to make that clearer.

Bug: 678705
Test: checkdeps
Change-Id: I22c707564930c3dce70f5c2576c3dfacc44c1d22
Reviewed-on: https://chromium-review.googlesource.com/747062
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512904}
[modify] https://crrev.com/59e3a98e1820b986a608b24a62c381edc317b911/chrome/browser/extensions/DEPS
[add] https://crrev.com/59e3a98e1820b986a608b24a62c381edc317b911/chrome/browser/extensions/api/automation/DEPS
[modify] https://crrev.com/59e3a98e1820b986a608b24a62c381edc317b911/chrome/browser/extensions/api/virtual_keyboard_private/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26

commit e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26
Author: James Cook <jamescook@chromium.org>
Date: Fri Feb 23 20:29:18 2018

Convert chrome/browser DEPS for +ash to !ash

"!ash" is the same as "+ash" but will cause checkdeps.py to emit a
presubmit warning if you add additional deps on that path. Since we're
trying to eliminate deps on //ash, that's desirable.

TBR=atwilson@chromium.org

Bug: 678705
Change-Id: I911479be6d308f2ba21370761ab9d5575827e7df
Reviewed-on: https://chromium-review.googlesource.com/935282
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538878}
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/policy/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/app_list/arc/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/aura/accessibility/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/test/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/views/DEPS
[modify] https://crrev.com/e647bef98ea9b9e0ea34c7d5dc42a90ab1a53a26/chrome/browser/ui/window_sizer/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a

commit 5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 28 14:31:51 2018

Remove ChromeLauncherController::ShelfBoundsChangesProbablyWithUser

This function is unused. It probably became unused when estade cleaned
up multiprofile user switching animations a few months back.

This eliminates an include of ash/shelf/shelf.h from chrome.

Bug: 678705, 548405, 548175
Test: compiles
Change-Id: If94baf780a5ae8943aadbe952bfc9aaa42720987
Reviewed-on: https://chromium-review.googlesource.com/982430
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546480}
[modify] https://crrev.com/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a/ash/public/cpp/shelf_prefs.cc
[modify] https://crrev.com/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a/ash/public/cpp/shelf_prefs.h
[modify] https://crrev.com/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/5bd2969b2eb60b096b3ab2f7d423c9d1ac8bac8a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f008dd36bf515dce922a391acdc2b39f4c6f42ce

commit f008dd36bf515dce922a391acdc2b39f4c6f42ce
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 28 21:17:03 2018

cros: Remove unused ash includes from //chrome/browser

Found during audit for go/mustash

Bug: 678705
Test: compiles
Change-Id: Ia530615fada460522b9c24b940a8107271ba2cb3
Reviewed-on: https://chromium-review.googlesource.com/984715
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546600}
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/dbus/chrome_console_service_provider_delegate.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/lock_screen_apps/toast_dialog_view.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/extensions/DEPS
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/extensions/launch_util.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/f008dd36bf515dce922a391acdc2b39f4c6f42ce/chrome/browser/ui/toolbar/app_menu_model.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b1f3bf02e9ad9527221f626f0331b8e9f3db147

commit 3b1f3bf02e9ad9527221f626f0331b8e9f3db147
Author: James Cook <jamescook@chromium.org>
Date: Mon Apr 30 20:39:23 2018

cros: Eliminate access to ash::kShelfSize in chrome

It's an internal ash detail. Use extension_misc::EXTENSION_ICON_MEDIUM
in the 2 places in Chrome Apps code that need an appropriate size.

Bug: 678705
Test: browser_tests
Change-Id: I780377a91f1f7da633f784e4fc35bc0b77a9f7de
Reviewed-on: https://chromium-review.googlesource.com/1035443
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554862}
[delete] https://crrev.com/07e3ac1594ef797a5a0d49f53bacc11311466e07/chrome/browser/ui/apps/DEPS
[modify] https://crrev.com/3b1f3bf02e9ad9527221f626f0331b8e9f3db147/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/3b1f3bf02e9ad9527221f626f0331b8e9f3db147/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/3b1f3bf02e9ad9527221f626f0331b8e9f3db147/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc