Body of EXPECT_FLOAT_RECT_EQ in cc/test/geometry_test_utils.h shouldn't be subject to the rename. |
||
Issue descriptioncc/test/geometry_test_utils.h defines EXPECT_FLOAT_RECT_EQ which invokes |x()| accessor - this works fine for rect-like types defined in gfx and/or cc namespaces (e.g. gfx::RectF). Unfortunately, the macro is also used from third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp which means that the body of the macro will be subject to renames (to reflect the renames happening to blink::FloatRect::x() accessor).
,
Jan 5 2017
sgtm that macro is for gfx stuff.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79c766c81131835cc15ca44234a12b7faab715b6 commit 79c766c81131835cc15ca44234a12b7faab715b6 Author: lukasza <lukasza@chromium.org> Date: Thu Jan 05 20:57:40 2017 Don't use EXPECT_FLOAT_RECT_EQ from geometry_test_utils.h for non-gfx types. This change is needed to help the rename_to_chrome_style clang tool with the Great Blink Rename. Without this change, the tool would rename blink::FloatRect::x accessor to X and consequently would rename all references to this name (which before this CL would also include the body of the EXPECT_FLOAT_RECT_EQ macro defined in cc/test/geometry_test_utils.h). BUG= 678704 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2617563003 Cr-Commit-Position: refs/heads/master@{#441746} [modify] https://crrev.com/79c766c81131835cc15ca44234a12b7faab715b6/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
,
Jan 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Jan 5 2017