New issue
Advanced search Search tips

Issue 678701 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert AudioContext tests to testharness

Project Member Reported by rtoy@chromium.org, Jan 5 2017

Issue description

Convert AudioContext tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b257ac3cf4858f2fb77fab58737dcf6bc3d3ca5a

commit b257ac3cf4858f2fb77fab58737dcf6bc3d3ca5a
Author: rtoy <rtoy@chromium.org>
Date: Mon Jan 23 19:43:36 2017

Convert audiocontext-listener test to testharness

Manually convert test to use testharness and new Audit.  Removed the
expected result file too.

BUG= 678701 
TEST=audiocontext-listener-should-not-crash.html

Review-Url: https://codereview.chromium.org/2639683002
Cr-Commit-Position: refs/heads/master@{#445437}

[delete] https://crrev.com/6b91ed876fd20ba96e4c1c008d056a0ed98788b6/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash-expected.txt
[modify] https://crrev.com/b257ac3cf4858f2fb77fab58737dcf6bc3d3ca5a/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-listener-should-not-crash.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aee9f268a3a471fa539d704e622aee1ce68f0ce

commit 3aee9f268a3a471fa539d704e622aee1ce68f0ce
Author: rtoy <rtoy@chromium.org>
Date: Mon Jan 23 23:00:50 2017

Convert AudioContext Audit tests to testharness

Conversion done using this script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Since the original tests didn't actually use any of the old
Audit.Should() functions, we took this opportunity to convert it to
the new Audit.should() because we had to convert the old js-test
functions anyway.

BUG= 678701 
TEST=AudioContext/audiocontext-close.html,
AudioContext/audiocontext-suspend-resume.html

Review-Url: https://codereview.chromium.org/2611133003
Cr-Commit-Position: refs/heads/master@{#445529}

[delete] https://crrev.com/5d8596504544ee64049242d88b15fc3a79295519/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close-expected.txt
[modify] https://crrev.com/3aee9f268a3a471fa539d704e622aee1ce68f0ce/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
[delete] https://crrev.com/5d8596504544ee64049242d88b15fc3a79295519/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume-expected.txt
[modify] https://crrev.com/3aee9f268a3a471fa539d704e622aee1ce68f0ce/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html

Comment 4 by rtoy@chromium.org, Mar 23 2017

Status: Fixed (was: Assigned)
AudioContext/audiocontext-lock-threading-race.html contains a call to gc().  We're not going to convert this file since it's not portable anyway.

Sign in to add a comment