New issue
Advanced search Search tips

Issue 678698 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Previous locations:
gerrit:5225


Sign in to add a comment

Gerrit retries trybots when rietveld would not.

Project Member Reported by dsinclair@chromium.org, Jan 5 2017

Issue description

With trybots, we often don't need them to retry as the first failure is enough. For CQ, we do want them to retry. It seems with the gerrit config our bots are re-trying failure even for try's that aren't CQ'd.
 
Labels: -Restrict-View-Google
Project: chromium
Moved issue gerrit:5225 to now be  issue chromium:678698 .
Cc: tandrii@chromium.org
Components: Infra>Codereview>Gerrit
Labels: Milestone-Dogfood Proj-Gerrit-Migration Pri-2 Type-Bug
Owner: aga...@chromium.org
Status: Assigned (was: New)
I have no idea how or why this would be different -- both Gerrit and Rietveld use the same CQ Dry Run code.

Can you point me to an example of this behavior? Best would be the same CL uploaded to both systems with different trybot behavior; but any pair of random CLs exhibiting this would be okay as well.
See https://pdfium-review.googlesource.com/c/2153/2 for example. It is retrying the try runs for the win bots.
Can you please point me at a pdfium CL on rietveld where some dryrun jobs failed and didn't retry? I'm still not sure that this is a regression.
Oh, I think you're right. I just never noticed on Rietveld because they get hidden behind the more>> link where as it's obvious in Gerrit that these retried.

Feel free to close as user error.
Status: WontFix (was: Assigned)
Ah that makes sense. We can look into being more aggressive with hiding old failed jobs in the Gerrit UI. Thanks!
You can change your cq.cfg to tell it to not retry failures: https://cs.corp.google.com/eureka_internal/chromium/tools/depot_tools/third_party/cq_client/cq.proto?l=189 

specifically, "try_job_retry_quota 0" should do the trick.
In fact, it's great if your tests are so good you don't need to retry. We might want to consider making no retries a default in CQ.

Sign in to add a comment