New issue
Advanced search Search tips

Issue 678685 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Need test coverage of --mash

Project Member Reported by sky@chromium.org, Jan 5 2017

Issue description

Mash browser_tests run in a different environment than chrome --mash does. We need at least one test of this config, or ideally mash browser_tests run in exactly the same was as chrome --mash does.
 
Cc: jamescook@chromium.org

Comment 2 by sky@chromium.org, Mar 1 2017

Owner: jonr...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by sky@chromium.org, Apr 4 2017

Labels: mustash-2
Status: Untriaged (was: Assigned)
Cc: jonr...@chromium.org mustash-bugs@google.com
It would be good to either get direct testing of the current chrome --mash startup code. Either via a new test, or by refactoring how mash_browser_tests starts up.

Comment 6 by sky@chromium.org, Aug 30 2017

I think we'll get this if we move the service_manager into the chrome process as I did for --mus. It's not what we want long term, but at least in the near term (first version of --mash) it's useful and simplifies things.
Status: Fixed (was: Untriaged)
As noted in  issue 678687  the service manager is currently in the browser process. So as of now we have this coverage in the tests.

We may have to revisit this if the service manager is moved back out in the future.

Sign in to add a comment