New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BattOr agent still failing to retry initialization procedure

Project Member Reported by charliea@chromium.org, Jan 5 2017

Issue description

Link to run where this happened: https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_cq/builds/681

STDOUT: https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_cq/builds/681/steps/system_health.common_desktop/logs/stdio

Serial log: attached.

You can see by opening the serial log and searching for "0x00 0x03 0x06 0x02 0x00 0x02 0x00 0x02 0x00 0x02 0x00 0x01" (the start tracing control message) that the message is only sent once. 



 
battor-serial-log-2017-01-05_09-26.txt-98688.txt
1.7 KB View Download
After poking around some, it's clear why this is happening: in this case block (http://bit.ly/2hVzAw8), there's no "return" at the end of it, so it falls through and times out even after it *should* retry. 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e1e654c70726bbf429fb8a3f75e9956c78a037

commit a3e1e654c70726bbf429fb8a3f75e9956c78a037
Author: charliea <charliea@chromium.org>
Date: Thu Jan 05 22:16:50 2017

Fix logic for retrying BattOr initialization after a timeout

Unfortunately, due to the way this code relies on posting a delayed
tasks that gets run at a later time, writing a unit test is very
difficult.

BUG= 678659 

Review-Url: https://codereview.chromium.org/2618693003
Cr-Commit-Position: refs/heads/master@{#441770}

[modify] https://crrev.com/a3e1e654c70726bbf429fb8a3f75e9956c78a037/tools/battor_agent/battor_agent.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27140585843585d65c219884ff31719fbb61dbaf

commit 27140585843585d65c219884ff31719fbb61dbaf
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Jan 06 21:30:22 2017

Roll src/third_party/catapult/ 24315c519..f84aaa04d (4 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/24315c519ee9..f84aaa04d4d0

$ git log 24315c519..f84aaa04d --date=short --no-merges --format='%ad %ae %s'
2017-01-06 rnephew [BattOr] Update Win, Mac and Linux battor agent binaries in deps manager.
2017-01-06 simonhatch Dashboard - Fix some internal bisects not starting automatically.
2017-01-06 eakuefner [StyleGuide] Add specific delineation for JavaScript
2017-01-06 sullivan Do not create data stoppage alerts for ref builds.

BUG= 677303 , 678659 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2617223002
Cr-Commit-Position: refs/heads/master@{#442057}

[modify] https://crrev.com/27140585843585d65c219884ff31719fbb61dbaf/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment