New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678651 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Change Umpire HTTP backend from lighttpd to nginx

Project Member Reported by hungte@chromium.org, Jan 5 2017

Issue description

Re-evaluated how we use Umpire today, I think we should consider moving from lighttpd to nginx, because:
 - Dome also uses nginx. Having only one httpd server simplified factory server.
 - nginx has good proxy ability, which will be helpful for shopfloor proxy service in future.
 - nginx today is more powerful with better performance than the time we started umpire, especially for netboot download.
 - nginx supports fastcgi but not CGI, but our Umpire also only uses fastcgi now.
 - building nginx is more painful in portage, but we're now building under Docker, also nginx ebuild file is now also available.

Taking all these into consideration, I think we should try to replace the lighttpd inside Umpire by nginx.

This is a very low priority item.
 

Comment 1 by pihsun@chromium.org, Apr 25 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/24d8932436f8286916edc3ca94bffc9b35a16c85

commit 24d8932436f8286916edc3ca94bffc9b35a16c85
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Apr 26 11:28:08 2017

target-chromium-os-sdk: Add www-servers/nginx

The http_unittest in Umpire in the factory software needs this.

BUG= chromium:678651 
TEST=emerge -C nginx && update_chroot --skip_toolchain_update
    saw it install nginx

Change-Id: I6e79c6f2fbc93204be243f6eab5f44a8692b8719
Reviewed-on: https://chromium-review.googlesource.com/487801
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[rename] https://crrev.com/24d8932436f8286916edc3ca94bffc9b35a16c85/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r73.ebuild
[modify] https://crrev.com/24d8932436f8286916edc3ca94bffc9b35a16c85/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild

Comment 3 by pihsun@chromium.org, Apr 27 2017

Status: Fixed (was: Started)

Comment 4 by pihsun@chromium.org, Apr 27 2017

Not sure why the commit isn't shown here, the change is in https://chromium-review.googlesource.com/c/486622/.

Comment 5 by hungte@chromium.org, Apr 27 2017

Should we release another docker image for the nginx-based version?

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment