-[ChromeCoordinator dealloc] should not call |stop| |
|||||
Issue descriptionCalling methods inside dealloc is problematic, because subclasses already deallocated and calling a method on deallocated objects (especially in Objective-C++ world) may not end up very well. Style Guide forbids using accessors inside init and dealloc, but instance methods are no different: https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init_and_dealloc
,
Mar 16 2017
,
Mar 16 2017
,
May 30 2017
,
Sep 13 2017
Mark, this will cause problems in the future. Do we want to prevent them? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by olivierrobin@chromium.org
, Jan 6 2017Status: Assigned (was: Untriaged)