New issue
Advanced search Search tips

Issue 678647 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

-[ChromeCoordinator dealloc] should not call |stop|

Project Member Reported by eugene...@chromium.org, Jan 5 2017

Issue description

Calling methods inside dealloc is problematic, because subclasses already deallocated and calling a method on deallocated objects (especially in Objective-C++ world) may not end up very well. Style Guide forbids using accessors inside init and dealloc, but instance methods are no different:
https://google.github.io/styleguide/objcguide.xml#Avoid_Accessors_During_init_and_dealloc
 
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hotlist-Needs-New-Component
Components: UI>Browser
Labels: -Hotlist-Needs-New-Component
Components: -UI>Browser Internals
Cc: -marq@chromium.org eugene...@chromium.org rohitrao@chromium.org
Labels: -Type-Feature Type-Task
Mark, this will cause problems in the future. Do we want to prevent them?

Sign in to add a comment