New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678642 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Cache web contents in credit card scanner

Project Member Reported by rouslan@chromium.org, Jan 5 2017

Issue description

It's much safer to cache the WebContents instead of WindowAndroid to deal with tab reparenting, for example.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b77a92aea7e6ccf635a787a18005d70e50e2dd5

commit 4b77a92aea7e6ccf635a787a18005d70e50e2dd5
Author: rouslan <rouslan@chromium.org>
Date: Fri Jan 06 22:17:55 2017

Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG= 678642 

Review-Url: https://codereview.chromium.org/2614883003
Cr-Commit-Position: refs/heads/master@{#442071}

[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/android/java/src/org/chromium/chrome/browser/autofill/CreditCardScanner.java
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/android/java/src/org/chromium/chrome/browser/autofill/CreditCardScannerBridge.java
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/app/generated_resources.grd
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/browser/about_flags.cc
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
[modify] https://crrev.com/4b77a92aea7e6ccf635a787a18005d70e50e2dd5/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/d171d50516ff7a93e9bdd8d9f2e11035b828f2c6

commit d171d50516ff7a93e9bdd8d9f2e11035b828f2c6
Author: Rouslan Solomakhin <rouslan@google.com>
Date: Fri Jan 06 23:54:41 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/21da32096bb357f88a89fe385553383c26987828

commit 21da32096bb357f88a89fe385553383c26987828
Author: Rouslan Solomakhin <rouslan@google.com>
Date: Tue Jan 10 14:41:48 2017

Status: Fixed (was: Started)

Sign in to add a comment