Remove prompt to re-enable disabled hosted apps when visiting a website |
||
Issue descriptionWe currently prompt the user to re-enable hosted apps that are disabled for permissions increases when they visit a website corresponding to that app. This can become very annoying for users, since it isn't immediately obvious why it's happening, and we don't persist any choice. We could improve the flow a little (e.g. persisting a choice), but really we should just remove it entirely. Any website that absolutely needs a hosted app enabled can detect for itself that it isn't, and inform the user (with more context than chrome can offer).
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b184ca093fba8aabfccdba8391c3676815beed9 commit 4b184ca093fba8aabfccdba8391c3676815beed9 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Jan 13 01:35:44 2017 [Extensions] Remove the prompt to re-enable app when visiting its site We currently prompt the user to re-enable a disabled hosted app if they visit the corresponding site. However, this can be really annoying, and confusing, since we don't offer much context on the choice, and don't persist the preference. This is offering relatively little value, and the site (if it wanted) could detect and inform the user that the app wasn't enabled, and give them sufficiently more context. However, we should keep this when the user visits a chrome-extension url - this is a much stronger signal, and we can't display anything else anyway (whereas visiting a hosted app's site still shows the site). This was never tested, so add some tests. BUG= 678631 Review-Url: https://codereview.chromium.org/2621953003 Cr-Commit-Position: refs/heads/master@{#443439} [modify] https://crrev.com/4b184ca093fba8aabfccdba8391c3676815beed9/chrome/browser/extensions/navigation_observer.cc [modify] https://crrev.com/4b184ca093fba8aabfccdba8391c3676815beed9/chrome/browser/extensions/navigation_observer.h [add] https://crrev.com/4b184ca093fba8aabfccdba8391c3676815beed9/chrome/browser/extensions/navigation_observer_browsertest.cc [modify] https://crrev.com/4b184ca093fba8aabfccdba8391c3676815beed9/chrome/test/BUILD.gn
,
Jan 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rdevlin....@chromium.org
, Jan 10 2017