Chrome.apk is including excess translations from support library |
|||
Issue descriptionThe list of locales we support in Chrome.apk is found here: https://cs.chromium.org/chromium/src/build/config/locales.gni However, running: aapt dump configurations apks/ChromePublic_incremental.apk Reveals configs for many locales not included in our list of supported locales. It turns out that they are being added in from libraries such as support library and GVR (bug 678309). We should use aapt's -c flag to restrict the number of configs to just the locales that we support. This is also relevant to Android Webview's locales bug 650527.
,
Jan 5 2017
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87f1b6b8f0e0493ba7d1540abe795e13b313e141 commit 87f1b6b8f0e0493ba7d1540abe795e13b313e141 Author: agrieve <agrieve@chromium.org> Date: Wed Jan 11 15:14:49 2017 Android: Stop including unsupport locales in resources.arsc They were being pulled in from dependent libraries. We now pass an explicit whitelist to aapt to ensure only support locales are being included. This shaves 470kb off of ChromePublic.apk, 100kb of which was recently added by the gvr library in bug 678309. The list of removed configs (via aapt dump configurations): af az az-rAZ be-rBY bn bn-rBD bs-rBA en-rAU en-rIN es-r419 et et-rEE eu-rES fr-rCA gl gl-rES gu gu-rIN hy-rAM is is-rIS ka ka-rGE kk kk-rKZ km km-rKH kn kn-rIN ky ky-rKG lo lo-rLA mk-rMK ml ml-rIN mn mn-rMN mr mr-rIN ms ms-rMY my my-rMM ne ne-rNP no pa pa-rIN si-rLK sq-rAL ta-rIN te te-rIN tl ur-rPK uz uz-rUZ zh-rHK zu BUG= 678628 ,678309 Review-Url: https://codereview.chromium.org/2615753004 Cr-Commit-Position: refs/heads/master@{#442907} [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/android_webview/system_webview_apk_tmpl.gni [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/base/android/java/src/org/chromium/base/LocaleUtils.java [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/build/android/gyp/package_resources.py [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/build/config/android/internal_rules.gni [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/build/config/android/rules.gni [modify] https://crrev.com/87f1b6b8f0e0493ba7d1540abe795e13b313e141/chrome/android/chrome_public_apk_tmpl.gni
,
Jan 12 2017
Ended up shaving off 500kb :) https://chromeperf.appspot.com/report?sid=cfc29eed1238fd38fb5e6cf83bdba6c619be621b606e03e5dfc2e99db14c418b&rev=442907
,
Jan 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by agrieve@chromium.org
, Jan 5 2017