chameleon: Let audio_AudioAfterSuspend support usage without audio box |
|||||||||||
Issue descriptionHi Kalin, it will be helpful if this test can be run without audio box. We can add test argument and control files to support the case where we assume audio jack is always plugged (for external mic, headphone), or always remains unplugged (for internal mic, internal speaker). Then the test can cover the basic suspend/resume use case. Could your team help improving this test ? Thanks! audio_AudioAfterReboot can be done too, but I think that is has lower priority.
,
Jan 5 2017
Right. Thanks Jimmy for filing this issue. I'll work on this and pass a change today or tomorrow.
,
Jan 5 2017
I think it will be even simpler if no assumed position is passed. If plugger is not present, we do not want to test scenarios where state changes. Therefore only the basic tests will be covered: - all time plugged - headphone, external_mic - do not need quiet environment - all time unplugged - internal_speaker, and internal_mic - need quiet environment To do this we can simply skip the plug or unplug action in action_plug_jack(). Change - https://chromium-review.googlesource.com/425321 With the case of plugged audio jack - I don't get it and tests are passing. I have a problem for the unplugged(internal audio) tests: - I try to test it in audio box with unplugged plugger data cable from audio box, and powered off plugger, so I can replicate if someone needs to test with no plugger. In this case I get chameleond.utils.audio_board._JackPluggerException from chameleon.setup_and_reset(). Why is that?
,
Jan 6 2017
Hi Kalin, thanks for the quick fix! I guess that is because chameleon only detects jack plugger when it starts. So after you unplug plugger cable, you'll need to restart chameleond, or reboot chameleon. Thanks!
,
Jan 6 2017
I see. Thanks Jimmy. Changes only to audio jack simple tests are left in the CL.
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8e2a74f5fae833acb268ed285ce486dd33cc2ba1 commit 8e2a74f5fae833acb268ed285ce486dd33cc2ba1 Author: Kalin Stoyanov <kalin@chromium.org> Date: Thu Jan 05 21:56:05 2017 Remove the audio-box dependency for audio tests BUG= chromium:678627 TEST=Tested for lab boards Change-Id: I9bd4c7c5e423018c8d0ac98907c781a849520559 Reviewed-on: https://chromium-review.googlesource.com/425321 Commit-Ready: Kalin Stoyanov <kalin@chromium.org> Tested-by: Kalin Stoyanov <kalin@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org> [modify] https://crrev.com/8e2a74f5fae833acb268ed285ce486dd33cc2ba1/server/site_tests/audio_AudioAfterSuspend/control.external_mic [modify] https://crrev.com/8e2a74f5fae833acb268ed285ce486dd33cc2ba1/server/site_tests/audio_AudioAfterSuspend/control.headphone [modify] https://crrev.com/8e2a74f5fae833acb268ed285ce486dd33cc2ba1/server/site_tests/audio_AudioAfterSuspend/audio_AudioAfterSuspend.py
,
Jan 13 2017
,
Jan 14 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL to branch 2924 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed927e1c4ead88b4ea8218dc5ccee514c70c585d commit ed927e1c4ead88b4ea8218dc5ccee514c70c585d Author: Kalin Stoyanov <kalin@chromium.org> Date: Thu Jan 05 21:56:05 2017 Remove the audio-box dependency for audio tests BUG= chromium:678627 TEST=Tested for lab boards Change-Id: I9bd4c7c5e423018c8d0ac98907c781a849520559 Reviewed-on: https://chromium-review.googlesource.com/425321 Commit-Ready: Kalin Stoyanov <kalin@chromium.org> Tested-by: Kalin Stoyanov <kalin@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org> (cherry picked from commit 8e2a74f5fae833acb268ed285ce486dd33cc2ba1) Reviewed-on: https://chromium-review.googlesource.com/428204 Reviewed-by: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/ed927e1c4ead88b4ea8218dc5ccee514c70c585d/server/site_tests/audio_AudioAfterSuspend/control.external_mic [modify] https://crrev.com/ed927e1c4ead88b4ea8218dc5ccee514c70c585d/server/site_tests/audio_AudioAfterSuspend/control.headphone [modify] https://crrev.com/ed927e1c4ead88b4ea8218dc5ccee514c70c585d/server/site_tests/audio_AudioAfterSuspend/audio_AudioAfterSuspend.py
,
Jan 17 2017
,
Jan 18 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by cychiang@chromium.org
, Jan 5 2017