New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678623 link

Starred by 1 user
Status: Fixed
Owner:
vitaliii@chromium.org
Closed: Jan 2017
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 646841



Sign in to add a comment

In CategoryRanker metric propagate category position through the bridge.

Project Member Reported by vitaliii@chromium.org, Jan 5 2017 
Currently we provide content_suggestions_service_ as a parameter to the metric to calculate category position, in order not to duplicate the code between Android and iOS. Instead we could propagate category position from the UI.

Comment 1 by vitaliii@chromium.org, Jan 9 2017

Summary: In CategoryRanker metric propagate category position through the bridge. (was: In CategoryRanker metric propapgate category position through the bridge.)

Comment 2 by vitaliii@chromium.org, Jan 16 2017

Labels: zine-17-01-16 zine-17-01-09
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e86736a8f02a0506d02148b112fcca44fb5ece4

commit 1e86736a8f02a0506d02148b112fcca44fb5ece4
Author: vitaliii <vitaliii@chromium.org>
Date: Tue Jan 17 14:44:07 2017

[NTP::SectionOrder] Propagate category rank from UI through the bridge.

Provide category rank in |onSuggestionOpened| notification of the
bridge.

Reasons: we need it for metrics and the rank may have changed after the
NTP was opened, so UI is the only place to get "real" rank.

BUG= 678623 

Review-Url: https://codereview.chromium.org/2627603002
Cr-Commit-Position: refs/heads/master@{#444048}

[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/1e86736a8f02a0506d02148b112fcca44fb5ece4/chrome/browser/android/ntp/ntp_snippets_bridge.h

Comment 5 by vitaliii@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment