browser_tests flaky on chromium.chromiumos/Linux ChromiumOS Tests (1) |
|||||
Issue descriptionbrowser_tests flaky on chromium.chromiumos/Linux ChromiumOS Tests (1) ShelfAppBrowserTestWithMultiMonitor.BasicDragAndDrop is flaky, stdout (from builder https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/31740 ): Value of: service->IsAppListVisible() Actual: false Expected: true BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x000002e1df4e base::debug::StackTrace::StackTrace() #1 0x00000336ef66 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fec5b80e0b0 <unknown> #3 0x0000039b8766 AppListServiceAshTestApi::GetStartPageView() #4 0x0000012900c4 (anonymous namespace)::ClickAllAppsButtonFromStartPage() #5 0x00000128ee5b ShelfAppBrowserTestWithMultiMonitor_BasicDragAndDrop_Test::RunTestOnMainThread() #6 0x000002ebe477 InProcessBrowserTest::RunTestOnMainThreadLoop() #7 0x00000336ece8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #8 0x000002ef32ac ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x000002ef2481 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x0000017c577a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x000002626165 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x0000028d6c46 content::StartupTaskRunner::RunAllTasksNow() #13 0x0000026242fb content::BrowserMainLoop::CreateStartupTasks() #14 0x0000026291bb content::BrowserMainRunnerImpl::Initialize() #15 0x0000026219f8 content::BrowserMain() #16 0x000002dd35dc content::ContentMainRunnerImpl::Run() #17 0x000002dd2250 content::ContentMain() #18 0x00000336e64a content::BrowserTestBase::SetUp() #19 0x000002ebcb7e InProcessBrowserTest::SetUp() #20 0x000003925da8 testing::Test::Run() #21 0x000003926cb0 testing::TestInfo::Run() #22 0x000003927147 testing::TestCase::Run() #23 0x00000392e407 testing::internal::UnitTestImpl::RunAllTests() #24 0x00000392e01a testing::UnitTest::Run() #25 0x000002ecad21 base::TestSuite::Run() #26 0x000002e1391b ChromeTestSuiteRunner::RunTestSuite() #27 0x000003396bd7 content::LaunchTests() #28 0x000002e11f71 main #29 0x7fec5b7f97ed __libc_start_main #30 0x00000065a591 <unknown> The suspected CL is https://codereview.chromium.org/2576913002
,
Jan 5 2017
Patch to disable is here: https://codereview.chromium.org/2618773002/ and cycling through the bots now.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68bd340663cba6214b7d6ba42b05673188d6daa2 commit 68bd340663cba6214b7d6ba42b05673188d6daa2 Author: sky <sky@chromium.org> Date: Thu Jan 05 17:42:00 2017 Disables ShelfAppBrowserTestWithMultiMonitor.BasicDragAndDrop Likely timing issues in test because of async changes, will investigate separately. BUG= 678622 TEST=test only R=msw@chromium.org TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2618773002 Cr-Commit-Position: refs/heads/master@{#441694} [modify] https://crrev.com/68bd340663cba6214b7d6ba42b05673188d6daa2/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
,
Jan 5 2017
,
Jan 6 2017
,
Jan 6 2017
I'm able to repro locally (what luck!), hopefully I'll have a fix soon.
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/722a6795c0472558994b50ec6669284eaf0e57ee commit 722a6795c0472558994b50ec6669284eaf0e57ee Author: msw <msw@chromium.org> Date: Mon Jan 09 23:37:33 2017 Fix flaky ShelfAppBrowserTest.MultiDisplayBasicDragAndDrop Use DisplayManagerTestApi::UpdateDisplay to config multi-display. (do not use the 'ash-host-window-bounds' command line flag). TODO: Figure out why this change fixes the flake ¯\_(ツ)_/¯ BUG= 678622 TEST=Automated test passes consistently. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2628433002 Cr-Commit-Position: refs/heads/master@{#442403} [modify] https://crrev.com/722a6795c0472558994b50ec6669284eaf0e57ee/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
,
Jan 9 2017
Hopefully this won't flake anymore... |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sky@chromium.org
, Jan 5 2017