"org.chromium.chrome.browser.precache.PrecacheLauncherTest" flakiness. |
||
Issue descriptionHi folks, I have a CL https://codereview.chromium.org/2614733002/ which I cannot land due to failing "org.chromium.chrome.browser.precache.PrecacheLauncherTest" tests (but I really need to land it before M57 FF). I discovered issue 648749 , which is very similar, and that is why I am adding you to this bug. I do not see any connection between my CL and "org.chromium.chrome.browser.precache.PrecacheLauncherTest" tests. As for flakiness, I have run trybots 4 times. Each time only linux_android_rel_ng fails, but the failing tests are different. Namely per each run: 1) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207440 org.chromium.chrome.browser.precache.PrecacheLauncherTest_testUpdateEnabled_Disabled_ThenEnabled org.chromium.chrome.browser.preferences.PasswordViewingTypeTest_testSyncingNativePasswordView 2) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207455 org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_SyncNotReady_ThenDisabled 3) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207465 org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_Disabled_ThenEnabled org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_SyncNotReady_ThenEnabled 4) https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207483 org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_SyncNotReady_ThenDisabled Do you happen to know how this could be resolved?
,
Jan 5 2017
Hi Boliu, Thank you very much for your advice (and commands)! I tried on a different (simpler CL, https://codereview.chromium.org/2615713003/) and this test passes locally multiple times. What else could I try?
,
Jan 5 2017
I forgot to mention, that CL fails on the same test on a trybot. https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207634
,
Jan 5 2017
Sorry for multiple posts (it's late :) ), I have Nexus 6P only, which may explain the difference. I will probably have to wait for this to resolve, because I have no clue how I could influence these tests.
,
Jan 5 2017
These tests has been pretty green on the main waterfall bot: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=PrecacheLauncherTest > I tried on a different (simpler CL, https://codereview.chromium.org/2615713003/) and this test passes locally multiple times. You are enabling an ntp feature there. Just because a CL is tiny does not automatically mean it only has a small effect. In this case enabling a feature can of course cause tests that made bad assumptions to break. I don't know much about ntp either, but all the evidence points to your CL actually causing these test to flake or fail, so you have to either learn how these tests work and why they fail, or you can ask someone more knowledgeable in these tests..
,
Jan 9 2017
The issue went away by itself. |
||
►
Sign in to add a comment |
||
Comment 1 by boliu@chromium.org
, Jan 5 2017