New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678609 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Encryption screen is not disabled on entering “Passphrase” and “Create passphrase” screen

Project Member Reported by pmadalla@chromium.org, Jan 5 2017

Issue description

App Version: 56.0.2924.53 dev
iOS Version: 9.3.5, iOS 10
Device: iPhone,iPad

Steps to reproduce:
 1. Launch chrome and Sign in to chrome.
 2. Tap on Menu > Settings > Select the signed in user > Tap on Sync
 3. Tap on Encryption > Tap on “Encrypt all synced data with your own sync passphrase”.
 4. Enter Passphrase and Confirm Passphrase.
 5. Tap on submit 

Observed results:
Encryption screen is not disabled

Expected results:
Encryption screen should be disabled and “Encrypt all synced data with your own sync passphrase” should be selected

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): No in M55.0.2883.79
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in 56.0.2924.53 dev

Link to Video : 
M56 :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpbUY4ODNxVEMtOFE/view?usp=sharing

M55 :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2Epa2FLV0NaQWtmbjQ/view?usp=sharing

 
Owner: bzanotti@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97a0d3d3c1d8f6ed0d5597f9a4f595a9b057b2e

commit e97a0d3d3c1d8f6ed0d5597f9a4f595a9b057b2e
Author: bzanotti <bzanotti@chromium.org>
Date: Fri Jan 06 12:53:00 2017

[iOS] Correctly reload Sync Encryption settings screen on sync changes.

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG= 678609 

Review-Url: https://codereview.chromium.org/2610403003
Cr-Commit-Position: refs/heads/master@{#441927}

[modify] https://crrev.com/e97a0d3d3c1d8f6ed0d5597f9a4f595a9b057b2e/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verification = Successful

Verified on latest chrome canary version 57.0.2977.0 on iPhone 7 plus with iOS 10.2 following the steps mentioned in comment #0. Encryption screen options are disabled after setting sync passphrase to the account.  Looks good.

Sign in to add a comment