WebKit/Source/platform/graphics/gpu/SharedGpuContext.h uses std::function, but doesn't include <functional>
Reported by
markustr...@gmail.com,
Jan 5 2017
|
|||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2950.4 Safari/537.36
Steps to reproduce the problem:
WebKit/Source/platform/graphics/gpu/SharedGpuContext.h uses std::function, but doesn't include <functional>:
In file included from ../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp:5:0:
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:38:16: error: ‘function’ in namespace ‘std’ does not name a template type
typedef std::function<std::unique_ptr<WebGraphicsContext3DProvider>()>
^~~~~~~~
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:40:51: error: ‘ContextProviderFactory’ has not been declared
static void setContextProviderFactoryForTesting(ContextProviderFactory);
^~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:53:3: error: ‘ContextProviderFactory’ does not name a type
ContextProviderFactory m_contextProviderFactory = nullptr;
^~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp: In member function ‘void blink::SharedGpuContext::createContextProviderIfNeeded()’:
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp:48:7: error: ‘m_contextProviderFactory’ was not declared in this scope
if (m_contextProviderFactory) {
^~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp:48:7: note: suggested alternative: ‘m_contextProvider’
if (m_contextProviderFactory) {
^~~~~~~~~~~~~~~~~~~~~~~~
m_contextProvider
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp: At global scope:
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp:83:5: error: variable or field ‘setContextProviderFactoryForTesting’ declared void
ContextProviderFactory factory) {
^~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp:83:5: error: ‘ContextProviderFactory’ was not declared in this scope
What is the expected behavior?
adding "#include <functional>" to SharedGpuContext.h fixes the issue.
What went wrong?
_
Did this work before? N/A
Chrome version: 57.0.2950.4 Channel: n/a
OS Version:
Flash Version:
,
Aug 21 2017
,
Aug 22 2017
So how does it build? Will investigate. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ajha@chromium.org
, Jan 6 2017