New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678600 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

legacy_page_test module update missed

Project Member Reported by mattcary@chromium.org, Jan 5 2017

Issue description

Causing chrome_proxy_tests to fail; seemingly due to https://codereview.chromium.org/2539973004.
 

Comment 1 by bengr@chromium.org, Jan 6 2017

Cc: bustamante@chromium.org

Comment 2 by bengr@chromium.org, Jan 6 2017

Components: Internals>Network>DataProxy
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddded05fefc02ea8728712c829adba8b48b39f3a

commit ddded05fefc02ea8728712c829adba8b48b39f3a
Author: mattcary <mattcary@chromium.org>
Date: Fri Jan 06 01:23:57 2017

Fix missed legacy_page_test module update.

This was missed by https://codereview.chromium.org/2539973004

BUG= 678600 

Review-Url: https://codereview.chromium.org/2615613005
Cr-Commit-Position: refs/heads/master@{#441786}

[modify] https://crrev.com/ddded05fefc02ea8728712c829adba8b48b39f3a/tools/chrome_proxy/common/network_metrics.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ef83e8146d9314a9234b0ebf6b93fa65888aaa

commit d7ef83e8146d9314a9234b0ebf6b93fa65888aaa
Author: mattcary <mattcary@chromium.org>
Date: Fri Jan 06 15:23:59 2017

Missed legacy_page_test module update

Continuation of cl/2615613005, updating module page_test to legacy_page_test.

BUG= 678600 
TBR=bustamante

Review-Url: https://codereview.chromium.org/2614123003
Cr-Commit-Position: refs/heads/master@{#441941}

[modify] https://crrev.com/d7ef83e8146d9314a9234b0ebf6b93fa65888aaa/tools/chrome_proxy/common/chrome_proxy_metrics.py

Compiles now
Status: Started (was: Untriaged)
Status: Fixed (was: Started)

Sign in to add a comment