New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678586 link

Starred by 1 user
Status: Fixed
Owner:
vitaliii@chromium.org
Closed: Jan 2017
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 646841



Sign in to add a comment

In ClickBasedRanker dismissed category clicks should be reduced based on higher category, not lower.

Project Member Reported by vitaliii@chromium.org, Jan 5 2017 
Currently if you have 3 categories A, B and C in this order and dismiss A (under penalty 1), its clicks will be reduced based on C's clicks. It should be based on B's clicks instead.

Can be done after FF.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af30d62df054e880fa5e0fd285ddbac847325f5

commit 3af30d62df054e880fa5e0fd285ddbac847325f5
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Jan 12 15:44:14 2017

[NTP::SectionOrder] Ensure decreasing clicks when category dismissed.

Ensure that dismissing a category cannot increase its clicks and use
the previous category clicks, not the next one.

Due to PassingMargin, it is possible that lower categories have more
clicks. Before this CL, this could lead to dismissed category clicks
increase, which was not intended. Now we take mininum of new and old
clicks.
In addition to this before this CL, click count was reduced based on
the next category in the list, after this CL, on the previous one.

BUG= 678586 

Review-Url: https://codereview.chromium.org/2616813003
Cr-Commit-Position: refs/heads/master@{#443237}

[modify] https://crrev.com/3af30d62df054e880fa5e0fd285ddbac847325f5/components/ntp_snippets/category_rankers/click_based_category_ranker.cc

Comment 2 by vitaliii@chromium.org, Jan 12 2017

Labels: zine-16-01-09
Status: Fixed (was: Assigned)
►

Sign in to add a comment