New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678569 link

Starred by 1 user
Status: WontFix
Owner:
█ danilchap@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
ehmaldonado@chromium.org
█ danilchap@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.2%-20.4% regression in content_browsertests at 441390:441405

Project Member Reported by danilchap@chromium.org, Jan 5 2017 
Probably caused by https://codereview.webrtc.org/2609403002
Can you double check compilation/optimization flags stayed same for the tests.

Comment 1 by danilchap@chromium.org, Jan 5 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=678569

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_82dpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_-CLsQsM


Bot(s) for this bug's original alert(s):

chromium-webrtc-trunk-tot-rel-linux
chromium-webrtc-trunk-tot-rel-mac

Comment 2 by ehmaldonado@chromium.org, Jan 5 2017 

Flags seem to have stayed the same.
Should I revert?

Comment 3 by danilchap@chromium.org, Jan 5 2017 

I'll revert to validate if performance change caused by your CL.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/5fbcd228f0781526ce2cbafba0a1f39f481ad81b

commit 5fbcd228f0781526ce2cbafba0a1f39f481ad81b
Author: danilchap <danilchap@webrtc.org>
Date: Thu Jan 05 12:57:49 2017

Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ )

Reason for revert:
Probably cause unexpected performance regression
BUG= chromium:678569 

Original issue's description:
> Refactor webrtc_perf_tests into several source_sets.
>
> BUG= webrtc:6954 
>
> Review-Url: https://codereview.webrtc.org/2609403002
> Cr-Commit-Position: refs/heads/master@{#15902}
> Committed: https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea97cb348fe5302f7

TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= webrtc:6954 

Review-Url: https://codereview.webrtc.org/2613913002
Cr-Commit-Position: refs/heads/master@{#15916}

[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/BUILD.gn
[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/call/BUILD.gn
[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/modules/audio_coding/BUILD.gn
[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/modules/audio_processing/BUILD.gn
[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/modules/remote_bitrate_estimator/BUILD.gn
[modify] https://crrev.com/5fbcd228f0781526ce2cbafba0a1f39f481ad81b/webrtc/video/BUILD.gn

Comment 5 by hang1011...@gmail.com, Jan 5 2017 

Hang101171900@gmail.com

Comment 6 by danilchap@chromium.org, Jan 5 2017

Owner: danilchap@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/021eef32f408558bbd11c5ac6eeaa1b15386762c

commit 021eef32f408558bbd11c5ac6eeaa1b15386762c
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Thu Jan 05 15:09:50 2017

Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ )

Reason for revert:
Try again.

Original issue's description:
> Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ )
>
> Reason for revert:
> Probably cause unexpected performance regression
> BUG= chromium:678569 
>
> Original issue's description:
> > Refactor webrtc_perf_tests into several source_sets.
> >
> > BUG= webrtc:6954 
> >
> > Review-Url: https://codereview.webrtc.org/2609403002
> > Cr-Commit-Position: refs/heads/master@{#15902}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea97cb348fe5302f7
>
> TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= webrtc:6954 
>
> Review-Url: https://codereview.webrtc.org/2613913002
> Cr-Commit-Position: refs/heads/master@{#15916}
> Committed: https://chromium.googlesource.com/external/webrtc/+/5fbcd228f0781526ce2cbafba0a1f39f481ad81b

TBR=kjellander@webrtc.org,danilchap@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:678569 

Review-Url: https://codereview.webrtc.org/2615873002
Cr-Commit-Position: refs/heads/master@{#15919}

[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/BUILD.gn
[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/call/BUILD.gn
[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/modules/audio_coding/BUILD.gn
[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/modules/audio_processing/BUILD.gn
[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/modules/remote_bitrate_estimator/BUILD.gn
[modify] https://crrev.com/021eef32f408558bbd11c5ac6eeaa1b15386762c/webrtc/video/BUILD.gn

Comment 8 by danilchap@chromium.org, Jan 9 2017

Cc: ehmaldonado@chromium.org
Components: Blink>WebRTC
Status: WontFix (was: Assigned)
Graphs went back to pre-alert level.
►

Sign in to add a comment