[NTP Client] Offline icon seems to be cropped under downloads snippets when device font size is huge
Reported by
kye...@etouch.net,
Jan 5 2017
|
||||||||||
Issue descriptionApplication Version: Chrome 57.0.2972.0 Android Build Number: 6.0.1/MMB29K Device: Samsung Galaxy J7(SM-J700F) Precondition: 1. Change device font size to 'Huge' Steps to reproduce: 1. Launch Chrome. 2. Go to www.wikipedia.org 3. Tap on download icon from chrome menu to save page offline. 4. Open NTP> Observe offline icon of recently saved offline page under downloads section. Note: Issue is also reproducible for offline icon of bookmarks under recent bookmarks section. Observed behavior: Offline icon of recently saved offline page under downloads section seems to be cropped when device font size is huge. Expected behavior: Offline icon should not crop with huge font size. Frequency: <5/5> Additional comments: 1. This issue is present from M-56.0.2909.0 build from when the feature was implemented. 2. This issue is present on all builds of M57. 3. This issue is reproducible on Spice Mi-498(6.0.1/MOB30W),Karbonn Sparkle V(5.1.1/LMY47V),Samsung Galaxy J7(SM-J700F)(6.0.1/MMB29K),Samsung Galaxy J2(SM-J200G)(5.1.1/LMY47X)
,
Jan 5 2017
,
Jan 5 2017
Mark, can you take a look? What I see is the layout of the NTP card not adjusting properly. I don't believe it is an issue with the offline icon.
,
Jan 5 2017
Mark is OOO. I redirect to UI folks (namely peconn@ who worked on the offline badge in UI).
,
Jan 5 2017
Rachel, what should we do in this case? Should we get rid of the offline icon altogether or truncate the publisher text to fit the icon on?
,
Jan 9 2017
Truncate (with ellipsis) the date/or time and leave the icon right aligned at the margin. If the host name is too long, it would eventually be truncated on the right.
,
Jan 9 2017
,
Jan 18 2017
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1193bdc94a5163af5cd0a71bf438c44fa08fd16 commit a1193bdc94a5163af5cd0a71bf438c44fa08fd16 Author: peconn <peconn@chromium.org> Date: Thu Jan 19 15:54:04 2017 [NTP] Prevent Long Publisher pushing Offline Badge off a card. With long publishers, small screens, large font sizes or some combination of the above the publisher attribution can push the Offline Badge off the right hand side of the Card. By using weights we can make the TextView ellipsize before pushing the Offline Badge off the card. BUG= 678568 Review-Url: https://codereview.chromium.org/2646533002 Cr-Commit-Position: refs/heads/master@{#444744} [modify] https://crrev.com/a1193bdc94a5163af5cd0a71bf438c44fa08fd16/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
,
Jan 23 2017
,
Jan 24 2017
This issue is fixed in current M57 build - 57.0.2987.8 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kye...@etouch.net
, Jan 5 2017