New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678550 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.3%-40% improvement in webrtc_perf_tests at 15899:15899

Project Member Reported by danilchap@chromium.org, Jan 5 2017

Issue description

https://codereview.webrtc.org/2609113003 Change to BitrateProber
improvements with TransportSequenceNumber.
Expected improvments?
 
This is not intentional.

What I have found so far is that the time delta between calls to HandleProbeAndEstimateBitrate is always 0 or 1 with my CL, and 0 or 1 except for the first probe with cluster id 1, then the delta is much larger.

So without my CL it looks like this (delta in ms):
273656934, 0, 0, 0, 0, 0, 0, 0, 0, 49, 0, 0, 0
with my CL:
273523983, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0

I will continue to look into it.
Status: WontFix (was: Assigned)
It looks like the first feedback vector contains information about 7-8 packets, and since we now only require 8 packets (instead of 9) to get the result from both the initial probing attempts we now don't have to wait for an additional 50 ms for the next feedback vector to be delivered, which cause this change.

Also, lots of these tests have been removed now and are not interesting anymore.

Closing.

Sign in to add a comment