New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678548 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression : Chrome crashes when trying to sign out from chrome through URL.

Reported by yfulgaon...@etouch.net, Jan 5 2017

Issue description

Chrome Version : 57.0.2972.0 (Official Build) b1f498915edb2115c8f993e60e19728afda80acb-refs/heads/master@{#441559} 64 bit
OS : Mac(10.12.1, 10.11.6, 10.12)

Precondition : Freshly install chrome and sign in to chrome using valid credentials.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings page.
2. Now in the same page, navigate to chrome://md-settings/signOut
3. Observe.

Actual : Chrome crashes when trying to sign out from chrome through URL 
Expected : Chrome should not crash and sign out overlay should appear when signing out through URL.

Crash ID e396fff0-48bb-4e1d-b4e1-a5e59354c7b1 (Server ID: 41aeb89080000000)

Crash ID b9d5f773-2f68-4685-88f2-18323371e563 (Server ID: 4139874480000000)

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2958.0
Bad build : 57.0.2959.0

Note : Sometimes need to repeat step 2 twice in order to reproduce the crash.
 
Actual_crash.mov
9.0 MB Download
Expected_result.mov
4.2 MB Download
Labels: OS-Linux OS-Windows
Cc: manoranj...@chromium.org dimu@chromium.org
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI ReleaseBlock-Dev
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)
Just to update the Steps to reproduce --
(i) Sign in to chrome with valid credentials.
(ii) Now navigate to chrome://md-settings/signOut and observe.

Using the per-revision bisect providing the bisect results,
Good build: 57.0.2958.0 (Revision: 439976).
Bad build: 57.0.2959.0 (Revision: 440307).

You are probably looking for a change made after 440212 (known good), but no later than 440213 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/ff7cfc31cc358e47ed3b311a97fb6f9a728507dc..59b7fbb4ee5a2379ac668131c77d3099bbaa138d

@mahmadi -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression, please remove if not required.

Providing Stack Trace for the Crash ID -- 41aeb89080000000

Crash ID ::
============
Thread 0 CRASHED [EXC_BAD_INSTRUCTION / EXC_I386_INVOP @ 0x0000000113eec0ed ] MAGIC SIGNATURE THREAD
Stack Quality78%Show frame trust levels
0x0000000113eec0ed	(Google Chrome Framework -web_ui_message_handler.h:103 )	settings::ProfileInfoHandler::PushProfileStatsCount(std::__1::vector<profiles::ProfileCategoryStat, std::__1::allocator<profiles::ProfileCategoryStat> >)
0x0000000113eec2c0	(Google Chrome Framework -bind_internal.h:214 )	base::internal::Invoker<base::internal::BindState<void (settings::ProfileInfoHandler::*)(std::__1::vector<profiles::ProfileCategoryStat, std::__1::allocator<profiles::ProfileCategoryStat> >), base::internal::UnretainedWrapper<settings::ProfileInfoHandler> >, void (std::__1::vector<profiles::ProfileCategoryStat, std::__1::allocator<profiles::ProfileCategoryStat> >)>::Run(base::internal::BindStateBase*, std::__1::vector<profiles::ProfileCategoryStat, std::__1::allocator<profiles::ProfileCategoryStat> >&&)
0x0000000111815d57	(Google Chrome Framework -callback.h:85 )	ProfileStatisticsAggregator::StatisticsCallback(char const*, ProfileStatisticsAggregator::ProfileStatValue)
0x00000001119c75d7	(Google Chrome Framework -callback.h:85 )	base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
0x0000000111959050	(Google Chrome Framework -callback.h:68 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x000000011197d9ba	(Google Chrome Framework -message_loop.cc:421 )	base::MessageLoop::RunTask(base::PendingTask*)
0x000000011197dd0b	(Google Chrome Framework -message_loop.cc:430 )	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x000000011197e0c2	(Google Chrome Framework -message_loop.cc:523 )	base::MessageLoop::DoWork()
0x0000000111981359	(Google Chrome Framework -message_pump_mac.mm:302 )	base::MessagePumpCFRunLoopBase::RunWork()
0x0000000111971fc9	(Google Chrome Framework + 0x01998fc9 )	base::mac::CallWithEHFrame(void () block_pointer)
0x0000000111980dd3	(Google Chrome Framework -message_pump_mac.mm:278 )	base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
0x00007fff9e47f4c0	(CoreFoundation + 0x000a44c0 )	__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
0x00007fff9e4608cb	(CoreFoundation + 0x000858cb )	__CFRunLoopDoSources0
0x00007fff9e45fdb5	(CoreFoundation + 0x00084db5 )	__CFRunLoopRun
0x00007fff9e45f7b3	(CoreFoundation + 0x000847b3 )	CFRunLoopRunSpecific
0x00007fff9d9ef2ab	(HIToolbox + 0x000312ab )	RunCurrentEventLoopInMode
0x00007fff9d9ef0e0	(HIToolbox + 0x000310e0 )	ReceiveNextEventCommon
0x00007fff9d9eef15	(HIToolbox + 0x00030f15 )	_BlockUntilNextEventMatchingListInModeWithFilter
0x00007fff9bff16cc	(AppKit + 0x000476cc )	_DPSNextEvent
0x00007fff9c76882f	(AppKit + 0x007be82f )	-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
0x000000011152965f	(Google Chrome Framework -chrome_browser_application_mac.mm:187 )	__71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke
0x0000000111971fc9	(Google Chrome Framework + 0x01998fc9 )	base::mac::CallWithEHFrame(void () block_pointer)
0x0000000111529598	(Google Chrome Framework -chrome_browser_application_mac.mm:186 )	-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
0x00007fff9bfe606c	(AppKit + 0x0003c06c )	-[NSApplication run]
0x0000000111981b9d	(Google Chrome Framework -message_pump_mac.mm:637 )	base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*)
0x000000011198121b	(Google Chrome Framework -message_pump_mac.mm:210 )	base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
0x000000011199fb42	(Google Chrome Framework -run_loop.cc:37 )	base::RunLoop::Run()
0x000000011152f088	(Google Chrome Framework -chrome_browser_main.cc:1987 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x0000000110d196c3	(Google Chrome Framework -browser_main_loop.cc:1171 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x0000000110d1c381	(Google Chrome Framework -browser_main_runner.cc:141 )	content::BrowserMainRunnerImpl::Run()
0x0000000110d1526b	(Google Chrome Framework -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const&)
0x00000001114e6d2f	(Google Chrome Framework -content_main_runner.cc:793 )	content::ContentMainRunnerImpl::Run()
0x00000001114e5ff5	(Google Chrome Framework -content_main.cc:20 )	content::ContentMain(content::ContentMainParams const&)
0x000000010ffdc37a	(Google Chrome Framework -chrome_main.cc:112 )	ChromeMain
0x000000010953cd99	(Google Chrome Canary + 0x00000d99 )	
0x00007fffb3769254	(libdyld.dylib + 0x00005254 )	start

Thank You.
Status: Started (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 5 2017

Labels: FoundIn-M-57 Fracas
Users experienced this crash on the following builds:

Mac Canary 57.0.2972.0 -  1.66 CPM, 1 reports, 1 clients (signature settings::ProfileInfoHandler::PushProfileStatsCount)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Blocking: 671375
Labels: -ReleaseBlock-Dev -M-57 Hotlist-MD-Settings-Navigation
Sounds like a fix for this is in the works. As a note, I can't repro on Chrome OS 56.0.2924.28 (Official Build) beta (64-bit)

Remove RB-Dev since MD Settings has not launched to beta/stable yet.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/005913147578ab11de32f536c7d7748df8f1d4bc

commit 005913147578ab11de32f536c7d7748df8f1d4bc
Author: mahmadi <mahmadi@chromium.org>
Date: Sat Jan 07 00:55:21 2017

[MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut

BUG= 678548 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614883004
Cr-Commit-Position: refs/heads/master@{#442118}

[modify] https://crrev.com/005913147578ab11de32f536c7d7748df8f1d4bc/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/005913147578ab11de32f536c7d7748df8f1d4bc/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/005913147578ab11de32f536c7d7748df8f1d4bc/chrome/test/data/webui/settings/people_page_test.js

Status: Fixed (was: Started)

Sign in to add a comment