New issue
Advanced search Search tips

Issue 678545 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 612339



Sign in to add a comment

Decouple screen orientation IPC from ordering with Channel

Project Member Reported by blundell@chromium.org, Jan 5 2017

Issue description

Screen orientation IPC is currently Channel-associated. In order to turn Screen Orientation into a self-contained service, this need for ordering with Channel IPC needs to be broken. This task is also necessary to enable Blink Onion Soup of screen orientation, as there is by design no way for Blink to directly access Channel-associated interfaces.
 
Labels: DeviceService
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0

commit e4db177a6f1e8cde2f3f85788161d42dab5cb8e0
Author: leon.han <leon.han@intel.com>
Date: Tue Feb 07 14:19:16 2017

[ScreenOrientation] Merge ScreenOrientation into ScreenOrientationProvider.

ScreenOrientation has no actual functionality other than forwarding
lock/unlock requests to ScreenOrientationProvider, so this CL
merges it into ScreenOrientationProvider and removes it.

This CL also removes declarition of
content::RenderFrameHostDelegate::GetScreenOrientationProvider() because
no codes expect RenderFrameHostDelegate has such a method.

BUG=678545
TEST=content_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2649823002
Cr-Commit-Position: refs/heads/master@{#448617}

[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/BUILD.gn
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/frame_host/render_frame_host_delegate.h
[delete] https://crrev.com/aa8ec6485091dda9862eb62960b881a60ef9e132/content/browser/screen_orientation/screen_orientation.cc
[delete] https://crrev.com/aa8ec6485091dda9862eb62960b881a60ef9e132/content/browser/screen_orientation/screen_orientation.h
[add] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/screen_orientation/screen_orientation_provider_unittest.cc
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/public/browser/screen_orientation_provider.cc
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/public/browser/screen_orientation_provider.h
[modify] https://crrev.com/e4db177a6f1e8cde2f3f85788161d42dab5cb8e0/content/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/552e9de9f523cb755187ab7c3a288f25bee4df8b

commit 552e9de9f523cb755187ab7c3a288f25bee4df8b
Author: leon.han <leon.han@intel.com>
Date: Thu Feb 09 14:37:30 2017

[ScreenOrientation] Hide ScreenOrientationProvider inside WebContentsImpl.

This CL hides ScreenOrientationProvider inside WebContentsImpl,
because it is not so necessary to be content public.
Instead this CL:
  - Exposes SetScreenOrientationDelegate() on web_contents.h
  - Exposes OnScreenOrientationChange() on web_contents_impl.h

Then it would be quite clear what the touchpoints of ScreenOrientationProvider
with the rest of the browser process are, which makes it all the easier to
analyze them (and to avoid those touchpoints growing larger as we try to
eliminate them).

BUG=678545
TEST=content_unittests
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2682643002
Cr-Commit-Position: refs/heads/master@{#449288}

[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/BUILD.gn
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/browser_main_loop.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/screen_orientation/screen_orientation_delegate_android.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/screen_orientation/screen_orientation_delegate_win.cc
[rename] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/screen_orientation/screen_orientation_provider.cc
[rename] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/screen_orientation/screen_orientation_provider.h
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/screen_orientation/screen_orientation_provider_unittest.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/public/browser/BUILD.gn
[modify] https://crrev.com/552e9de9f523cb755187ab7c3a288f25bee4df8b/content/public/browser/web_contents.h

Comment 5 by leon....@intel.com, Feb 14 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb3acfe64e6fe8405bda628b059567e0ca3f451e

commit bb3acfe64e6fe8405bda628b059567e0ca3f451e
Author: leon.han <leon.han@intel.com>
Date: Wed Mar 15 07:11:25 2017

[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2745443002
Cr-Commit-Position: refs/heads/master@{#457021}

[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/browser/BUILD.gn
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/browser/screen_orientation/screen_orientation_delegate_android.cc
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/browser/screen_orientation/screen_orientation_delegate_android.h
[delete] https://crrev.com/fc599795d2c67209375dddfe4806d9b58a5f1905/content/browser/screen_orientation/screen_orientation_listener_android.cc
[delete] https://crrev.com/fc599795d2c67209375dddfe4806d9b58a5f1905/content/browser/screen_orientation/screen_orientation_listener_android.h
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/common/screen_orientation_messages.h
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/renderer/BUILD.gn
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/renderer/screen_orientation/screen_orientation_observer.cc
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/content/renderer/screen_orientation/screen_orientation_observer.h
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/ipc/ipc_message_start.h
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/BUILD.gn
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/device_service.cc
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/device_service.h
[modify] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/manifest.json
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/BUILD.gn
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/DEPS
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/OWNERS
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/android/java/DEPS
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/android/java/src/org/chromium/device/screen_orientation/ScreenOrientationListener.java
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/screen_orientation_listener_android.cc
[add] https://crrev.com/bb3acfe64e6fe8405bda628b059567e0ca3f451e/services/device/screen_orientation/screen_orientation_listener_android.h

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/880b3a975ba7d0a4eda16332bcb8bac63f561405

commit 880b3a975ba7d0a4eda16332bcb8bac63f561405
Author: leon.han <leon.han@intel.com>
Date: Thu Mar 16 04:03:08 2017

Remove screen_orientation_messages.h.

This CL is a follow-up of https://codereview.chromium.org/2745443002.

blink::WebScreenOrientationLockType traits is defined in
screen_orientation_messages.h but has only one user: manifest_manager_messages.h,
so we just move it into manifest_manager_messages.h, thus
screen_orientation_messages.h becomes empty and we can remove it completely.

BUG=678545

Review-Url: https://codereview.chromium.org/2749863004
Cr-Commit-Position: refs/heads/master@{#457344}

[modify] https://crrev.com/880b3a975ba7d0a4eda16332bcb8bac63f561405/content/common/BUILD.gn
[modify] https://crrev.com/880b3a975ba7d0a4eda16332bcb8bac63f561405/content/common/content_message_generator.h
[modify] https://crrev.com/880b3a975ba7d0a4eda16332bcb8bac63f561405/content/common/manifest_manager_messages.h
[delete] https://crrev.com/cc4fa24df64468cb490a6247534cf79a2e4698cb/content/common/screen_orientation_messages.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044

commit b7d0a0d196d6b45cb3c4acad994ce98ec05cb044
Author: leon.han <leon.han@intel.com>
Date: Fri Mar 17 08:11:53 2017

[Device Service] Eliminate content::ScreenOrientationObserver.

This CL lets Blink talk directly with Device Service to consume the
mojo interface device.mojom.ScreenOrientationListener, then removes
content::ScreenOrientationObserver completely.

BUG=678545

Review-Url: https://codereview.chromium.org/2751513007
Cr-Commit-Position: refs/heads/master@{#457713}

[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/content/renderer/BUILD.gn
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/content/renderer/renderer_blink_platform_impl.cc
[delete] https://crrev.com/6e4c507dc612077518d242eabcfae9622601d7e6/content/renderer/screen_orientation/screen_orientation_observer.cc
[delete] https://crrev.com/6e4c507dc612077518d242eabcfae9622601d7e6/content/renderer/screen_orientation/screen_orientation_observer.h
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/third_party/WebKit/Source/modules/screen_orientation/BUILD.gn
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/third_party/WebKit/Source/modules/screen_orientation/DEPS
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.h
[modify] https://crrev.com/b7d0a0d196d6b45cb3c4acad994ce98ec05cb044/third_party/WebKit/public/platform/WebPlatformEventType.h

Comment 9 by leon....@intel.com, Oct 17 2017

Cc: blundell@chromium.org
Status: Available (was: Started)
As there are ordering constraints between screen orientation lock/unlock and legacy IPC ViewMsg_Resize, now we are using Channel-associated interface in content/renderer/screen_orientation/screen_orientation_dispatcher.h, which we can't put inside Blink because by design Blink has no way to directly access Channel-associated interfaces. We must firstly break the need for ordering with Channel IPC, but this is hard to figure out clearly now. 
Components: Internals>Services>Device

Comment 11 by leon....@intel.com, Dec 13 2017

Cc: leon....@intel.com
Owner: ke...@intel.com
Status: Assigned (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126dc52ad8308bbd43aeb742bda0d62ac967f1ed

commit 126dc52ad8308bbd43aeb742bda0d62ac967f1ed
Author: Ke He <ke.he@intel.com>
Date: Thu Dec 28 05:39:25 2017

Change the browsertest of screen_orientation_dispatcher to unittest.

This test doesn't have to be a browsertest, being a unittest is also
good enough to fulfill its test purpose.

As a part of Onion Soup, the screen_orientation_dispatcher will be moved
into blink. It will be easiler to move an unittest to blink than to move
a browsertest.

BUG=678545

Change-Id: I5ea5b8527885c9443fbbd991402243b8c506a25a
Reviewed-on: https://chromium-review.googlesource.com/842104
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526277}
[rename] https://crrev.com/126dc52ad8308bbd43aeb742bda0d62ac967f1ed/content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc
[modify] https://crrev.com/126dc52ad8308bbd43aeb742bda0d62ac967f1ed/content/test/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74cbc97f545c0a31d4bc1809616421733fdba2db

commit 74cbc97f545c0a31d4bc1809616421733fdba2db
Author: Ke He <ke.he@intel.com>
Date: Wed Jan 03 09:45:27 2018

Remove base::IDMap from screen_orientation_dispatcher.

As a part of Onion Soup, the screen_orientation_dispatcher will be
moved into blink where the base::IDMap is not allowed to use. So we
remove the base::IDMap first in this CL, which makes the next moving
step easier.

BUG=678545

Change-Id: Id46a80d07c4da90ce8807b1e97a9bee947b1944f
Reviewed-on: https://chromium-review.googlesource.com/846699
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526657}
[modify] https://crrev.com/74cbc97f545c0a31d4bc1809616421733fdba2db/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
[modify] https://crrev.com/74cbc97f545c0a31d4bc1809616421733fdba2db/content/renderer/screen_orientation/screen_orientation_dispatcher.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31534c861804a7de0951f9014905995bdf5fcbe0

commit 31534c861804a7de0951f9014905995bdf5fcbe0
Author: Ke He <ke.he@intel.com>
Date: Tue Jan 30 08:11:00 2018

[Onion Soup] Move the screen_orientation_dispatcher into blink.

Move the screen_orientation_dispatcher from //content/renderer/ to //blink.

After the moving, the screen_orienation_dispatcher actually acts as a delegate
of ScreenOrientationControllerImpl, it holds a
device::mojom::blink::ScreenOrientationAssociatedPtr by which to send lock
or unlock requests to browser process. So in blink, we rename it as
ScreenOrientationDelegate.

After the moving, the WebScreenOrientationClient interface has no reason to
exist anymore, so we delete it. The layout-test needs to be migrated from
using WebScreenOrientationClient to mojo. So in MockScreenOrientationClient,
we provide a fake mojo implementation of ScreenOrientation and override the
AssociatedInterfaceProvider in frame level.

The unittest of original screen_orientation_dispatcher is moved to
webkit_unit_test. Some other unittests which have dependencies on the removed
WebScreenOrientationClient are also fixed.

BUG=678545

Change-Id: If02f7661d53bbba83e368182f0e10f04b89c5fbe
Reviewed-on: https://chromium-review.googlesource.com/848735
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532808}
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/common/associated_interface_provider_impl.cc
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/renderer/BUILD.gn
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/renderer/render_frame_impl.h
[delete] https://crrev.com/7ca57c8d9b1fd2b68108a827274c56b6ed58c749/content/renderer/screen_orientation/OWNERS
[delete] https://crrev.com/7ca57c8d9b1fd2b68108a827274c56b6ed58c749/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
[delete] https://crrev.com/7ca57c8d9b1fd2b68108a827274c56b6ed58c749/content/renderer/screen_orientation/screen_orientation_dispatcher.h
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/DEPS
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/mock_screen_orientation_client.cc
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/mock_screen_orientation_client.h
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/content/test/BUILD.gn
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/LayoutTests/external/wpt/screen-orientation/resources/sandboxed-iframe-locking.html
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/media_controls/DEPS
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/BUILD.gn
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/DEPS
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
[add] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegate.cpp
[add] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegate.h
[rename] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegateTest.cpp
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/7ca57c8d9b1fd2b68108a827274c56b6ed58c749/third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h
[modify] https://crrev.com/31534c861804a7de0951f9014905995bdf5fcbe0/third_party/WebKit/public/web/WebFrameClient.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1017eb9143e734793d735b46a1a0ce1adb52120b

commit 1017eb9143e734793d735b46a1a0ce1adb52120b
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Tue Jan 30 09:40:07 2018

[jumbo] fixup after onion soup screen_orientation_dispatcher improvements

This fixes the following error in jumbo builds:

/../../third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegateTest.cpp:51:46: error: unknown class name 'Test'; did you mean '::testing::Test'?
class ScreenOrientationDelegateTest : public testing::Test {
                                             ^~~~~~~~~~~~~
                                             ::testing::Test

Followup after https://chromium-review.googlesource.com/c/chromium/src/+/848735

TBR=haraken@chromium.org

Bug: 678545
Change-Id: Ide6d0c6c0c7b8f1d45acad9aeca1e7998e5fa94e
Reviewed-on: https://chromium-review.googlesource.com/891959
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#532820}
[modify] https://crrev.com/1017eb9143e734793d735b46a1a0ce1adb52120b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegateTest.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d

commit f7d9e46f864fd74ab9806b26086b0fc78d9ac32d
Author: Ke He <ke.he@intel.com>
Date: Mon Feb 05 05:11:09 2018

Merge ScreenOrientationDelegate into ScreenOrientationControllerImpl.

ScreenOrientationDelegate is moved into blink from //content, it is mainly
used to maintain and operate the mojo InterfacePtr, so it is better to be
merged into ScreenOrientationControllerImpl.

Also fixed the unittest accordingly.

BUG=678545

Change-Id: I47da12bfe23b734f8cfbb6206bc07087b3dc116b
Reviewed-on: https://chromium-review.googlesource.com/892365
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534331}
[modify] https://crrev.com/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d/third_party/WebKit/Source/modules/screen_orientation/BUILD.gn
[modify] https://crrev.com/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
[rename] https://crrev.com/f7d9e46f864fd74ab9806b26086b0fc78d9ac32d/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImplTest.cpp
[delete] https://crrev.com/2772aa2f37fa60f5e95d7934222099af8b1555b4/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegate.cpp
[delete] https://crrev.com/2772aa2f37fa60f5e95d7934222099af8b1555b4/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegate.h

Project Member

Comment 17 by sheriffbot@chromium.org, Aug 22

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "ke.he@intel.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment