New issue
Advanced search Search tips

Issue 678539 link

Starred by 2 users
Status: Fixed
Owner:
skyos...@chromium.org
Closed: Jan 2017
Cc:
eseckler@chromium.org
skyos...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support --window-size with comma separated values in headless shell

Project Member Reported by eseckler@chromium.org, Jan 5 2017 
Currently, we provide the window size as "1024x768". That's fine, but leads to confusion because chrome has a --window-size flag that expects the size as "1024,768". We should support both ways.

Comment 1 by paulir...@chromium.org, Jan 5 2017 

Yeah this just bit me hard :)

http://peter.sh/experiments/chromium-command-line-switches/#window-size currently prints the headless description, rather than the Chrome one. Had to poke around in the source to discover there are two conflicting descriptions.

Comment 2 by skyos...@chromium.org, Jan 10 2017

Owner: skyos...@chromium.org
Status: Started (was: Available)
Hehe, oops. Fix here: https://codereview.chromium.org/2622773003/
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa5c484578fa649c62a44e90a08f921eae03e96

commit caa5c484578fa649c62a44e90a08f921eae03e96
Author: skyostil <skyostil@chromium.org>
Date: Tue Jan 10 16:28:08 2017

headless: Allow both WW,HH and WWxHH forms for specifying window size

As Chrome only supports the former format, change the documentation to
refer to that.

BUG= 678539 

Review-Url: https://codereview.chromium.org/2622773003
Cr-Commit-Position: refs/heads/master@{#442609}

[modify] https://crrev.com/caa5c484578fa649c62a44e90a08f921eae03e96/headless/app/headless_shell.cc
[modify] https://crrev.com/caa5c484578fa649c62a44e90a08f921eae03e96/headless/app/headless_shell_switches.cc

Comment 4 by skyos...@chromium.org, Jan 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment