Regression: Incorrect focus position is seen in Switch person window on pressing Tab key.
Reported by
vvishwak...@etouch.net,
Jan 5 2017
|
|||||||
Issue descriptionChrome Version: 57.0.2972.0 (Official Build) b1f498915edb2115c8f993e60e19728afda80acb-refs/heads/master@{#441559} (32/64-bit) OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, and add a new profile from chrome://settings. 2) Click on avatar icon and select ‘Manage people’ (Switch person window opens). 3) Press Tab key twice and then press Space key and then press Esc key. 4) Now press Tab key and observe. On pressing Tab key focus should shift to second person. On pressing Tab key focus shifts to ‘BROWSE AS GUEST’ option. This is a Regression issue broken in M-53, will soon update other info Manual bisect: Good build: 53.0.2767.0 Bad build: 53.0.2768.0
,
Jan 5 2017
Using the per-revision bisect providing the bisect results, Good build: 53.0.2767.0 (revision : 399650) Bad build: 53.0.2768.0 (revision : 399800) You are probably looking for a change made after 399751 (known good), but no later than 399760 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/dca42159c2b19c25f033ff6e5e0da8d70a491576..e2fa57eacaf6a1a8f0fd8449603e29e647b183c2 From the above CL , suspecting the below change and assigning it to the concern owner. https://chromium.googlesource.com/chromium/src/+/ed3fb0c8a982d960df283046ed3ae781454095a6 @mahmadi - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2061793002 Thanks!
,
Jan 5 2017
CC+ mahmadi to answer comment #2.
,
Jan 5 2017
Typo in Comment #2 , used old bisect script and provided the CL.
,
Jan 5 2017
msarda@ the behavior seems to have regressed. but it is not caused by the CL in question. I recommend looking at recent changes to the user_pod_row.* and user_pod_template.* for the culprit. My guess is some upstream changes in tabIndex by cros folks caused this to break.
,
Jan 11 2017
,
Jan 16 2017
,
Jan 17 2017
This could be the fault of this CL of mine: https://codereview.chromium.org/2054783002 I'm OOO until 1/30. If this can wait until early Feb, assign it to me, and I'll have a look when I get back.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfdf813f504c796ec690a1e63b657048f1713f8f commit cfdf813f504c796ec690a1e63b657048f1713f8f Author: jlebel <jlebel@chromium.org> Date: Thu Jan 19 18:11:23 2017 Action box area should get focus back after closing user menu In the user manager window, when the user menu is being closed by escape key, the focus should be set to the action box area element. BUG= 678533 Review-Url: https://codereview.chromium.org/2644903002 Cr-Commit-Position: refs/heads/master@{#444788} [modify] https://crrev.com/cfdf813f504c796ec690a1e63b657048f1713f8f/ui/login/account_picker/user_pod_row.js
,
Jan 19 2017
,
Feb 15 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bzanotti@chromium.org
, Jan 5 2017Status: Assigned (was: Unconfirmed)