New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

http/tests/inspector/network/network-filters.html is flaky

Project Member Reported by yhirano@chromium.org, Jan 5 2017

Issue description

Owner: serg...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

Owner: allada@chromium.org
Status: Fixed (was: Untriaged)
Thanks allada for finishing and landing my CL.
Status: Assigned (was: Fixed)
Actually, looks like the test is still flaky. In a recent build, it again produced unexpected text output: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/368682.

DIFF:

--- /b/rr/tmpsebRj2/w/layout-test-results/http/tests/inspector/network/network-filters-expected.txt
+++ /b/rr/tmpsebRj2/w/layout-test-results/http/tests/inspector/network/network-filters-actual.txt
@@ -46,10 +46,10 @@
 
 filterText: is:from-cache
 isRegex: false
-Found results: 1
+Found results: 3
 
 filterText: -is:from-cache
 isRegex: false
-Found results: 3
+Found results: 1
 

Comment 6 by allada@chromium.org, Jan 11 2017

Hmmmm, The recent changes to reusing memory cache is the culprit. I may have been wrong with enable/disable cache in devtools to clear the cache. I know it does clear the cache, but it may do it lazily so if the test runs to fast it won't clear it.

We have a few of these in our protocol. I will talk to our tech lead and see what the priority on this is.

Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e808c49adda173df5e94e147d0bc71fcc0d621

commit 93e808c49adda173df5e94e147d0bc71fcc0d621
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Nov 15 02:26:12 2017

[Devtools] clearBrowserCache is now properly async

clearBrowserCache in protocol was dispatching the call and immidiatly
sending success back over protocol without knowing when the event was
finished. This patch fixes that.

R=caseq,dgozman
BUG= 678486 

Change-Id: Idb55e9590f04a7b56ac8249188e839a60b28bdd5
Reviewed-on: https://chromium-review.googlesource.com/577068
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516564}
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/devtools/network/waterfall-images-expected.png
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-mac10.10/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/devtools/network/network-columns-visible-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/devtools/network/network-columns-visible-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/win/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/win7/http/tests/devtools/network/network-filters-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/devtools/network/network-columns-visible-expected.txt
[delete] https://crrev.com/8e1966b926d5aa94ae21a22c9c026d9fc7449292/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/devtools/network/network-filters-expected.txt
[modify] https://crrev.com/93e808c49adda173df5e94e147d0bc71fcc0d621/third_party/WebKit/Source/devtools/front_end/network_test_runner/NetworkTestRunner.js

Status: Fixed (was: Assigned)

Sign in to add a comment