OOPIF DevTools: Improve display of subframe source in Elements tab |
||
Issue descriptionChrome Version: 57.0.2971.0 OS: Win10 What steps will reproduce the problem? (0) Enable "Auto-attach to cross-process subframes" DevTools experiment and start Chrome with --site-per-process (see https://crbug.com/652783#c8 ). (1) Visit http://csreis.github.io/tests/cross-site-iframe-simple.html (2) Right click on main frame and choose Inspect. (3) Look at the Elements tab. What is the expected result? The subframe elements should be appear somehow separate from the main frame elements, such as nested within the iframe tag or given some kind of visual separator. The exact presentation is open to discussion. What happens instead? The subframe elements are appended to the main frame elements, making it look like they come later in the same page. (See scrreenshot.)
,
Feb 27 2017
I think the suggested easy fix is the minimum we should do, otherwise the markup is very very confusing. Inlining will be awesome too ;).
,
Feb 27 2017
Yeah, I have a patch which just waits to be landed: https://codereview.chromium.org/2715663005/. Inlining is not possible right now, because we don't have global ids to connect RFHI from browser to RemoteFrame/HTMLIFrameElement instances in renderer. Should we pass FrameTreeNode ids around?
,
Feb 27 2017
Each frame should have an unique name associated with it, isn't that not useful here?
,
Feb 27 2017
Anything unique works! I'll take a look at how we can use it.
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3f79d4d77ed2b095cc5959f975be917eccc81c4 commit b3f79d4d77ed2b095cc5959f975be917eccc81c4 Author: dgozman <dgozman@chromium.org> Date: Tue Feb 28 00:16:28 2017 [DevTools] Add header for OOPIF's elements trees. They are now separated by the "Frame <link>" headers. We will probably experiment with tabs later. BUG= 678442 Review-Url: https://codereview.chromium.org/2715663005 Cr-Commit-Position: refs/heads/master@{#453407} [modify] https://crrev.com/b3f79d4d77ed2b095cc5959f975be917eccc81c4/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js [modify] https://crrev.com/b3f79d4d77ed2b095cc5959f975be917eccc81c4/third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css
,
Mar 6 2018
This was fixed by Pavel. |
||
►
Sign in to add a comment |
||
Comment 1 by alph@chromium.org
, Jan 10 2017Status: Assigned (was: Untriaged)