New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678435 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Jan 2017
Cc:
█ kozyatinskiy@chromium.org
creis@chromium.org
dgozman@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 652783



Sign in to add a comment

OOPIF DevTools: Console context for iframe named "top"

Project Member Reported by creis@chromium.org, Jan 5 2017 
Chrome Version: 57.0.2971.0
OS: Win10

What steps will reproduce the problem?
(0) Enable "Auto-attach to cross-process subframes" DevTools experiment and start Chrome with --site-per-process (see  https://crbug.com/652783#c8 ).
(1) Visit http://csreis.github.io/tests/cross-site-iframe-simple.html
(2) Right click on main frame and choose Inspect.
(3) In the DevTools Console, try to select the subframe's context.

What is the expected result?
The contexts should be named "top" and "frame1 (input-types.html)".

What happens instead?
The contexts are named "top" and "top".

Comment 1 by alph@chromium.org, Jan 10 2017

Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92ec9c389c41ecc50190973a3375e0d47d839ade

commit 92ec9c389c41ecc50190973a3375e0d47d839ade
Author: dgozman <dgozman@chromium.org>
Date: Tue Jan 24 02:40:29 2017

[DevTools] Improve context and target naming.

- nested iframes now get proper indentation in console;
- each target's top frame is now a parent to other frames in navigator;
- only main target's top frame is displayed as 'top'.

BUG= 678435 

Review-Url: https://codereview.chromium.org/2647153002
Cr-Commit-Position: refs/heads/master@{#445615}

[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting-expected.txt
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view-expected.txt
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/92ec9c389c41ecc50190973a3375e0d47d839ade/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Comment 3 by dgozman@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment