RPC cleanup: Split HostInfo class from CrosHost (and friends) to encapsulate information about the DUT |
||||
Issue descriptionThe *Host objects were intended to server as OO end points for interaction with the physical DUT. They have become bloated and contain all sorts of information about the DUT, accessing this information sometimes involves making RPC calls that obtains information from the infrastructure and even updates global state of the system at times. To remove this entanglement, the steps are roughly: (1) Break apart HostInfo objects from *Host objects - Start by *Host owning the *HostInfo object. - just proxy all information related calls to *Host to *HostInfo (2) Create *HostInfo independent of the *Host object, early in autoserv (because next step requires us to use autoserv commandline arguments for populating some of the fields in *HostInfo (3) Create a way to serialize *HostInfo objects to/from autoserv. - Move the AFE calls for querying information about the host one by one to be pre-populated in the scheduler Agent (no RPC, direct DB queries) - *HostInfo adds to this information with information queried from the DUT directly using the *Host object. - Finally, on completion of autoserv (success/failure) the *HostInfo is synced back to the scheduler and the global state is updated (via direct DB updates). This step should be fairly robust. Failing / dying autoserv should not compromise the final update
,
Jan 5 2017
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8749e14b700bdd98bcdde90df123f37d569e6767 commit 8749e14b700bdd98bcdde90df123f37d569e6767 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Jan 07 00:25:59 2017 server: Drop deprecated function from afe_utils. BUG= chromium:678430 TEST=None. Change-Id: I2d5ba0abc66c2e4abd8c7edb8efb7bc7d3de16cd Reviewed-on: https://chromium-review.googlesource.com/425831 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Dan Shi <dshi@chromium.org> [modify] https://crrev.com/8749e14b700bdd98bcdde90df123f37d569e6767/server/afe_utils.py
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/de748b5339f4e722544bad8bffecd255b22bba9e commit de748b5339f4e722544bad8bffecd255b22bba9e Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Jan 07 00:27:16 2017 cros_host: Drop deprecated funciton. BUG= chromium:678430 TEST=None. Change-Id: If0491082cc3790439054fe63f344c09d418b6e14 Reviewed-on: https://chromium-review.googlesource.com/425833 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Dan Shi <dshi@chromium.org> [modify] https://crrev.com/de748b5339f4e722544bad8bffecd255b22bba9e/server/hosts/cros_host.py
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/71d8f5829591a2ab81625ebaf7a76193970fcee1 commit 71d8f5829591a2ab81625ebaf7a76193970fcee1 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Jan 07 00:26:51 2017 cros_host: Drop deprecated function. BUG= chromium:678430 TEST=None Change-Id: Ia8ed379bbc239d2b2e9485510f2c063c5449a086 Reviewed-on: https://chromium-review.googlesource.com/425832 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Dan Shi <dshi@chromium.org> [modify] https://crrev.com/71d8f5829591a2ab81625ebaf7a76193970fcee1/server/hosts/cros_host.py
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/429d100e972f8ed44bd54e168f462d640cd6299b commit 429d100e972f8ed44bd54e168f462d640cd6299b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 23:30:53 2017 server_job: extract get_machine_dicts. BUG= chromium:678430 TEST=unittests. Change-Id: If31d906a73deb5d8cc7c776919c2a9cd3a295329 Reviewed-on: https://chromium-review.googlesource.com/426767 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/429d100e972f8ed44bd54e168f462d640cd6299b/server/server_job.py
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/429d100e972f8ed44bd54e168f462d640cd6299b commit 429d100e972f8ed44bd54e168f462d640cd6299b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 23:30:53 2017 server_job: extract get_machine_dicts. BUG= chromium:678430 TEST=unittests. Change-Id: If31d906a73deb5d8cc7c776919c2a9cd3a295329 Reviewed-on: https://chromium-review.googlesource.com/426767 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/429d100e972f8ed44bd54e168f462d640cd6299b/server/server_job.py
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5ae41397f4e633a12453faadeea4dbe1cc5e65bc commit 5ae41397f4e633a12453faadeea4dbe1cc5e65bc Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 23:57:25 2017 autoserv: Use server_job.get_machine_dicts BUG= chromium:678430 TEST=None. Change-Id: I2573935f0ba8ec653ee68eed49ddb66b1fa4e774 Reviewed-on: https://chromium-review.googlesource.com/426768 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/5ae41397f4e633a12453faadeea4dbe1cc5e65bc/server/autoserv
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ce4b88e9f76ddffef716366158ee9fb9ee4d933b commit ce4b88e9f76ddffef716366158ee9fb9ee4d933b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jan 06 00:53:52 2017 [refactor] Simplify host_class detection a bit. BUG= chromium:678430 TEST=unittests. Change-Id: Iff3d9c11dd66ba571173a37d4d090de98fa78cc0 Reviewed-on: https://chromium-review.googlesource.com/425328 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/ce4b88e9f76ddffef716366158ee9fb9ee4d933b/server/hosts/factory.py
,
Jan 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f457b7c9b75d90f81470fe2194ccc5f71b4bc614 commit f457b7c9b75d90f81470fe2194ccc5f71b4bc614 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 00:00:34 2017 Introduce HostInfo object. HostInfo is a new object that will be the single source of truth of host information for autoserv and tests as stored in the scheduling infrastructure. This will replace all direct access to AFE and other objects that cache this information for autoserv and the tests. BUG= chromium:678430 TEST=(new) unittests. Change-Id: If4f6f730ef456cfb05fa11ba1ade1e7d3565bed4 Reviewed-on: https://chromium-review.googlesource.com/425329 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [add] https://crrev.com/f457b7c9b75d90f81470fe2194ccc5f71b4bc614/server/hosts/host_info.py [add] https://crrev.com/f457b7c9b75d90f81470fe2194ccc5f71b4bc614/server/hosts/host_info_unittest.py
,
Jan 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1b2704cdad9af67cc0d38859ca07805be885e418 commit 1b2704cdad9af67cc0d38859ca07805be885e418 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 00:01:32 2017 Add AfeStore implementation of CachingHostInfoStore. This is a CachingHostInfoStore that uses AFE RPC calls to refresh / update host information from the infrastructure. The implementation currently doesn't update attributes. We'll fill that in when we replace the first attribute update call to go via HostInfo. BUG= chromium:678430 TEST=new unittests. Change-Id: I40e77f0005af44a142845c79d02f75b10e638b29 Reviewed-on: https://chromium-review.googlesource.com/426012 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/1b2704cdad9af67cc0d38859ca07805be885e418/server/hosts/base_label.py [add] https://crrev.com/1b2704cdad9af67cc0d38859ca07805be885e418/server/hosts/afe_store.py [add] https://crrev.com/1b2704cdad9af67cc0d38859ca07805be885e418/server/hosts/afe_store_unittest.py
,
Jan 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bc5cc545f0e7558f05d1537a3ecac8232b386d46 commit bc5cc545f0e7558f05d1537a3ecac8232b386d46 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 23:58:08 2017 autoserv: Also pass in host_attributes in stage_ssp. The control file for stage_ssp is executed outside of the context of a server_job. This CL passes in host_attributes to the machine_dict, to bring the behaviour closer to server_job. BUG= chromium:678430 TEST=None. Change-Id: I1f68080c39dc1d002c02115771cbe97cf9a13808 Reviewed-on: https://chromium-review.googlesource.com/426769 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/bc5cc545f0e7558f05d1537a3ecac8232b386d46/server/autoserv
,
Jan 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cbebd983db4c57366e7d666b4ad1447bc7c5e1a1 commit cbebd983db4c57366e7d666b4ad1447bc7c5e1a1 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jan 10 23:59:43 2017 autoserv: Unconditionally convert machine names to dict. stage_ssp was converting machine names to dict only when running inside the lab. There is no reason to do this since get_machine_dicts already stubs out host_afe when not in lab. By always using a dict, we can simplify the control files' handling of the machines list. BUG= chromium:678430 TEST=None. Change-Id: Ic3e39eeab74772c382e7c2b349b585ddb3c2d8b6 Reviewed-on: https://chromium-review.googlesource.com/426770 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/cbebd983db4c57366e7d666b4ad1447bc7c5e1a1/server/autoserv
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/07b5d9844b3966fed42517713f7510921e48a257 commit 07b5d9844b3966fed42517713f7510921e48a257 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 11 20:08:33 2017 server_job: Add host_info_store to the machine dict. BUG= chromium:678430 TEST=None. Change-Id: I39fc3bd5a1ff84bc19fab7d7a05d4d0653cf6b03 Reviewed-on: https://chromium-review.googlesource.com/426920 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/07b5d9844b3966fed42517713f7510921e48a257/server/server_job.py
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8b5065d7bee5c73b08d216de3df4faedebab8ecf commit 8b5065d7bee5c73b08d216de3df4faedebab8ecf Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 11 01:13:01 2017 server: Inject a CachingHostInfoStore into Host objects. This perpetuates the original sin of CL:349990, additionally providing a CachingHostInfoStore with the frontend.Host object (afe_host). This is a hack to allow us to easily replace uses of afe_host with HostInfo. We currently punt on the question of the correct ownership of HostInfo. BUG= chromium:678430 TEST=None. Change-Id: I2586b73d58d9679c032a5f48b357f7d343ea2614 Reviewed-on: https://chromium-review.googlesource.com/426921 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/8b5065d7bee5c73b08d216de3df4faedebab8ecf/server/hosts/abstract_ssh.py [modify] https://crrev.com/8b5065d7bee5c73b08d216de3df4faedebab8ecf/server/hosts/factory_unittest.py [modify] https://crrev.com/8b5065d7bee5c73b08d216de3df4faedebab8ecf/server/hosts/factory.py
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28616daf6f224d3cd50fac20bb0113f83654025c commit 28616daf6f224d3cd50fac20bb0113f83654025c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 11 20:58:25 2017 server_job: Simplify afe_host creation logic. ... a bit. BUG= chromium:678430 TEST=None. Change-Id: I8dffbbe7a6337843cfd1120150f4117982ca84ed Reviewed-on: https://chromium-review.googlesource.com/427239 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/28616daf6f224d3cd50fac20bb0113f83654025c/server/server_job.py
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e450240a032cb3d56743c7e857ea1f7c5678ecc9 commit e450240a032cb3d56743c7e857ea1f7c5678ecc9 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 11 20:18:29 2017 provision_AutoUpdate.double: Use HostInfo to obtain current build. Update the control file to obtain current build via HostInfo instead of going directly to the AFE. BUG= chromium:678430 TEST=provision_AutoUpdate.double runs from a local AFE. Change-Id: I7cbd9b458b9350564f9da493e99cab8727d81211 Reviewed-on: https://chromium-review.googlesource.com/427278 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/e450240a032cb3d56743c7e857ea1f7c5678ecc9/server/site_tests/provision_AutoUpdate/control.double
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cfff58a85dadb192486386976c90eba660933565 commit cfff58a85dadb192486386976c90eba660933565 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 20:47:39 2017 telemetry: Remove dependence on afe_utils BUG= chromium:678430 TEST=Run a telemetry test locally. Change-Id: Ic321abab4648d90f1ad2ce1981aab9b29510eedc Reviewed-on: https://chromium-review.googlesource.com/438712 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/cfff58a85dadb192486386976c90eba660933565/server/cros/telemetry_runner.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4723b1721a20f96d3febd87aae1a4c14a8344746 commit 4723b1721a20f96d3febd87aae1a4c14a8344746 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 22:58:29 2017 tradefed_test: Remove dependence on afe_utils. BUG= chromium:678430 TEST=Run a tradefed test in the lab. Change-Id: I664b6320e3ddb444e3d74611316649485bed613a Reviewed-on: https://chromium-review.googlesource.com/438711 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/4723b1721a20f96d3febd87aae1a4c14a8344746/server/cros/tradefed_test.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b2b7f0037732b0310eb1fdf9bc0f7d6d14e662f8 commit b2b7f0037732b0310eb1fdf9bc0f7d6d14e662f8 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 22:58:29 2017 platform_CryptohomeMigrateChapsToken: Remove afe_utils dependence BUG= chromium:678430 TEST=Run the modified test. Change-Id: I5b9785b3e926de1e9168d6bc0f4f622a9d6010a0 Reviewed-on: https://chromium-review.googlesource.com/438713 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b2b7f0037732b0310eb1fdf9bc0f7d6d14e662f8/server/site_tests/platform_CryptohomeMigrateChapsToken/platform_CryptohomeMigrateChapsToken.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/412e8d9c13b92ba2a0056ef89384f675a480aa3f commit 412e8d9c13b92ba2a0056ef89384f675a480aa3f Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 22:58:27 2017 [autotest] Add board, os properties to HostInfo BUG= chromium:678430 TEST=(new) unittests. Change-Id: I1033500122e09dfb3e165373c8a13e03181afed8 Reviewed-on: https://chromium-review.googlesource.com/438715 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/412e8d9c13b92ba2a0056ef89384f675a480aa3f/server/hosts/host_info.py [modify] https://crrev.com/412e8d9c13b92ba2a0056ef89384f675a480aa3f/server/hosts/host_info_unittest.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5c8be0b20c8e2f1ea3920135eb84cac49d5df4ab commit 5c8be0b20c8e2f1ea3920135eb84cac49d5df4ab Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 22:58:29 2017 provision_TestbedUpdate: Use HostInfo to obtain build information BUG= chromium:678430 TEST=Run provision on a testbed. Change-Id: I1b40b50852bde91a879b94b191a44e60eb8e4754 Reviewed-on: https://chromium-review.googlesource.com/439525 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/5c8be0b20c8e2f1ea3920135eb84cac49d5df4ab/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b148f0522961c8b8550df717e6091920801bacf6 commit b148f0522961c8b8550df717e6091920801bacf6 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Feb 09 22:58:26 2017 brillo_GTests: Use HostInfo to get build information BUG= chromium:678430 TEST=Run the test Change-Id: Ia0b5f764d8ba66f3e4c1d48a1cb05a12c5c320c2 Reviewed-on: https://chromium-review.googlesource.com/439526 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b148f0522961c8b8550df717e6091920801bacf6/server/site_tests/brillo_Gtests/brillo_Gtests.py
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd commit 7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Feb 11 01:00:34 2017 provision_AutoUpdate: Use HostInfo to obtain host information BUG= chromium:678430 TEST=Provision a DUT to the same build twice. Change-Id: I38cc58115cbfc608d923eb1b68ad0e30d8036431 Reviewed-on: https://chromium-review.googlesource.com/438714 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/server/site_tests/provision_AutoUpdate/provision_AutoUpdate.py
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd commit 7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Feb 11 01:00:34 2017 provision_AutoUpdate: Use HostInfo to obtain host information BUG= chromium:678430 TEST=Provision a DUT to the same build twice. Change-Id: I38cc58115cbfc608d923eb1b68ad0e30d8036431 Reviewed-on: https://chromium-review.googlesource.com/438714 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/server/site_tests/provision_AutoUpdate/provision_AutoUpdate.py
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/99094121b819eece21b0766ff9af803629769be3 commit 99094121b819eece21b0766ff9af803629769be3 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Feb 14 22:50:39 2017 [autotest] Drop afe_utils.get_build All users have been ported over to use HostInfo instead. BUG= chromium:678430 TEST=unittests. Change-Id: Idd7b9aaee63473cd310a83931cbf9f292c324154 Reviewed-on: https://chromium-review.googlesource.com/438697 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/99094121b819eece21b0766ff9af803629769be3/server/afe_utils_unittest.py [modify] https://crrev.com/99094121b819eece21b0766ff9af803629769be3/server/afe_utils.py
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3d470dd3952967294b76d55808b9a0514a54bfe8 commit 3d470dd3952967294b76d55808b9a0514a54bfe8 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Feb 14 22:50:36 2017 provision_AndroidUpdate: Use HostInfo to obtain host information BUG= chromium:678430 TEST=Run the test. Change-Id: Ie92d291f24b58f497d6e0f5e04668a4b27ee0185 Reviewed-on: https://chromium-review.googlesource.com/438717 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/3d470dd3952967294b76d55808b9a0514a54bfe8/server/site_tests/provision_AndroidUpdate/provision_AndroidUpdate.py
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dca57c27cd30eff37962921543b0fe8f5800fa54 commit dca57c27cd30eff37962921543b0fe8f5800fa54 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Feb 14 22:50:36 2017 [autotest] Return empty str for missing board, os labels We used to return None from HostInfo for board and os values when the corresponding labels are missing. OTOH, if the corresponding label existed, but had no value associated with it (e.g, 'os:'), we would return ''. In practice, these two cases are identical. BUG= chromium:678430 TEST=unittests Change-Id: I3adfdc1d498901ec7f98dc3d15ad992b8839f550 Reviewed-on: https://chromium-review.googlesource.com/441905 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/dca57c27cd30eff37962921543b0fe8f5800fa54/server/hosts/host_info.py [modify] https://crrev.com/dca57c27cd30eff37962921543b0fe8f5800fa54/server/hosts/host_info_unittest.py
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/361f8b4579d52c18e2ff332167b7c9b450e74e76 commit 361f8b4579d52c18e2ff332167b7c9b450e74e76 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Feb 15 01:54:12 2017 Revert "provision_TestbedUpdate: Use HostInfo to obtain build information" This reverts commit 5c8be0b20c8e2f1ea3920135eb84cac49d5df4ab. Reason for revert: This CL failed testing push due to "AttributeError: 'TestBed' object has no attribute 'host_info_store'" Original change's description: > provision_TestbedUpdate: Use HostInfo to obtain build information > > BUG= chromium:678430 > TEST=Run provision on a testbed. > > Change-Id: I1b40b50852bde91a879b94b191a44e60eb8e4754 > Reviewed-on: https://chromium-review.googlesource.com/439525 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Allen Li <ayatane@chromium.org> BUG= chromium:678430 Change-Id: I1bbb0f247d77608c621b5fcc6e35049618ad92c9 Reviewed-on: https://chromium-review.googlesource.com/442631 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/361f8b4579d52c18e2ff332167b7c9b450e74e76/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4b1b8f3af83162997c4b2cc4cae8ed97a46d7280 commit 4b1b8f3af83162997c4b2cc4cae8ed97a46d7280 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Feb 15 18:47:30 2017 [autotest] Save host_info_store on a TestBed, like other Hosts BUG= chromium:678430 TEST=push-to-prod succeeds Change-Id: Id520b7176aa7d32a224575b1fb9c77c736e17261 Reviewed-on: https://chromium-review.googlesource.com/442710 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Shuqian Zhao <shuqianz@chromium.org> [modify] https://crrev.com/4b1b8f3af83162997c4b2cc4cae8ed97a46d7280/server/hosts/testbed.py
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8aa41a23c9e1d1826a8ac6779ed059ef7155c01 commit c8aa41a23c9e1d1826a8ac6779ed059ef7155c01 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Feb 15 19:21:28 2017 provision_TestbedUpdate: Use HostInfo to obtain build information This is a reland of https://chromium-review.googlesource.com/#/c/438717/ The root cause for the revert was fixed by: https://chromium-review.googlesource.com/#/c/442710/ BUG= chromium:678430 TEST=None Change-Id: I2fb8a9ca15b2841471dbda1adc640f52c4a927a2 Reviewed-on: https://chromium-review.googlesource.com/443127 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/c8aa41a23c9e1d1826a8ac6779ed059ef7155c01/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8aa41a23c9e1d1826a8ac6779ed059ef7155c01 commit c8aa41a23c9e1d1826a8ac6779ed059ef7155c01 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Feb 15 19:21:28 2017 provision_TestbedUpdate: Use HostInfo to obtain build information This is a reland of https://chromium-review.googlesource.com/#/c/438717/ The root cause for the revert was fixed by: https://chromium-review.googlesource.com/#/c/442710/ BUG= chromium:678430 TEST=None Change-Id: I2fb8a9ca15b2841471dbda1adc640f52c4a927a2 Reviewed-on: https://chromium-review.googlesource.com/443127 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/c8aa41a23c9e1d1826a8ac6779ed059ef7155c01/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1855a32cb6dd637d33cde56f2c9ff09e4f85bd0b commit 1855a32cb6dd637d33cde56f2c9ff09e4f85bd0b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 03 06:02:21 2017 emulated_adb_host: Use HostInfo to obtain host information BUG= chromium:678430 TEST=None Change-Id: I9997aa040842614afc9aee8ac71065869a348966 Reviewed-on: https://chromium-review.googlesource.com/439889 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/1855a32cb6dd637d33cde56f2c9ff09e4f85bd0b/server/hosts/emulated_adb_host.py
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/075fc92c8af5eeb07ea5b9fa8ea253412ef71860 commit 075fc92c8af5eeb07ea5b9fa8ea253412ef71860 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 03 06:02:21 2017 [autotest] Drop uses of CrosHost._get_board_from_afe BUG= chromium:678430 TEST=unittests Change-Id: I1df262a0f600a791c0c35326b1b459cd931eded3 Reviewed-on: https://chromium-review.googlesource.com/439890 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/075fc92c8af5eeb07ea5b9fa8ea253412ef71860/server/hosts/cros_host.py [modify] https://crrev.com/075fc92c8af5eeb07ea5b9fa8ea253412ef71860/server/hosts/cros_firmware.py
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a3bb76542f9f71c5213a9498c1efd8f3cd52e3a5 commit a3bb76542f9f71c5213a9498c1efd8f3cd52e3a5 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 03 07:46:17 2017 [autotest] Remove afe_utils.get_board and afe_utils.get_os BUG= chromium:678430 TEST=None Change-Id: Ice31055706c1a1ee6ce67a901589a81c5812e064 Reviewed-on: https://chromium-review.googlesource.com/439891 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/a3bb76542f9f71c5213a9498c1efd8f3cd52e3a5/server/afe_utils_unittest.py [modify] https://crrev.com/a3bb76542f9f71c5213a9498c1efd8f3cd52e3a5/server/hosts/servo_host.py [modify] https://crrev.com/a3bb76542f9f71c5213a9498c1efd8f3cd52e3a5/server/afe_utils.py
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c0e976d011d55fa6f00c67fd65d24e6e2646fd6d commit c0e976d011d55fa6f00c67fd65d24e6e2646fd6d Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Mar 04 01:11:30 2017 [autotest] Use AfeHostInfoStore to obtain host information in test_push This is not really needed to remove autoserv dependencies on the AFE, but this allows us to remove the duplicated functions in site_utils. BUG= chromium:678430 TEST=test_push Change-Id: Id725e97b6d726fdf68c063582d45c640d4541bbe Reviewed-on: https://chromium-review.googlesource.com/442656 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Shuqian Zhao <shuqianz@chromium.org> [modify] https://crrev.com/c0e976d011d55fa6f00c67fd65d24e6e2646fd6d/site_utils/test_push.py
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/838f89f628e404bd3d657e5eb4b45c02bfb363b9 commit 838f89f628e404bd3d657e5eb4b45c02bfb363b9 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Mar 06 04:12:26 2017 Use HostInfo to obtain host attributes BUG= chromium:678430 TEST=unittests Change-Id: I4ae2d4ee0c19eae5545eeb9ff01a7fe8853bc34d Reviewed-on: https://chromium-review.googlesource.com/440366 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/site_tests/android_ACTS/android_ACTS.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/afe_utils.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/hosts/cros_host.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/adb_utils.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/cros/autoupdate_utils.py [modify] https://crrev.com/838f89f628e404bd3d657e5eb4b45c02bfb363b9/server/hosts/adb_host.py
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a commit b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Mar 07 19:14:48 2017 Revert "Use HostInfo to obtain host attributes" This reverts commit 838f89f628e404bd3d657e5eb4b45c02bfb363b9. Original change's description: > Use HostInfo to obtain host attributes > > BUG= chromium:678430 > TEST=unittests > > Change-Id: I4ae2d4ee0c19eae5545eeb9ff01a7fe8853bc34d > Reviewed-on: https://chromium-review.googlesource.com/440366 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> > TBR=pprabhu@chromium.org,ayatane@chromium.org BUG= chromium:678430 BUG= chromium:699188 Change-Id: I36b47500518ef4a710145f35f730e53d40cdb0a0 Reviewed-on: https://chromium-review.googlesource.com/450845 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/site_tests/android_ACTS/android_ACTS.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/afe_utils.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/hosts/cros_host.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/adb_utils.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/cros/autoupdate_utils.py [modify] https://crrev.com/b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a/server/hosts/adb_host.py
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8456cb61eea2e6e9173f457ba351755876da8fce commit 8456cb61eea2e6e9173f457ba351755876da8fce Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Mar 08 00:18:22 2017 [autotest] Pass in HostInfoStore from TestBed to it's children BUG= chromium:699188 BUG= chromium:678430 TEST=unittests, test_push passes. Change-Id: I08c75151e8b8e2aeaac76ae1151dcb1759d8c935 Reviewed-on: https://chromium-review.googlesource.com/450866 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/8456cb61eea2e6e9173f457ba351755876da8fce/server/hosts/testbed.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a6e851066a14eb3bb4555e53015843cfdd69ae6c commit a6e851066a14eb3bb4555e53015843cfdd69ae6c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 06:18:49 2017 [autotest] Add pool property to HostInfo BUG= chromium:678430 TEST=(new) unittests Change-Id: I114d1e75012ed36ba0a9321b6e0e2c1c3aa01211 Reviewed-on: https://chromium-review.googlesource.com/440562 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/a6e851066a14eb3bb4555e53015843cfdd69ae6c/server/hosts/host_info.py [modify] https://crrev.com/a6e851066a14eb3bb4555e53015843cfdd69ae6c/server/hosts/host_info_unittest.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b6cea61e59b40819af04fbf9ced7dba75785d43e commit b6cea61e59b40819af04fbf9ced7dba75785d43e Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:15 2017 Replaces usage of afe_utils.get_labels with HostInfo properties BUG= chromium:678430 TEST=None Change-Id: I3502e1d6baddd9f598634077854030005ceef290 Reviewed-on: https://chromium-review.googlesource.com/440563 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/cros_host.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/base_label.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/site_tests/provision_FirmwareUpdate/provision_FirmwareUpdate.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/cros_firmware.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/adb_host.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b6cea61e59b40819af04fbf9ced7dba75785d43e commit b6cea61e59b40819af04fbf9ced7dba75785d43e Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:15 2017 Replaces usage of afe_utils.get_labels with HostInfo properties BUG= chromium:678430 TEST=None Change-Id: I3502e1d6baddd9f598634077854030005ceef290 Reviewed-on: https://chromium-review.googlesource.com/440563 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/cros_host.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/base_label.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/site_tests/provision_FirmwareUpdate/provision_FirmwareUpdate.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/cros_firmware.py [modify] https://crrev.com/b6cea61e59b40819af04fbf9ced7dba75785d43e/server/hosts/adb_host.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/547c6d63a41292e034d1b41e4424c0dcd8ade9f3 commit 547c6d63a41292e034d1b41e4424c0dcd8ade9f3 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:14 2017 [autotest] Add HostInfo.get_label_value We often have 'key:value' as labels. This provides an method for a oft repeated pattern to obtain the first value for the given key. BUG= chromium:678430 TEST=unittests Change-Id: I4758ba5a39cfd2c45f7d8a00a8fa9fc2c9435dfc Reviewed-on: https://chromium-review.googlesource.com/442652 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/547c6d63a41292e034d1b41e4424c0dcd8ade9f3/server/hosts/host_info.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b25793e6f3395528a49875ae2b42ace99e653982 commit b25793e6f3395528a49875ae2b42ace99e653982 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:14 2017 [autotest] Use HostInfo for AFE interaction in wifi_client BUG= chromium:678430 TEST=None Change-Id: Ic0b51b777054d81c8184b9ea23ef21f7de6e44c6 Reviewed-on: https://chromium-review.googlesource.com/442653 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/b25793e6f3395528a49875ae2b42ace99e653982/server/cros/network/wifi_client.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4b4051baa31443a2a3908d5818795774f5dacdb6 commit 4b4051baa31443a2a3908d5818795774f5dacdb6 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:14 2017 [autotest] Use HostInfo to get AFE information in WifiCellTestBase BUG= chromium:678430 TEST=None Change-Id: Iac26bb0419daa99967b061ce7784eb6cc3529593 Reviewed-on: https://chromium-review.googlesource.com/442654 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/4b4051baa31443a2a3908d5818795774f5dacdb6/server/cros/network/wifi_cell_test_base.py
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/395e09104f658ab233d8769deb3899e052c07eeb commit 395e09104f658ab233d8769deb3899e052c07eeb Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 10 21:05:15 2017 enterprise_LongevityTrackerServer: Use HostInfo to get host information BUG= chromium:678430 TEST=None Change-Id: Ic3fb979165bfebc16711a3c2d4c0ee000261f005 Reviewed-on: https://chromium-review.googlesource.com/442655 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/395e09104f658ab233d8769deb3899e052c07eeb/server/site_tests/enterprise_LongevityTrackerServer/enterprise_LongevityTrackerServer.py
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9a8a977866e761a174e15bcdab2c2842ec26d26c commit 9a8a977866e761a174e15bcdab2c2842ec26d26c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Mar 15 00:09:58 2017 [autotest] Add a function to extract host_info_store from machine BUG= chromium:678430 TEST=(new) unittests Change-Id: I5214d645ae9a05f3bbc72d1434ee40e7a2a4e105 Reviewed-on: https://chromium-review.googlesource.com/452775 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/9a8a977866e761a174e15bcdab2c2842ec26d26c/server/hosts/host_info.py [modify] https://crrev.com/9a8a977866e761a174e15bcdab2c2842ec26d26c/server/hosts/host_info_unittest.py
,
Mar 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/f3a40afd0236181dff076d2f8bcb6f711ee696d2 commit f3a40afd0236181dff076d2f8bcb6f711ee696d2 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Mar 15 05:23:22 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9235e4cc7e52f941b7ae5a91183a56f4b991f750 commit 9235e4cc7e52f941b7ae5a91183a56f4b991f750 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Mar 29 20:43:12 2017 [autotest] Add back HostInfo get call from a bad revert. The revert b9d7adf07aec05db6a3f1a8b74f45abd7a87c74a interacted badly with a few CLs. This one hasn't affected anyone yet, afaict. BUG= chromium:678430 TEST=None Change-Id: I7f6df6e86d60660492e138c95482373cac75a6a2 Reviewed-on: https://chromium-review.googlesource.com/462022 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/9235e4cc7e52f941b7ae5a91183a56f4b991f750/server/hosts/cros_host.py
,
Mar 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/d6812c3db9b3f09e98cbe9fdf4ce40a5255fc765 commit d6812c3db9b3f09e98cbe9fdf4ce40a5255fc765 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 31 09:58:30 2017
,
Mar 31 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/d6812c3db9b3f09e98cbe9fdf4ce40a5255fc765 commit d6812c3db9b3f09e98cbe9fdf4ce40a5255fc765 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Mar 31 09:58:30 2017
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/18eb3aa424429cc738cff03aa9357881234cb077 commit 18eb3aa424429cc738cff03aa9357881234cb077 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Apr 21 09:34:47 2017 [autotest] Fix typo on HostInfo.__str__, add unittest. BUG= chromium:678430 TEST=(new) unittests Change-Id: Ie93e51d83cc443d43d5cd227ef68528fc2e9b953 Reviewed-on: https://chromium-review.googlesource.com/464567 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/18eb3aa424429cc738cff03aa9357881234cb077/server/hosts/host_info.py [modify] https://crrev.com/18eb3aa424429cc738cff03aa9357881234cb077/server/hosts/host_info_unittest.py
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f2a08e3b17d6d679b3c99c03d0797bac4c1a5b12 commit f2a08e3b17d6d679b3c99c03d0797bac4c1a5b12 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed May 24 06:59:18 2017 [autotest] Add equality / inequality operators to HostInfo So that we can compare infos in store tests. BUG= chromium:678430 TEST=(new) unittests Change-Id: Ibd8e4ae36df4072634e95fd2e69dd9ba5a142ac7 Reviewed-on: https://chromium-review.googlesource.com/462383 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/f2a08e3b17d6d679b3c99c03d0797bac4c1a5b12/server/hosts/host_info.py [modify] https://crrev.com/f2a08e3b17d6d679b3c99c03d0797bac4c1a5b12/server/hosts/host_info_unittest.py
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d2d95b371cdfaa91e39244f7e490c51d404d721e commit d2d95b371cdfaa91e39244f7e490c51d404d721e Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri May 26 00:15:47 2017 [autotest] Add HostInfo json serialize / deserialize functions. Will be used to serialize HostInfo objects to store on disk. Note that the serialized HostInfo objects will passed in-and-out of the SSP container. This means that the serialization format needs to be backward and forwards compatible. BUG= chromium:678430 TEST=(new) unittests Change-Id: I4b9db37f2f40956b5f5324362e131537c4454a3c Reviewed-on: https://chromium-review.googlesource.com/462384 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/d2d95b371cdfaa91e39244f7e490c51d404d721e/server/hosts/host_info.py [modify] https://crrev.com/d2d95b371cdfaa91e39244f7e490c51d404d721e/server/hosts/host_info_unittest.py
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d83a6a6d4ff6dc2483a026918728fc127605481b commit d83a6a6d4ff6dc2483a026918728fc127605481b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri May 26 00:15:48 2017 [autotest] Add FileStore for HostInfo File backed store will be used to pass HostInfo in-and-out of the autoserv process launched for a test, and between various autoserv processes launched for the tests. The backing file is file-locked to make sure that mutiple autoserv processes can safely access the data. BUG= chromium:678430 TEST=(new) unittests Change-Id: I831367f0cfc13fc132253eee9cd8d41112877301 Reviewed-on: https://chromium-review.googlesource.com/462385 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [add] https://crrev.com/d83a6a6d4ff6dc2483a026918728fc127605481b/server/hosts/file_store.py [add] https://crrev.com/d83a6a6d4ff6dc2483a026918728fc127605481b/server/hosts/file_store_unittest.py
,
May 26 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bbb2456ea3fff080e02c979e115d6a52b87805c0 commit bbb2456ea3fff080e02c979e115d6a52b87805c0 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 06 08:29:09 2017 [autotest] Use HostInfo in host factory to obtain host information This is the last use of afe_host object threaded through by server_job. We can now delete this object that duplicates the information already in host_info_store. BUG= chromium:678430 TEST=None Change-Id: I83917cfa0ef46279d1e8bd97e3ad74aa2b876ffa Reviewed-on: https://chromium-review.googlesource.com/453079 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/bbb2456ea3fff080e02c979e115d6a52b87805c0/server/hosts/factory_unittest.py [modify] https://crrev.com/bbb2456ea3fff080e02c979e115d6a52b87805c0/server/hosts/factory.py
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cbeab1213ad41c3631a71c97ec3eddc1aee20049 commit cbeab1213ad41c3631a71c97ec3eddc1aee20049 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 06 08:29:08 2017 [autotest] Respect exclusive --in-lab or --host-attributes arguments These two arguments to autoserv are not intended to be used together. The only user of --host-attributes are test_that / test_droid that use it for tests run outside the context of the lab via test_runner_utils.perform_run_from_autotest_root. This CL enforces this mutual exclusion to make way for a future CL that depends on this property. + As we begin to use HostInfoStore for storing the attribute information, copy the host_attributes into the store. BUG= chromium:678430 TEST=(1) test_that / test_droid still works. (2) in-lab hwtests via moblab. CQ-DEPEND=CL:519569 Change-Id: I0dcb3096a4797143df796855bf3babc155e76c67 Reviewed-on: https://chromium-review.googlesource.com/517771 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/cbeab1213ad41c3631a71c97ec3eddc1aee20049/server/server_job.py [modify] https://crrev.com/cbeab1213ad41c3631a71c97ec3eddc1aee20049/server/autoserv_parser.py
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7a3675fc5bef2de9dfcfac45ed0da27f493d7614 commit 7a3675fc5bef2de9dfcfac45ed0da27f493d7614 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 06 08:29:09 2017 [autotest] Use HostInfo to update version labels This CL slightly changes the semantics of clear_version_labels: All versions labels are cleared now instead of just the type of version recognized by the corresponding host class. This was always the intended behaviour. This CL also changes the semantics from afe_utils.add_version_label in that if the version prefix already exists, it is updated in place. This is the right thing to do because adding a version label to the end of the list when an earlier label exists has no effect (the first one takes precedence). BUG= chromium:678430 TEST=(1) (new) unittests (2) in-lab hwtests via moblab Change-Id: I3939e04953a1dd2ac0cf09f61462128410c0db06 Reviewed-on: https://chromium-review.googlesource.com/517772 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/7a3675fc5bef2de9dfcfac45ed0da27f493d7614/server/hosts/afe_store.py [modify] https://crrev.com/7a3675fc5bef2de9dfcfac45ed0da27f493d7614/server/hosts/host_info_unittest.py [modify] https://crrev.com/7a3675fc5bef2de9dfcfac45ed0da27f493d7614/server/afe_utils.py [modify] https://crrev.com/7a3675fc5bef2de9dfcfac45ed0da27f493d7614/server/hosts/afe_store_unittest.py [modify] https://crrev.com/7a3675fc5bef2de9dfcfac45ed0da27f493d7614/server/hosts/host_info.py
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/368abdf47d544aca4adbaf19d112e3457e056d3d commit 368abdf47d544aca4adbaf19d112e3457e056d3d Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 06 08:29:09 2017 [autotest] Use HostInfo to access host attributes This CL is a squash of four separate CLs that update autoserv and friends to use HostInfo to both obtain and update host attribute information. Squashed CLs: - Commit host attributes from AfeHostInfoStore - Use HostInfo to clear host attributes before provision - Use HostInfo to update host attributes in machine_install - Use HostInfo to obtain host attributes [Reland] The last CL got reverted earlier because the testbed host class was creating other hosts without going through the factory methods. As a result, the created hosts didn't have a host_info_store attribute. CL:450866 fixed that. BUG= chromium:678430 TEST=(1) unittests (2) test_that / test_droid still work. (3) in-lab hwtests via moblab Change-Id: I8d00d8aa05e2ef263db21cb0f5d660311c146b0b Reviewed-on: https://chromium-review.googlesource.com/517773 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/site_tests/android_ACTS/android_ACTS.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/hosts/afe_store_unittest.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/afe_utils.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/hosts/cros_host.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/hosts/afe_store.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/adb_utils.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/cros/autoupdate_utils.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py [modify] https://crrev.com/368abdf47d544aca4adbaf19d112e3457e056d3d/server/hosts/adb_host.py
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d252d26af8704f5653eafc668f0f6e3ddc033df1 commit d252d26af8704f5653eafc668f0f6e3ddc033df1 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Jun 06 08:29:10 2017 [autotest] Populate HostInfoStore from cli/host.py This CLI module creates a fake host object when creating a new host. Populate a HostInfoStore for the flow. BUG= chromium:678430 TEST=(1) moblab_SmokeSuite passes CQ-DEPEND=CL:517771 Change-Id: I25542d8ce26a2e19abd52a3a0aaff6b9df003391 Reviewed-on: https://chromium-review.googlesource.com/519569 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/d252d26af8704f5653eafc668f0f6e3ddc033df1/cli/host.py
,
Jun 28 2017
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7ae68aec08804d7dce326af1be28b49bc9a0f60c commit 7ae68aec08804d7dce326af1be28b49bc9a0f60c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jun 30 21:24:27 2017 [autotest] Move up results directory setup Moving this up allows us to use the inferred results directory while setting up SSP. BUG= chromium:678430 TEST=Run a local test using autoserv Change-Id: Id8faef08287bb6bffe61ff6521f2b484b5b8eb12 Reviewed-on: https://chromium-review.googlesource.com/537975 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/7ae68aec08804d7dce326af1be28b49bc9a0f60c/server/autoserv
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/09767b1668537265e08a170f2e485538a722f7cf commit 09767b1668537265e08a170f2e485538a722f7cf Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jun 30 23:02:46 2017 [autotest] Add ShadowingStore. This is a transitional CachingHostInfoStore that allows us to continue to use the AfeStore in autoserv, but also shadow it with a FileStore. This will help us uncover any divergence in the two stores, which may arise as a result of AfeStore getting updated out-of-band, invisible to the FileStore. BUG= chromium:678430 TEST=(new) unittests. Change-Id: I3f473cc93411051a188497ef10124ce5ff59421d Reviewed-on: https://chromium-review.googlesource.com/530126 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [add] https://crrev.com/09767b1668537265e08a170f2e485538a722f7cf/server/hosts/shadowing_store.py [add] https://crrev.com/09767b1668537265e08a170f2e485538a722f7cf/server/hosts/shadowing_store_unittest.py
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/67907010f40117379592d6c76324d112aeec01b7 commit 67907010f40117379592d6c76324d112aeec01b7 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jun 30 23:02:45 2017 [autotest] Add __str__ overrides to HostInfoStores. Pretty-print store objects in a more useful way. BUG= chromium:678430 TEST=(new) unittests. Change-Id: I025bf009646ca3d64d427e4dfa5c08586a00d212 Reviewed-on: https://chromium-review.googlesource.com/532714 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/file_store.py [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/afe_store_unittest.py [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/afe_store.py [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/file_store_unittest.py [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/host_info_unittest.py [modify] https://crrev.com/67907010f40117379592d6c76324d112aeec01b7/server/hosts/host_info.py
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/73c348d9f7de4b1d2b548fe8f48d68fe56cf919f commit 73c348d9f7de4b1d2b548fe8f48d68fe56cf919f Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jul 19 21:41:22 2017 [autotest] Drop last uses of afe_utils.get_host_attribute This was added since the refactor started. We're now ready to drop the old functions. BUG= chromium:678430 TEST=Tested on test_push server Change-Id: Id31adb16d2371a324122aef87c88fe2558e85b43 Reviewed-on: https://chromium-review.googlesource.com/530069 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/73c348d9f7de4b1d2b548fe8f48d68fe56cf919f/server/site_tests/android_ACTS/android_ACTS.py [modify] https://crrev.com/73c348d9f7de4b1d2b548fe8f48d68fe56cf919f/server/site_tests/android_EasySetup/android_EasySetup.py [modify] https://crrev.com/73c348d9f7de4b1d2b548fe8f48d68fe56cf919f/server/hosts/adb_host.py
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/08d744f056ca381ab7c31189892850029700fa7e commit 08d744f056ca381ab7c31189892850029700fa7e Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jul 26 23:46:51 2017 [autotest] Drop obsoleted RPC helper functions These are no longer referenced anywhere. BUG= chromium:678430 TEST=None Change-Id: I5b504e18093245b3d2f90cbca7335164eb5e5100 Reviewed-on: https://chromium-review.googlesource.com/530070 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [delete] https://crrev.com/7407ed72c68a241fd1d3d5ed5c76f007787ded3c/server/afe_utils_unittest.py [modify] https://crrev.com/08d744f056ca381ab7c31189892850029700fa7e/server/hosts/cros_host.py [modify] https://crrev.com/08d744f056ca381ab7c31189892850029700fa7e/server/afe_utils.py
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/588007d9c0db0c4b6e29ab38bb140cc8c8230b0c commit 588007d9c0db0c4b6e29ab38bb140cc8c8230b0c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Jul 27 03:03:59 2017 [autotest] Use ShadowingHostInfoStore in autoserv Instead of using an AfeStore to obtain host information from the AFE, this CL switches to a ShadowingHostInfoStore. The information still comes from the Afe, but is shadowed by a file on disk. Any differences between the local store and Afe are reported to monarch. BUG= chromium:678430 TEST=Run a job on local autotest instance with and without ssp. Change-Id: Ifa3da3c3449ac08bfc53dcef0c3e871b36b69602 Reviewed-on: https://chromium-review.googlesource.com/537976 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/588007d9c0db0c4b6e29ab38bb140cc8c8230b0c/server/server_job.py [modify] https://crrev.com/588007d9c0db0c4b6e29ab38bb140cc8c8230b0c/server/autoserv
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c4ff9f2f300f378ad161e662fb0a5b3ba5deb5b7 commit c4ff9f2f300f378ad161e662fb0a5b3ba5deb5b7 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Aug 02 19:47:46 2017 [autotest] Use HostInfo to obtain autotest client package version BUG= chromium:678430 TEST=(1) Run a sever-side via test_that. (2) Run the same test via local AFE. Change-Id: I3c5914f657875d6469db931d8c01c636bbbf0e7e Reviewed-on: https://chromium-review.googlesource.com/592343 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/c4ff9f2f300f378ad161e662fb0a5b3ba5deb5b7/server/site_autotest.py
,
Mar 29 2018
Let's track the last few steps in issue 827388 Steps left are turning off the AFE shadowing, and any straggler users (or those that have been added in the last ~6 months). These changes may have to be cherry-picked to release branches, so best kept separate. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pprabhu@chromium.org
, Jan 5 2017