New issue
Advanced search Search tips

Issue 678426 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Swipe broken for all directions other than 'left'

Reported by j...@imjoe.co, Jan 4 2017

Issue description

Chrome Version       : 55.0.2883.87 (Developer Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
                       55.0.2883.87 (Official Build) (64-bit)
                       55.0.2883.91 (Android)
URLs (if applicable) : https://material.angularjs.org/latest/demo/swipe
                       https://github.com/angular/material/issues/10145
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari:
    Firefox: OK
         IE:

What steps will reproduce the problem?
Using the Angular Material swipe demo:
(1) Try swiping right.
(2) Try swiping up.
(3) Try swiping down.

What is the expected result?
Swipe event triggered.

What happens instead?
Swipe event not triggered.

Please provide any additional information below. Attach a screenshot if
possible.

 

Comment 1 by ajha@chromium.org, Jan 6 2017

Components: Blink>Input
Labels: Needs-Triage-M55 OS-Android OS-Linux
Cc: jdduke@chromium.org
Issue is reproducible, tested on Samsung Galaxy S7/MMB29M, Nexus5X/7.0, chrome stable: 55.0.2883.91. 

Logcat & video @ http://go/chrome-androidlogs1/6/678426
Cc: -jdduke@chromium.org
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision M-57 OS-Mac OS-Windows
Owner: mustaq@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 10, Ubuntu 14.04 and Mac 10.12.2 on latest chrome stable #55.0.2883.87, Canary #57.0.2975.0	
Issue is broken in M55. 


Bisect Info:
===========
Good build : 55.0.2875.0,  Revision Range- 421703
Bad build  : 55.0.2876.0,  Revision Range- 421986

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/bd027238e7f3d3c8096c1a62e9063d8cbf5d8a80..902a3d6303dfbfd49a24173777afcb4b70234a17

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/902a3d6303dfbfd49a24173777afcb4b70234a17


From the above CL suspecting the below change
--------------------------------------
Review-Url: https://codereview.chromium.org/2375493005

mustaq @- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.



Thank You...

Comment 5 by ajha@chromium.org, Jan 17 2017

Labels: -Needs-Triage-M55
mustaq@: Could you please take a look at this and update the thread accordingly.

Comment 6 by ajha@chromium.org, Jan 17 2017

Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression

Comment 7 by twolfe...@gmail.com, Jan 25 2017

I am using angular material in my production mobile app, and Android users are really unhappy about this bug. It is used in the app to close its main sidebar, and scrolling in any direction, even down to view more options, causes it to close. It is also used to swipe between tabs in tab controls, and is very annoying when the tab changes when trying to scroll down on a page. I am considering removing all the swipe interactions from the Android app. It seems like a pretty important Chrome fix, but I don't know what to expect for time when it comes to fixes like this in Chrome. Is there any sort of time estimate for when this bug will be fixed in Chrome stable?

Comment 8 by mustaq@chromium.org, Jan 25 2017

Status: Started (was: Assigned)

Comment 9 by mustaq@chromium.org, Jan 25 2017

Adding "touch-action:none" to .swipedemoBasicUsage .demo-swipe solves the problem. Looks like we need a fix in Angular.
Labels: -M-57 Hotlist-Input-Dev PointerEvent
Status: ExternalDependency (was: Started)
Here are some Angular issues around handling PointerEvents. Edge also shows these bugs.

https://github.com/angular/material/issues/10145
https://github.com/angular/material/issues/10187
https://github.com/angular/material/issues/10294

I will leave the bug open to track the external fix. Removing M-57 label.
Status: Fixed (was: ExternalDependency)
The Angular team has fixed all these issues in the codebase, yayy!
https://github.com/angular/material/commit/79e64386d35658feb61ec8f35e12abd2753b6773

The fix will be released publicly hopefully today.

Cc: nzolghadr@chromium.org dtapu...@chromium.org
 Issue 689117  has been merged into this issue.

Sign in to add a comment