New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678400 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 662297



Sign in to add a comment

Form Not Secure form field's Learn More link should go to right language

Project Member Reported by elawrence@chromium.org, Jan 4 2017

Issue description

Chrome Version: 57.2971

In https://bugs.chromium.org/p/chromium/issues/detail?id=662297#c6, we added a "Learn More" link to the "Form not secure" dropdown. Clicking the link goes to a help center page.

The "hl=en" parameter on the end of the URL suggests to me that this is hard-coded to English.

const char kSecurityIndicatorHelpCenterUrl[] =
    "https://support.google.com/chrome/answer/95617?hl=en";	 

Other support links in url_constants.cc don't seem to specify the hl=en parameter.

Test page: http://rsolomakhin.github.io/autofill/
 
Cc: meggynwatkins@chromium.org
Hey Megg, do you have any idea how we can smartly link to the right language support page in Chrome UI?
I think we can just remove the locale parameter and it will detect the browser language and redirect as appropriate, no? When I launch with LANGUAGE=fr_FR and thereby get a French UI, going to https://support.google.com/chrome/answer/95617 (no param) redirects to the French language page.
Owner: lshang@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/873d4ac7f893b5f84702a5fe5787045e82b1047a

commit 873d4ac7f893b5f84702a5fe5787045e82b1047a
Author: lshang <lshang@chromium.org>
Date: Thu Jan 05 13:25:22 2017

Http Bad: Remove locale parameter in 'Learn more' link url

So that browser can redirect it to the help center page in different language.

BUG= 678400 

Review-Url: https://codereview.chromium.org/2618683002
Cr-Commit-Position: refs/heads/master@{#441644}

[modify] https://crrev.com/873d4ac7f893b5f84702a5fe5787045e82b1047a/chrome/browser/ui/autofill/chrome_autofill_client.cc

Status: Fixed (was: Assigned)
Sorry for the delay in response here: yes, removing the parameter was the right way to go :)

Can you confirm that the link in the code is https://support.google.com/chrome/answer/95617? Because all in-product links should be in the form of "p-links" such as https://support.google.com/chrome/?p=ui_security_indicator
Yes, we are using the answer number link. We seem to have a lot of these in Chrome, like https://support.google.com/chrome/answer/96817 for crash reporting and https://support.google.com/chrome/a/answer/3017014 for public sessions and https://support.google.com/chrome/answer/185277 for sign in, among countless others.

If we ought to be using p links for all of these, we should probably file a new bug since there are many. How does one derive the p link param value for a given answer URL?
Yes, all in-product links should use p-links (or OTA). It helps me track traffic to the help center, and allows me to make help changes without requiring Chrome code changes.

I can provide existing or create new p-links for any in-product links that are updated / added. Android and iOS use OTA contexts (go/open-to-article). Just file a bug with me at go/chromeHCrequest :)

For your examples:

https://support.google.com/chrome/answer/96817 for crash reporting
 - https://support.google.com/chrome/?p=cpn_crash_reports for desktop web
 - OTA context "send_crash_report" for Android

https://support.google.com/chrome/a/answer/3017014 for public sessions
 - chrome/a/ is owned by mattwerner@ on the admin help side: he can create a p-link

https://support.google.com/chrome/answer/185277 for sign in
several p-links exists, probably for different "learn more" spots in the product:
 - https://support.google.com/chrome/?p=settings_sign_in
 - https://support.google.com/chrome/?p=cpn_signin
 - https://support.google.com/chrome/?p=settings_sync_all
thanks for the answer, but there are ~43 places we need to update, so I was hoping for a more automated process :~(. Anyway, filed this: bug 679462

Sign in to add a comment