New issue
Advanced search Search tips

Issue 678395 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 679170
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutBoxModelObject::invalidateStickyConstraints

Project Member Reported by ClusterFuzz, Jan 4 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Jan 5 2017

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 5 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 5 2017

Labels: Pri-1
Components: Blink>Layout
Owner: e...@chromium.org
Status: Available (was: Untriaged)
eae@, could you please help to find an owner for another Layout crash?
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 6 2017

Status: Assigned (was: Available)

Comment 6 by e...@chromium.org, Jan 9 2017

Owner: flackr@chromium.org
No layout changes in regression range, crash in sticky impl; over to flackr.

Comment 7 by e...@chromium.org, Jan 17 2017

Friendly reminder to look into this bug as it's a P1 security bug marked as a release blocker.

Comment 8 by flackr@chromium.org, Jan 17 2017

Status: Started (was: Assigned)
This is probably the same as  issue 679170  but hopefully I can reproduce this failure.

Comment 9 by flackr@chromium.org, Jan 18 2017

Cc: flackr@chromium.org chrishtr@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Started)
I was able to reproduce and bisect the problem. This seems to have regressed with 1b236220b372cebf8ca953af180c1824e478de16 though I'm surprised that an experimental feature would affect content_shell, does it content_shell run with experimental features enabled?

Should we revert this until we identify the underlying cause?
Yes content_shell in layout test mode is run with experimental features enabled. We do this to expose problems earlier for experimental features. Will fix this instead of reverting because this doesn't affect users for now.
Mergedinto: 679170
Status: Duplicate (was: Assigned)
Merge into  bug 679170  because the proposed CL will also fix this bug.
Project Member

Comment 12 by ClusterFuzz, Jan 20 2017

ClusterFuzz has detected this issue as fixed in range 444813:444844.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6037737645015040

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60f000050b98
Crash State:
  blink::LayoutBoxModelObject::invalidateStickyConstraints
  blink::LayoutBlock::updateAfterLayout
  blink::LayoutBlockFlow::layoutBlock
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_content_shell&range=441240:441358
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_content_shell&range=444813:444844

Minimized Testcase (0.32 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97D4KQEauBi977pCHs0J8m8o2vWKOQqJlMtdWC2RbzO27BYEa5tqkF2njenCV13SmZ7NwGebQBZ7opRkvq6yETWcxort_P5TM5ACEDc_RgeTheOBvc4bGndhoADb7n1YRcnD8SRBQu36f9tktGqpArNrrzBjsuzhkx7xR5l7NS7bKKxCFN5E5dOLRbThtqIVTG7a3Kxn8srCCy03fuKNnARJyi9dMb0J0kn1lWg-x9Xc54_HNwaR789svpIS9__rY_Vf6jEZXc1DrwDiMy_6W9_kEgbA_r0w7_zjHxo9Ts_H15JOSrwU372aX7mrmBIdI5PyP41yaVEdXh3EPI9uSeCEb04FqflXJxsoY0FeMgII8E5Y93V-geD6PtgNeNM2Kr0QjSVzKbuEQpYMRj3riJgc9nHKg?testcase_id=6037737645015040

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment