Network panel errors with unknown type error when default color is used for waterfall |
||||||||
Issue descriptionIf you go to a site where the resource type is not in the list: Network.NetworkWaterfallColumn._colorsForResourceType devtools tries to use "Network.NetworkWaterfallColumn._colorsForResourceType.Other", but it should be lower case.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aae7548bfd243de6452e770e42884ead54093485 commit aae7548bfd243de6452e770e42884ead54093485 Author: allada <allada@chromium.org> Date: Tue Jan 10 03:03:37 2017 [Devtools] Fixed undefined type in Network Waterfall for Other types This patch fixes issue where the network waterfall cannot resolve the type color of Other if the mime-type is not in the list of known types. (ie: when it resolves to default type "other") R=dgozman BUG= 678392 Review-Url: https://codereview.chromium.org/2609863005 Cr-Commit-Position: refs/heads/master@{#442459} [modify] https://crrev.com/aae7548bfd243de6452e770e42884ead54093485/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
,
Jan 11 2017
,
Jan 11 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 11 2017
,
Jan 11 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2017
Your change has been approved for M56, please merge ASAP.
,
Jan 16 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
DevTools is OS-All I presume.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac8ad65bd29924d18cf5d015e686c11403704b99 commit ac8ad65bd29924d18cf5d015e686c11403704b99 Author: allada <allada@chromium.org> Date: Thu Jan 19 01:25:11 2017 [Devtools] Fixed undefined type in Network Waterfall for Other types This patch fixes issue where the network waterfall cannot resolve the type color of Other if the mime-type is not in the list of known types. (ie: when it resolves to default type "other") R=dgozman BUG= 678392 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2609863005 Cr-Commit-Position: refs/heads/master@{#442459} (cherry picked from commit aae7548bfd243de6452e770e42884ead54093485) Review-Url: https://codereview.chromium.org/2639423003 Cr-Commit-Position: refs/branch-heads/2924@{#800} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ac8ad65bd29924d18cf5d015e686c11403704b99/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
,
Jan 20 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by allada@chromium.org
, Jan 4 2017