New issue
Advanced search Search tips

Issue 678391 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 472699
issue 876110



Sign in to add a comment

Remove capabilities from chrome://net-internals/ that are duplicated by the net log viewer app

Project Member Reported by eroman@chromium.org, Jan 4 2017

Issue description

* Remove ability to load log files. Instead refer developers/users to the net log viewer app (Ability to save log files should already have been removed)

* Remove visualizers for the NetLog event stream (i.e. #events tab)

* Remove real-time viewing of events and polled data

All that will be left in chrome://net-internals/ after this is chrome://net-internals/#hsts, the Chrome OS stuff, and perhaps some of the action buttons (clear cache, flush sockets, etc).

The rest will be subsumed by chrome://net-export + net log viewer app.
 

Comment 1 by mmenke@chromium.org, May 24 2018

Components: Internals>Services>Network
Labels: Proj-Servicification

Comment 2 by dxie@google.com, Jun 7 2018

Labels: knon

Comment 3 by dxie@google.com, Jun 7 2018

Labels: -knon Hotlist-KnownIssue

Comment 4 by jam@chromium.org, Jun 29 2018

Cc: eroman@chromium.org est...@chromium.org
Eric & Emily: do we need the Domain Security Policy parts, i.e. the HSTS/PKP & Expect-CT section? I'm wondering if they're used and so we need to convert them to work with out-of-process networking, or we can remove them?

Comment 5 by eroman@chromium.org, Jun 29 2018

Cc: palmer@chromium.org
I'll defer that answer to Emily or Chris.

I believe #hsts is the only way to look at that data right now, and is used, so that or something analogous will be needed.

Comment 6 by est...@chromium.org, Jun 29 2018

Dynamic PKP is going away, so we might be able to strip off some of that functionality, but it would be useful to keep the HSTS and Expect-CT parts.
Blockedon: 876110
Labels: -Hotlist-KnownIssue
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Labels: ReleaseBlock-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 7

Cc: dxie@google.com
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable
[dxie]:  Per the email I sent you earlier, release blocker means stable should not be released without this fixed.  I believe you attached the label meaning that the network service shouldn't go to stable without this fixed, which is not what the label means.
Labels: -Pri-3 Proj-Servicification-Stable Hotlist-KnownIssue Pri-1
Re Comment #12, i added Proj-Servicification-Stable to track and updated the bug to reflect.
Owner: mattm@chromium.org
Status: Started (was: Available)
Labels: M-71
Blocking: 876110
Blockedon: -876110
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d

commit 6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d
Author: Matt Mueller <mattm@chromium.org>
Date: Fri Sep 21 00:26:06 2018

chrome://net-internals: Remove netlog & polled data viewing & importing.

This information can be viewed using chrome://net-export to save a log,
and viewing the log with the external netlog_viewer project:
https://chromium.googlesource.com/catapult/+/master/netlog_viewer/

Bug:  678391 
Change-Id: I911d21002c1615f85de02ef2982ddb4abd935a16
Reviewed-on: https://chromium-review.googlesource.com/1228483
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593019}
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/alt_svc_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/alt_svc_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/bandwidth_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/bandwidth_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/browser_bridge.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/capture_status_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/capture_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/capture_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/details_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/dns_view.html
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/dns_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/events_tracker.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/events_view.css
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/events_view.html
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/events_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/halted_status_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/horizontal_scrollbar_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/http_cache_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/http_cache_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/import_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/import_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/index.html
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/index.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/loaded_status_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/log_grouper.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/log_util.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/log_view_painter.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/main.css
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/main.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/modules_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/modules_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/mouse_over_help.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/prerender_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/prerender_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/proxy_view.html
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/proxy_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/quic_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/quic_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/reporting_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/reporting_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/resizable_vertical_split_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/socket_pool_wrapper.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/sockets_view.html
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/sockets_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/source_entry.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/source_filter_parser.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/source_row.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/source_tracker.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/spdy_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/spdy_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/status_view.css
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/status_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/table_printer.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/time_util.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/timeline_data_series.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/timeline_graph_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/timeline_view.css
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/timeline_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/timeline_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/top_bar_view.html
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/top_bar_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/browser/resources/net_internals/top_mid_bottom_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/resources/net_internals/util.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.h
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/bandwidth_view.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/test/data/webui/net_internals/dns_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/events_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/log_util.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/log_view_painter.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/test/data/webui/net_internals/main.js
[modify] https://crrev.com/6d4874c7df2f10eec4c4dbe7d65ec6416b3eb14d/chrome/test/data/webui/net_internals/net_internals_test.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/prerender_view.js
[delete] https://crrev.com/bde2d7652e5b47fc8a2c5e18e932f8ce171a9510/chrome/test/data/webui/net_internals/timeline_view.js

Status: Fixed (was: Started)
Description: Show this description
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb1e2a041dbff380b15f8611856f53f2804e0565

commit cb1e2a041dbff380b15f8611856f53f2804e0565
Author: Matt Mueller <mattm@chromium.org>
Date: Tue Nov 06 21:51:38 2018

remove network_browser_tests filters for NetInternalsTest tests that no longer exist

Bug:  678391 
Change-Id: I7751e50a050d32f826315832d6e250137eaba1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1320730
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605830}
[modify] https://crrev.com/cb1e2a041dbff380b15f8611856f53f2804e0565/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Sign in to add a comment