New issue
Advanced search Search tips

Issue 678386 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 180232
issue 438656
issue 679021

Blocking:
issue 472699



Sign in to add a comment

Make chrome://net-export/ the default for saving NetLog files on all platforms.

Project Member Reported by eroman@chromium.org, Jan 4 2017

Issue description

* Remove support for saving NetLog files from chrome://net-internals/ (i.e. neuter the #export tab).

* Update the instructions at https://dev.chromium.org/for-testers/providing-network-details

The supported ways to generate NetLog files will both use C++ side code to produce the logs:

 (1) chrome://net-export/
 (2) chrome --log-net-log=FILE
 
Blockedon: 438656
Blockedon: 679021
Blockedon: 180232
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af8682325e9d307418b66df111c639f9bb1792d

commit 2af8682325e9d307418b66df111c639f9bb1792d
Author: wangyix <wangyix@google.com>
Date: Wed Mar 01 03:41:10 2017

Replace net-internals/export tab with deprecation msg and button to show old UI.

BUG=472699, 678386 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2722483004
Cr-Commit-Position: refs/heads/master@{#453830}

[modify] https://crrev.com/2af8682325e9d307418b66df111c639f9bb1792d/chrome/browser/resources/net_internals/export_view.html
[modify] https://crrev.com/2af8682325e9d307418b66df111c639f9bb1792d/chrome/browser/resources/net_internals/export_view.js

Status: Fixed (was: Available)
Labels: M-58
Looks like this is M58? Someone should probably update https://dev.chromium.org/for-testers/providing-network-details when M58 goes stable.

Comment 7 by eroman@chromium.org, Apr 14 2017

Agreed.

Comment 8 by eroman@chromium.org, Apr 26 2017

FYI:  I updated  https://dev.chromium.org/for-testers/providing-network-details now that M58 has hit stable.
Project Member

Comment 9 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f495e07e33659fed8591fcabf5f3616c1042a2

commit a7f495e07e33659fed8591fcabf5f3616c1042a2
Author: eroman <eroman@chromium.org>
Date: Fri May 05 02:12:35 2017

Delete chrome://net-internals/#export

This was deprecated since M58 (having been replaced by
chrome://net-export/)

If users still have bookmarks to #export, they will now get a dialog
prompt asking them if they want to be redirected to
chrome://net-export/

BUG= 678386 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856223006
Cr-Commit-Position: refs/heads/master@{#469574}

[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/browser/resources/net_internals/capture_view.js
[delete] https://crrev.com/2233a90a6442f3d4f927cc47df918898edbf4fb2/chrome/browser/resources/net_internals/export_view.html
[delete] https://crrev.com/2233a90a6442f3d4f927cc47df918898edbf4fb2/chrome/browser/resources/net_internals/export_view.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/browser/resources/net_internals/index.html
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/browser/resources/net_internals/index.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/browser/resources/net_internals/log_util.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/browser/resources/net_internals/main.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/test/data/webui/net_internals/log_util.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/test/data/webui/net_internals/main.js
[modify] https://crrev.com/a7f495e07e33659fed8591fcabf5f3616c1042a2/chrome/test/data/webui/net_internals/net_internals_test.js

Hello sorry for asking a question on this bug report, does this all of chrome "chrome://net-internals/" is going away, or only the export part from it? like I use the dns part sometimes is that going away.
The plan is for it all to go away, so you'd need to use about:net-export and then import it.  We may work on some way to continuously import data.  The motivations here are slimming down Chrome, and making it a bit easier to hack on about:net-internals code (See linked bug, issue 472699).
Timeline for this is unclear - it's pretty low priority, so something people work on as time permits.
What problem will this proposed change fix?

If net-internals is removed, it will be a real problem for sysadmins/developers who often need to clear the host cache when moving/migrating/testing/modifying websites.

I don't wish to start a flame war here but .. "change for change sake" springs to mind.


Bloat in the default chrome install.  It will also make it easier to hack on the net-internals interface (Which just be independent HTML and JS, without the browser hooks).

Sign in to add a comment