MD Settings: storage management: no indication that clicking subpage arrow means "delete this type of data" |
|||||||||||
Issue description
In md-settings, generally clicking a right-facing arrow means "go to subpage" if there's no other text.
Right now in storage management, clicking a right-facing arrow prompts "delete X?" where X might be {offline files, other users} etc.
Additionally, if 0B of offline files exist, why should we show the ability to delete these... 0B? Maybe this is a fake CrOS thing, but I bet once you delete a type (i.e. "Offline files") we don't disable that type when the deleting finishes. Any time there's nothing to delete, the UI to delete ... nothing ... should be hidden.
,
Jan 24 2017
,
Jan 25 2017
+mitsuji@ Regarding the rows which have 0B, I think there are some options: 1) Hide the row. 2) Disable the row and hide right arrow. 3) Make the row unclickable and hide right arrow. As the size calculation can take some time, I think we should show every row with "Calculating..." text, to make it work as entry point for each management function. If we show every row at the first time, I think 1) should be avoided. For the right arrow icon, I thought we should use it when we open a dialog inside Settings. Should we add sub texts (like "Control your browsing data" below "Clear browsing data") row, or should we use other type of icon to open these dialogs?
,
Jan 25 2017
+elizabethchiu@ and +sebastien@ I don't recall adding a right arrow in the design but Elizabeth/Sebastien can elaborate here. As for the 0B use case, I'd like to keep the line item but gray it out without the arrow/link to delete.
,
Jan 30 2017
I attached 2 previews and a spec. +bettes for double check. We should disabled the "DELETE" button when calculating or when offline files = 0B When calculating, it should show calculating and keep "DELETE" Disabled. When files are found, clicking "DELETE" opens the dialog we see today.
,
Jan 30 2017
Typo in my mock, "12" and "MB" should obviously have spacing.
,
Jan 31 2017
Thank you for the mock! I'll update the implementation.
,
Feb 2 2017
why wouldn't we put the "Calculating..." and "12MB" as secondary text Downloads | DELETE (disabled) Calculating.... Downloads | DELETE (enabled) 12MB it might cause less flicker and stack less controls(?)
,
Feb 3 2017
ping PM/UX ^
,
Feb 3 2017
I guess that's a questions for Alan as this would impact his design template. I am not too concerned by the flicker as it's only for one row and as it only impact a string, not the layout or spacing.
,
Feb 3 2017
Talked with Sebastien offline, go ahead and move to the two-line format. Thanks all!
,
Feb 6 2017
could we also use a trashcan icon instead of DELETE? IT MAKES IT LOOK LESS LIKE I'M YELLING DELETE A BUNCH
,
Feb 6 2017
plus 1 for using the trashcan icon.
,
Feb 6 2017
,
Feb 6 2017
Yes that's fine :)
,
Feb 13 2017
We should be sure to fix this for 58, thanks!
,
Feb 14 2017
Updated the design as specified in Comment 8 with a trash icon instead of the "DELETE" label button.) CL in review: https://codereview.chromium.org/2663163002/ The screenshots (when offline file exists and when it doesn't exist) are attached.
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dfc69252853f9c5410584e5087958006fe89da8 commit 7dfc69252853f9c5410584e5087958006fe89da8 Author: fukino <fukino@chromium.org> Date: Tue Feb 14 03:41:07 2017 MD settings: Storage: Add delete icon button for deleting Drive offline files. Right-arrow icon is not appropriate for a button to delete offline files, so it should be replaced with delete button. Deleting 0B of offline files does not make sense, so we should hide the delete button when the Drive cache size is 0B or unknown. In addition, this CL makes each row two-line to show the size as secondary text. BUG= 678383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2663163002 Cr-Commit-Position: refs/heads/master@{#450222} [modify] https://crrev.com/7dfc69252853f9c5410584e5087958006fe89da8/chrome/browser/resources/settings/device_page/storage.html [modify] https://crrev.com/7dfc69252853f9c5410584e5087958006fe89da8/chrome/browser/resources/settings/device_page/storage.js [modify] https://crrev.com/7dfc69252853f9c5410584e5087958006fe89da8/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
,
Feb 15 2017
Is this fixed?
,
Feb 16 2017
Yes, it's fixed.
,
Mar 7 2017
ChromeOS 9334.0.0 / 58.0.3028.0 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dbeam@chromium.org
, Jan 24 2017