New issue
Advanced search Search tips

Issue 678371 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

painter factory functions should return unique_ptr

Project Member Reported by est...@chromium.org, Jan 4 2017 
views::Painter::CreateImagePainter, views::Painter::CreateSolidRoundRectPainter, etc. should return std::unique_ptr<Painter> instead of a raw pointer.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477aca494328faf52dfb88b9926933e94241debe

commit 477aca494328faf52dfb88b9926933e94241debe
Author: estade <estade@chromium.org>
Date: Thu Jan 19 17:59:35 2017

Change Painter factory functions to unique_ptr

No behavioral changes.

BUG= 678371 

Review-Url: https://codereview.chromium.org/2637383003
Cr-Commit-Position: refs/heads/master@{#444783}

[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ash/common/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/background.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/background.h
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/controls/button/label_button_border.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/controls/button/label_button_border.h
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/corewm/tooltip_aura.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/painter.cc
[modify] https://crrev.com/477aca494328faf52dfb88b9926933e94241debe/ui/views/painter.h

Comment 2 by est...@chromium.org, Jan 19 2017

Owner: est...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment