New issue
Advanced search Search tips

Issue 678368 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Dec 2017
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove "using <namespace>"from data_reduction_proxy_headers.cc

Project Member Reported by ryansturm@chromium.org, Jan 4 2017 
All of the types should be prefixed with their namespace.

Comment 1 by ryansturm@chromium.org, Jan 4 2017

Labels: CleanUp

Comment 2 by bengr@chromium.org, Jan 9 2017

Status: Available (was: Untriaged)

Comment 3 by megjab...@chromium.org, Jun 29 2017

Owner: megjab...@chromium.org
Status: Assigned (was: Available)

Comment 4 by megjab...@chromium.org, Oct 4 2017

Cc: bengr@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marking available for a new owner

Comment 5 by ryansturm@chromium.org, Oct 4 2017

Owner: ryansturm@chromium.org
Status: Assigned (was: Available)
I am already knocking one of these off in a CL, so I can take the bug.

Comment 6 by bengr@chromium.org, Dec 1 2017 

Refreshed during triage.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680276eccd3658c38095bc414c4bba4bb5283029

commit 680276eccd3658c38095bc414c4bba4bb5283029
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Dec 04 21:48:41 2017

Removing using base::StringPiece from Data_reduction_proxy

It's an anti-pattern to have "using" for a namespace that contains
methods that the code depends on.

Bug:  678368 
Change-Id: Icbfbceb35c2384fd6ae20c187d579f1df7913a90
Reviewed-on: https://chromium-review.googlesource.com/803619
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521470}
[modify] https://crrev.com/680276eccd3658c38095bc414c4bba4bb5283029/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc

Comment 8 by ryansturm@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment