Assertion failed in updateHoverActiveState |
||||||||||||||
Issue descriptionChrome Version: 57.0.2971.0 (DEBUG build) OS: Linux What steps will reproduce the problem? (0) Using touch screen to scroll. (1) Scroll to the end of page. (2) Scroll to down(touch move up) release when mouse cursor leave window. What happens instead? ``` [1:1:0104/153832.035469:FATAL:Document.cpp(6106)] Check failed: !request.readOnly(). #0 0x7f238d98c6ce base::debug::StackTrace::StackTrace() #1 0x7f238d9f9daf logging::LogMessage::~LogMessage() #2 0x7f2373b957d0 blink::Document::updateHoverActiveState() #3 0x7f23743c228f blink::EventHandler::handleMouseMoveOrLeaveEvent() #4 0x7f23743c2939 blink::EventHandler::handleMouseLeaveEvent() #5 0x7f237d48c0fa blink::PageWidgetEventHandler::handleMouseLeave() #6 0x7f237d51f754 blink::WebFrameWidgetImpl::handleMouseLeave() #7 0x7f237d48bde3 blink::PageWidgetDelegate::handleInputEvent() #8 0x7f237d51dc02 blink::WebFrameWidgetImpl::handleInputEvent() #9 0x7f23880b69f7 content::RenderWidgetInputHandler::HandleInputEvent() #10 0x7f23882452e0 content::RenderWidget::OnHandleInputEvent() #11 0x7f2388099581 _ZN4base20DispatchToMethodImplIPN7content16IdleUserDetectorEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEERKSt5tupleIJS7_S9_SC_EEJLm0ELm1ELm2EEEEvRKT_T0_OT1_NS_13IndexSequenceIJXspT2_EEEE #12 0x7f238823b470 _ZN4base16DispatchToMethodIPN7content14RenderViewImplEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEERKSt5tupleIJS7_S9_SC_EEEEvRKT_T0_OT1_ #13 0x7f2388257a2f _ZN3IPC16DispatchToMethodIN7content12RenderWidgetEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEEvSt5tupleIJS6_S8_SB_EEEEvPT_T0_PT1_RKT2_ #14 0x7f238824f71f _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINS9_12RenderWidgetESE_vMSE_FvS6_RKS8_SA_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #15 0x7f2388243e5b content::RenderWidget::OnMessageReceived() #16 0x7f238a871a8b IPC::MessageRouter::RouteMessage() #17 0x7f2386361378 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage() #18 0x7f238a871a0e IPC::MessageRouter::OnMessageReceived() #19 0x7f2386365841 content::ChildThreadImpl::OnMessageReceived() #20 0x7f238a816c68 IPC::ChannelProxy::Context::OnDispatchMessage() #21 0x7f238a81d7af _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIRK13scoped_refptrIS4_EJS7_EEEvS9_OT_DpOT0_ #22 0x7f238a81d696 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_ #23 0x7f238a81d623 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKSt5tupleIJSC_S6_EEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #24 0x7f238a81d53c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #25 0x7f238d992581 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv #26 0x7f238d991f52 base::debug::TaskAnnotator::RunTask() #27 0x7f237ddc919a blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #28 0x7f237ddc6bc1 blink::scheduler::TaskQueueManager::DoWork() #29 0x7f237ddcf65c _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKS5_RKbEEEvS7_OT_DpOT0_ #30 0x7f237ddcf534 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbERKNS_7WeakPtrIS6_EEJRKS7_RKbEEEvOT_OT0_DpOT1_ #31 0x7f237ddcf494 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE7RunImplIRKS8_RKSt5tupleIJSA_S6_bEEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #32 0x7f237ddcf36c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE3RunEPNS0_13BindStateBaseE #33 0x7f238d992581 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv #34 0x7f238d991f52 base::debug::TaskAnnotator::RunTask() #35 0x7f238da22eba base::MessageLoop::RunTask() #36 0x7f238da23144 base::MessageLoop::DeferOrRunPendingTask() #37 0x7f238da2342e base::MessageLoop::DoWork() #38 0x7f238da3abc3 base::MessagePumpDefault::Run() #39 0x7f238da22a3a base::MessageLoop::RunHandler() #40 0x7f238dad0292 base::RunLoop::Run() #41 0x7f23882797ec content::RendererMain() #42 0x7f23886857de content::RunZygote() #43 0x7f2388685b90 content::RunNamedProcessTypeMain() #44 0x7f2388687f8b content::ContentMainRunnerImpl::Run() #45 0x7f2388684e82 content::ContentMain() #46 0x7f238ea9b3ca ChromeMain #47 0x7f238ea9b2f2 main #48 0x7f2379fd2f45 __libc_start_main #49 0x7f238ea9b1f5 <unknown> ```
,
Jan 4 2017
,
Jan 4 2017
,
Jan 13 2017
The readonly flags is set in EventHandler::handleMouseMoveOrLeaveEvent
```
if (m_pointerEventManager->isAnyTouchActive())
hitType |= HitTestRequest::Active | HitTestRequest::ReadOnly;
```
,
Jan 20 2017
+mustaq@, nzolghadr@, please help triage this.
,
Feb 21 2017
Issue 694214 has been merged into this issue.
,
Feb 22 2017
Detected 3 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 23 2017
Detected 5 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app.
,
Feb 24 2017
Detected 3 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app.
,
Feb 27 2017
After discussion with mustaq@, I've changed this bug to P2 due to flake it introduced and I'm removing the sheriff label as mustaq@ will be taking care of it.
,
Feb 28 2017
Detected 3 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 28 2017
Couldn't repro the issue manually. Any idea how I can run the tests locally?
,
Feb 28 2017
cc-ing perezju@ who owns system_health.memory_desktop benchmarks. Still trying to repro locally.
,
Mar 1 2017
Detected 3 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app.
,
Mar 1 2017
Recent failure is a bit different:
[1:1:0228/225252.314705:FATAL:FindPropertiesNeedingUpdate.h(162)] Check failed: *m_originalProperties->scrollTranslation() == *objectProperties->scrollTranslation(). Property was updated without the layout object ("LayoutBlockFlow (positioned) DIV id='permalink-overlay' class='PermalinkOverlay PermalinkOverlay-with-background'") needing a paint property update.
Original:
parent=0x36d1755b8880 transform=translation(0,-397,0) origin=0,0,0 flattensInheritedTransform=yes renderingContextId=0 directCompositingReasons=none compositorElementId=(9, 0) scroll=parent=0x36d1754c37b0 clip=1270x675 bounds=1255x2405 userScrollable=both mainThreadReasons=none scrollClient=0x20173858e770
Updated:
parent=0x36d1755b8880 transform=translation(0,-397,0) origin=0,0,0 flattensInheritedTransform=yes renderingContextId=0 directCompositingReasons=none compositorElementId=(9, 0) scroll=parent=0x36d1754c37b0 clip=1270x675 bounds=1255x3143 userScrollable=both mainThreadReasons=none scrollClient=0x20173858e770
#0 0x7fcbd71cecd7 base::debug::StackTrace::StackTrace()
#1 0x7fcbd71e8aeb logging::LogMessage::~LogMessage()
#2 0x7fcbda22cb0d blink::FindObjectPropertiesNeedingUpdateScope::~FindObjectPropertiesNeedingUpdateScope()
#3 0x7fcbda22ffed blink::PaintPropertyTreeBuilder::updatePropertiesForChildren()
#4 0x7fcbda20c99e blink::PrePaintTreeWalk::walk()
#5 0x7fcbda20cc75 blink::PrePaintTreeWalk::walk()
#6 0x7fcbda20cc75 blink::PrePaintTreeWalk::walk()
#7 0x7fcbda20cc75 blink::PrePaintTreeWalk::walk()
#8 0x7fcbda20cc75 blink::PrePaintTreeWalk::walk()
#9 0x7fcbda20c703 blink::PrePaintTreeWalk::walk()
#10 0x7fcbda20c593 blink::PrePaintTreeWalk::walk()
#11 0x7fcbd9c809df blink::FrameView::prePaint()
#12 0x7fcbd9c7ed14 blink::FrameView::updateLifecyclePhasesInternal()
#13 0x7fcbd9c7e721 blink::FrameView::updateAllLifecyclePhases()
#14 0x7fcbda18f9fa blink::PageAnimator::updateAllLifecyclePhases()
#15 0x7fcbd95cb414 blink::WebViewImpl::updateAllLifecyclePhases()
#16 0x7fcbda9783b7 content::RenderWidget::UpdateVisualState()
#17 0x7fcbd80b0cdd cc::ProxyMain::BeginMainFrame()
,
Mar 1 2017
More flakiness on system health smoke tests.
,
Mar 1 2017
To #12: you can run the test locally with: ./tools/perf/run_tests --browser=<...> benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter
,
Mar 3 2017
Detected 7 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Mar 6 2017
I couldn't repro the bug in my desktop with a touchscreen, but chaopeng@ can easily repro using the same touchscreen. Assigning to him for debugging, thanks.
,
Mar 6 2017
Detected 3 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app.
,
Mar 7 2017
Issue 698769 has been merged into this issue.
,
Mar 7 2017
For records as chaopeng@ discovered yesterday: whenever a touchdrag leaves the current window or subframe, we hit this assertion failure. We used to change mouse-leave events to mouse-moves which is now fixed but that fix broke some assumptions here. In particular, when a touch-drag leaves the window/sub-frame boundary, we still want to update the hover/active state in the "touchstart" frame w/o a hittest. Currently EventHandler::handleMouseMoveOrLeaveEvent do this for a mouse-leave (forceLeave=false). The problem is that Document::updateHoverActiveState doesn't seem to "know" about the "w/o hittest" case. Perhaps the failing DCHECK should check: !request.readOnly() || (!innerElement && !hitScrollbar) instead?
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a06624223475946620e19af8322f7cf4ebd8dc1 commit 7a06624223475946620e19af8322f7cf4ebd8dc1 Author: chaopeng <chaopeng@chromium.org> Date: Thu Mar 09 02:42:50 2017 Remove ReadOnly flag when mouseleave with touch In this patch, we remove ReadOnly flag when mouseleave with touch in EventHandler::handleMouseMoveOrLeaveEvent since we want to updateHoverActiveState without hit test for this case. BUG= 678363 Review-Url: https://codereview.chromium.org/2734153003 Cr-Commit-Position: refs/heads/master@{#455647} [modify] https://crrev.com/7a06624223475946620e19af8322f7cf4ebd8dc1/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/7a06624223475946620e19af8322f7cf4ebd8dc1/third_party/WebKit/Source/core/input/EventHandler.cpp
,
Mar 9 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by chaopeng@chromium.org
, Jan 4 2017