New issue
Advanced search Search tips

Issue 678356 link

Starred by 2 users
Status: Fixed
Owner:
kojii@chromium.org
Closed: Jan 2017
Cc:
kojii@chromium.org
pbomm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CSS hyphens auto value behaviour in Chrome 55.0.2883.95

Reported by jonlee...@gmail.com, Jan 4 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. Create a css class that has both white-space: nowrap and hyphens: auto

Here's a better description of the issue with fiddle inside.
http://stackoverflow.com/questions/41449969/css-hyphens-behaviour-change-in-chrome-55-0-2883-95

What is the expected behavior?
Other browsers (Safari, FF, IE) truncates the content with ellipsis.

What went wrong?
Only Mac's Chrome wraps the content.

Did this work before? Yes 55.0.2883.87

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.10.5
Flash Version: 

I can't really say that it was "working" in previous versions.
Obviously, "auto" value of hyphen wasn't being supported for 54 and prior versions according to http://caniuse.com/#search=hyphens
Screen Shot 2017-01-03 at 12.17.12 PM.png
43.0 KB View Download

Comment 1 by pbomm...@chromium.org, Jan 4 2017

Cc: pbomm...@chromium.org kojii@chromium.org
Components: -UI Blink>Layout
Labels: M-56 Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on latest Chrome Stable i.e., 55.0.2883.95, Beta(56.0.2924.51) and Dev(57.0.2970.0) on Mac, The same works fine on previous stable i.e., 54.0.2840.98.

The same works fine on Windows 7,10 and Linux, I am tagging M56 given this was working in M54 and at the moment we don't have any M55 updates.

Comment 2 by krajshree@chromium.org, Jan 5 2017

Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision Pri-1
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Mac 10.12.2 using chrome reported version #55.0.2883.95 and latest canary #57.0.2971.0.
Unable to reproduce this issue on Win-10 and Ubuntu 14.04.

Bisect Information:
=====================
Good build: 55.0.2865.0	Revision(419399)

Bad Build : 55.0.2866.0	Revision(419628)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/5da3189d5d0faa56d75bd261f7d76248c40daa30..ed7e106e0e48b3afb160a5bdbb37649e307d2b05

From the above change log suspecting below change

Review url: https://codereview.chromium.org/2342553003

kojii@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 4 by kojii@chromium.org, Jan 6 2017

Labels: Merge-Request-56
Status: Fixed (was: Assigned)
Thank you for reporting this issue to us, fixed.
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 7 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27f019ad0ef6a03af5162627a4b40395f95dd7f

commit c27f019ad0ef6a03af5162627a4b40395f95dd7f
Author: Koji Ishii <kojii@chromium.org>
Date: Mon Jan 09 07:49:46 2017

Merge 2924: Fix 'hyphens: auto' to work only when line wrapping is allowed

This patch fixes 'hyphens: auto' to work only when line wrapping is
allowed.

BUG= 678356 

Review-Url: https://codereview.chromium.org/2614743004
Cr-Commit-Position: refs/heads/master@{#441805}
(cherry picked from commit 6715bcb1960f4062e2f6daf261e3da76c7d62019)

Review-Url: https://codereview.chromium.org/2621563002 .
Cr-Commit-Position: refs/branch-heads/2924@{#699}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c27f019ad0ef6a03af5162627a4b40395f95dd7f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/c27f019ad0ef6a03af5162627a4b40395f95dd7f/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-auto-nowrap-expected.html
[add] https://crrev.com/c27f019ad0ef6a03af5162627a4b40395f95dd7f/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-auto-nowrap.html
[modify] https://crrev.com/c27f019ad0ef6a03af5162627a4b40395f95dd7f/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/c27f019ad0ef6a03af5162627a4b40395f95dd7f/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Comment 7 by jonlee...@gmail.com, Jan 9 2017 

Thank you for prompt fix!

Comment 8 by krajshree@chromium.org, Jan 11 2017

Labels: TE-Verified-M56 TE-Verified-56.0.2924.59
Verified the fix on Mac 10.12.2 using Chrome beta version #56.0.2924.59 as per the comment #0.

Observed that mac truncated the content with ellipsis as expected.

Hence, the fix is working as expected.

Attaching the screencast for reference

Adding the verified labels.

Thanks...!!
678356.mp4
1001 KB View Download

Comment 9 by kojii@chromium.org, Jan 23 2017 

 Issue 680916  has been merged into this issue.
►

Sign in to add a comment